Skip to contentSkip to conversation

python3-speedtest-cli: fix RDEPENDS

PATCH In review Bartosz Golaszewski 2 participants 4 messages May 19, 2022 – May 24, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 python3-speedtest-cli: fix RDEPENDS

There are packages missing in RDEPENDS needed to run speedtest-cli. Add them and use += for the assignment as we don't know what inherited classes may have added.

---
 .../recipes-devtools/python/python3-speedtest-cli_2.1.3.bb  | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
meta-python/recipes-devtools/python/python3-speedtest-cli_2.1.3.bb +5 -1
index 06d98cbe1..472113b05 100644
@@ -7,4 +7,8 @@ SRC_URI[sha256sum] = "5e2773233cedb5fa3d8120eb7f97bcc4974b5221b254d33ff16e2f1d41
 
 inherit pypi setuptools3
 
-RDEPENDS:${PN} = "${PYTHON_PN}-misc"
+RDEPENDS:${PN} += " \
+    python3-misc \
+    python3-threading \
+    python3-xml \
+"
Signature · 1 line
2.34.1
#1 lore raw

PATCH 2/2 speedtest-cli: drop the recipe

This is the same project as the one in the python3-speedtest-cli recipe in meta-python except that the other one is downloaded from pypi. Drop this recipe.

---
 .../speedtest-cli/speedtest-cli_2.1.3.bb           | 14 --------------
 1 file changed, 14 deletions(-)
 delete mode 100644 meta-oe/dynamic-layers/meta-python/recipes-benchmark/speedtest-cli/speedtest-cli_2.1.3.bb
meta-oe/dynamic-layers/meta-python/recipes-benchmark/speedtest-cli/speedtest-cli_2.1.3.bb deleted +0 -14
deleted file mode 100644
index df577b1b7..000000000
@@ -1,14 +0,0 @@
-SUMMARY = "Command line interface for testing internet bandwidth using speedtest.net"
-AUTHOR = "Matt Martz"
-
-LICENSE="Apache-2.0"
-LIC_FILES_CHKSUM = "file://LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57"
-
-inherit setuptools3
-
-SRC_URI = "git://github.com/sivel/speedtest-cli.git;branch=master;protocol=https"
-SRCREV = "42e96b13dda2afabbcec2622612d13495a415caa"
-
-S = "${WORKDIR}/git"
-
-RDEPENDS:${PN} = "python3 python3-setuptools-scm"
Signature · 1 line
2.34.1
#2 lore raw
In reply to Bartosz Golaszewski
Quoted 25 lines · Bartosz Golaszewski

There are packages missing in RDEPENDS needed to run speedtest-cli. Add them and use += for the assignment as we don't know what inherited classes may have added.

---
 .../recipes-devtools/python/python3-speedtest-cli_2.1.3.bb  | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
meta-python/recipes-devtools/python/python3-speedtest-cli_2.1.3.bb +5 -2
index 06d98cbe1..472113b05 100644
@@ -7,4 +7,8 @@ SRC_URI[sha256sum] = "5e2773233cedb5fa3d8120eb7f97bcc4974b5221b254d33ff16e2f1d41
 
 inherit pypi setuptools3
 
-RDEPENDS:${PN} = "${PYTHON_PN}-misc"
+RDEPENDS:${PN} += " \
+    python3-misc \
+    python3-threading \
+    python3-xml \
+"
--
Quoted 2 lines

2.34.1

Hi!

This has been in master-next for days but didn't get into master proper. Just a gentle ping.

Bart

#3 lore raw
Quoted 32 lines · Bartosz Golaszewski
Quoted 25 lines · Bartosz Golaszewski

There are packages missing in RDEPENDS needed to run speedtest-cli. Add them and use += for the assignment as we don't know what inherited classes may have added.

---
 .../recipes-devtools/python/python3-speedtest-cli_2.1.3.bb  | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
meta-python/recipes-devtools/python/python3-speedtest-cli_2.1.3.bb +5 -2
index 06d98cbe1..472113b05 100644
@@ -7,4 +7,8 @@ SRC_URI[sha256sum] = "5e2773233cedb5fa3d8120eb7f97bcc4974b5221b254d33ff16e2f1d41
 
 inherit pypi setuptools3
 
-RDEPENDS:${PN} = "${PYTHON_PN}-misc"
+RDEPENDS:${PN} += " \
+    python3-misc \
+    python3-threading \
+    python3-xml \
+"
--
Quoted 2 lines

2.34.1

Hi!

Quoted 2 lines

This has been in master-next for days but didn't get into master proper. Just a gentle ping.

Thanks for reminder, if you have not heard on it causing issues then It will be in master in due course soon. Sometimes its other recipes being sorted with current master etc. that delays merges

Quoted 2 lines

Bart