eth: bnxt: make ulp_id unsigned to make GCC 12 happy
Jakub Kicinski
maintainerPATCH 1/1 eth: bnxt: make ulp_id unsigned to make GCC 12 happy
GCC array bounds checking complains that ulp_id is validated only against upper bound. Make it unsigned.
Signed-off-by Jakub Kicinski <[email protected]>
---
CC: [email protected]
--- drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 12 ++++++------ drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h | 12 ++++++------ 2 files changed, 12 insertions(+), 12 deletions(-)
drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c +6 -6
@@ -25,7 +25,7 @@#include "bnxt_hwrm.h" #include "bnxt_ulp.h" -static int bnxt_register_dev (struct bnxt_en_dev *edev,int ulp_id, +static int bnxt_register_dev (struct bnxt_en_dev *edev,unsigned int ulp_id,struct bnxt_ulp_ops *ulp_ops,void *handle) {struct net_device *dev = edev->net;
@@ -62,7 +62,7 @@ static int bnxt_register_dev(struct bnxt_en_dev *edev, int ulp_id,return 0 ; } -static int bnxt_unregister_dev (struct bnxt_en_dev *edev,int ulp_id) +static int bnxt_unregister_dev (struct bnxt_en_dev *edev,unsigned int ulp_id) {struct net_device *dev = edev->net;struct bnxt *bp =netdev_priv (dev);
@@ -115,7 +115,7 @@ static void bnxt_fill_msix_vecs(struct bnxt *bp, struct bnxt_msix_entry *ent) } } -static int bnxt_req_msix_vecs (struct bnxt_en_dev *edev,int ulp_id, +static int bnxt_req_msix_vecs (struct bnxt_en_dev *edev,unsigned int ulp_id,struct bnxt_msix_entry *ent,int num_msix) {struct net_device *dev = edev->net;
@@ -179,7 +179,7 @@ static int bnxt_req_msix_vecs(struct bnxt_en_dev *edev, int ulp_id,return avail_msix; } -static int bnxt_free_msix_vecs (struct bnxt_en_dev *edev,int ulp_id) +static int bnxt_free_msix_vecs (struct bnxt_en_dev *edev,unsigned int ulp_id) {struct net_device *dev = edev->net;struct bnxt *bp =netdev_priv (dev);
@@ -233,7 +233,7 @@ int bnxt_get_ulp_stat_ctxs(struct bnxt *bp)return 0 ; } -static int bnxt_send_msg (struct bnxt_en_dev *edev,int ulp_id, +static int bnxt_send_msg (struct bnxt_en_dev *edev,unsigned int ulp_id,struct bnxt_fw_msg *fw_msg) {struct net_device *dev = edev->net;
@@ -447,7 +447,7 @@ void bnxt_ulp_async_events(struct bnxt *bp, struct hwrm_async_event_cmpl *cmpl)rcu_read_unlock (); } -static int bnxt_register_async_events (struct bnxt_en_dev *edev,int ulp_id, +static int bnxt_register_async_events (struct bnxt_en_dev *edev,unsigned int ulp_id,unsigned long *events_bmap,u16 max_id) {struct net_device *dev = edev->net;
drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h +6 -6
@@ -77,15 +77,15 @@ struct bnxt_en_dev { };struct bnxt_en_ops { -int (*bnxt_register_device)(struct bnxt_en_dev *,int , +int (*bnxt_register_device)(struct bnxt_en_dev *,unsigned int ,struct bnxt_ulp_ops *,void *); -int (*bnxt_unregister_device)(struct bnxt_en_dev *,int ); -int (*bnxt_request_msix)(struct bnxt_en_dev *,int , +int (*bnxt_unregister_device)(struct bnxt_en_dev *,unsigned int ); +int (*bnxt_request_msix)(struct bnxt_en_dev *,unsigned int ,struct bnxt_msix_entry *,int ); -int (*bnxt_free_msix)(struct bnxt_en_dev *,int ); -int (*bnxt_send_fw_msg)(struct bnxt_en_dev *,int , +int (*bnxt_free_msix)(struct bnxt_en_dev *,unsigned int ); +int (*bnxt_send_fw_msg)(struct bnxt_en_dev *,unsigned int ,struct bnxt_fw_msg *); -int (*bnxt_register_fw_async_events)(struct bnxt_en_dev *,int , +int (*bnxt_register_fw_async_events)(struct bnxt_en_dev *,unsigned int ,unsigned long *,u16 ); };
Signature · 1 line
2.34.3
Quoted 8 lines · Jakub Kicinski
GCC array bounds checking complains that
ulp_idis validated only against upper bound. Make it unsigned.Signed-off-by Jakub Kicinski <[email protected]>---
CC: [email protected]
---
Reviewed-by Michael Chan <[email protected]>
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Thu, 19 May 2022 23:19:55 -0700 you wrote:
GCC array bounds checking complains that
ulp_idis validated only against upper bound. Make it unsigned.Signed-off-by Jakub Kicinski <[email protected]>---
CC: [email protected][...]
Here is the summary with links:
- [net-next] eth: bnxt: make ulp_id unsigned to make GCC 12 happy
https://git.kernel.org/netdev/net-next/c/dbb2f362c783
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html