Skip to contentSkip to conversation

x86/vmware: use unsigned integer for shifting

PATCH In review Shreenidhi Shedi 3 participants 4 messages May 20, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/vmware: use unsigned integer for shifting

Shifting signed 32-bit value by 31 bits is implementation-defined behaviour. Using unsigned is better option for this.

---
 arch/x86/kernel/cpu/vmware.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/cpu/vmware.c +1 -1
index c04b933f48d3..b28f789d3c56 100644
@@ -476,7 +476,7 @@ static bool __init vmware_legacy_x2apic_available(void)
 {
 	uint32_t eax, ebx, ecx, edx;
 	VMWARE_CMD(GETVCPU_INFO, eax, ebx, ecx, edx);
-	return (eax & (1 << VMWARE_CMD_VCPU_RESERVED)) == 0 &&
+	return (eax & (1U << VMWARE_CMD_VCPU_RESERVED)) == 0 &&
 	       (eax & (1 << VMWARE_CMD_LEGACY_X2APIC)) != 0;
 }
 
Signature · 1 line
2.36.1
maintainer
#1 lore raw
Quoted 13 lines · Shreenidhi Shedi

Shifting signed 32-bit value by 31 bits is implementation-defined behaviour. Using unsigned is better option for this.

---
 arch/x86/kernel/cpu/vmware.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/cpu/vmware.c +0 -0
index c04b933f48d3..b28f789d3c56 100644

arch/x86/kernel/cpu/vmware.c static bool __init vmware_legacy_x2apic_available(void) · line 480

Quoted 6 lines
arch/x86/kernel/cpu/vmware.c +1 -1
@@ -476,7 +476,7 @@ static bool __init vmware_legacy_x2apic_available(void)
 {
 	uint32_t eax, ebx, ecx, edx;
 	VMWARE_CMD(GETVCPU_INFO, eax, ebx, ecx, edx);
-	return (eax & (1 << VMWARE_CMD_VCPU_RESERVED)) == 0 &&
+	return (eax & (1U << VMWARE_CMD_VCPU_RESERVED)) == 0 &&
 	       (eax & (1 << VMWARE_CMD_LEGACY_X2APIC)) != 0;

Or you can use the BIT() macro and simplify this expression even more:

       return !(eax & BIT(VMWARE_CMD_VCPU_RESERVED)) &&
               (eax & BIT(VMWARE_CMD_LEGACY_X2APIC));
Signature · 4 lines
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette
#2 lore raw

Hi Shreenidhi,

Thank you for the patch!

Quoted 4 lines · Borislav Petkov
Quoted 3 lines · Shreenidhi Shedi

Shifting signed 32-bit value by 31 bits is implementation-defined behaviour. Using unsigned is better option for this.

Can you also add a "Fixes:" tag with the commit that introduced the issue? I believe it is 4cca6ea04d31 ("x86/apic: Allow x2apic without IR on VMware platform").

Quoted 19 lines
Quoted 10 lines
---
 arch/x86/kernel/cpu/vmware.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/cpu/vmware.c +0 -0
index c04b933f48d3..b28f789d3c56 100644

arch/x86/kernel/cpu/vmware.c static bool __init vmware_legacy_x2apic_available(void) · line 480

Quoted 6 lines
arch/x86/kernel/cpu/vmware.c +1 -1
@@ -476,7 +476,7 @@ static bool __init vmware_legacy_x2apic_available(void)
 {
 	uint32_t eax, ebx, ecx, edx;
 	VMWARE_CMD(GETVCPU_INFO, eax, ebx, ecx, edx);
-	return (eax & (1 << VMWARE_CMD_VCPU_RESERVED)) == 0 &&
+	return (eax & (1U << VMWARE_CMD_VCPU_RESERVED)) == 0 &&
 	       (eax & (1 << VMWARE_CMD_LEGACY_X2APIC)) != 0;

Or you can use the BIT() macro and simplify this expression even more:

Quoted 4 lines
       return !(eax & BIT(VMWARE_CMD_VCPU_RESERVED)) &&
               (eax & BIT(VMWARE_CMD_LEGACY_X2APIC));

That's better indeed.

Regards,
Srivatsa
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

#3 lore raw
Quoted 38 lines · Srivatsa S. Bhat

Hi Shreenidhi,

Thank you for the patch!

Quoted 4 lines · Borislav Petkov
Quoted 3 lines · Shreenidhi Shedi

Shifting signed 32-bit value by 31 bits is implementation-defined behaviour. Using unsigned is better option for this.

Can you also add a "Fixes:" tag with the commit that introduced the issue? I believe it is 4cca6ea04d31 ("x86/apic: Allow x2apic without IR on VMware platform").

Quoted 19 lines
Quoted 10 lines
---
 arch/x86/kernel/cpu/vmware.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/cpu/vmware.c +0 -0
index c04b933f48d3..b28f789d3c56 100644

arch/x86/kernel/cpu/vmware.c static bool __init vmware_legacy_x2apic_available(void) · line 480

Quoted 6 lines
arch/x86/kernel/cpu/vmware.c +1 -1
@@ -476,7 +476,7 @@ static bool __init vmware_legacy_x2apic_available(void)
 {
 	uint32_t eax, ebx, ecx, edx;
 	VMWARE_CMD(GETVCPU_INFO, eax, ebx, ecx, edx);
-	return (eax & (1 << VMWARE_CMD_VCPU_RESERVED)) == 0 &&
+	return (eax & (1U << VMWARE_CMD_VCPU_RESERVED)) == 0 &&
 	       (eax & (1 << VMWARE_CMD_LEGACY_X2APIC)) != 0;

Or you can use the BIT() macro and simplify this expression even more:

Quoted 4 lines
       return !(eax & BIT(VMWARE_CMD_VCPU_RESERVED)) &&
               (eax & BIT(VMWARE_CMD_LEGACY_X2APIC));
Quoted 4 lines

That's better indeed.

Regards,
Srivatsa

Thanks for the quick reviews Boris and Srivatsa. I will make the changes and push the another patch soon.

--
Shedi