FS: nfs: removed goto statement
Subsystems (2)
PATCH 1/1 FS: nfs: removed goto statement
In this function goto can be replaced. Avoiding goto will improve the readability
Signed-off-by Javier Abrego<[email protected]>
--- fs/nfs/nfs42xattr.c | 28 +++++++++++++--------------- 1 file changed, 13 insertions(+), 15 deletions(-)
fs/nfs/nfs42xattr.c +13 -15
@@ -747,21 +747,19 @@ void nfs4_xattr_cache_set_list(struct inode *inode, const char *buf,return ; entry =nfs4_xattr_alloc_entry (NULL , buf,NULL , buflen); -if (entry ==NULL ) - goto out; - -/* -* This is just there to be able to get to bucket->cache, -* which is obviously the same for all buckets, so just -* use bucket 0. -*/ - entry->bucket = &cache->buckets[0 ]; - -if (!nfs4_xattr_set_listcache (cache, entry)) -kref_put (&entry->ref, nfs4_xattr_free_entry_cb); - -out: -kref_put (&cache->ref, nfs4_xattr_free_cache_cb); +if (entry ==NULL ) { +kref_put (&cache->ref, nfs4_xattr_free_cache_cb); + }else { +/* +* This is just there to be able to get to bucket->cache, +* which is obviously the same for all buckets, so just +* use bucket 0. +*/ + entry->bucket = &cache->buckets[0 ]; + +if (!nfs4_xattr_set_listcache (cache, entry)) +kref_put (&entry->ref, nfs4_xattr_free_entry_cb); + } }/*
Signature · 1 line
2.25.1
Re: [PATCH] nfs: removed goto statement
Quoted 47 lines · Javier Abrego
In this function goto can be replaced. Avoiding goto will improve the readability
Signed-off-by Javier Abrego<[email protected]>--- fs/nfs/nfs42xattr.c | 28 +++++++++++++--------------- 1 file changed, 13 insertions(+), 15 deletions(-)fs/nfs/nfs42xattr.c +13
-15@@ -747,21 +747,19 @@ void nfs4_xattr_cache_set_list(struct inode *inode, const char *buf, return; entry =nfs4_xattr_alloc_entry (NULL , buf,NULL , buflen); -if (entry ==NULL ) - goto out; - -/* -* This is just there to be able to get to bucket->cache, -* which is obviously the same for all buckets, so just -* use bucket 0. -*/ - entry->bucket = &cache->buckets[0 ]; - -if (!nfs4_xattr_set_listcache (cache, entry)) -kref_put (&entry->ref, nfs4_xattr_free_entry_cb); - -out: -kref_put (&cache->ref, nfs4_xattr_free_cache_cb); +if (entry ==NULL ) { +kref_put (&cache->ref, nfs4_xattr_free_cache_cb); + }else { +/* +* This is just there to be able to get to bucket->cache, +* which is obviously the same for all buckets, so just +* use bucket 0. +*/ + entry->bucket = &cache->buckets[0 ]; + +if (!nfs4_xattr_set_listcache (cache, entry)) +kref_put (&entry->ref, nfs4_xattr_free_entry_cb); + } }
Quoted 3 lines
/*
Signature · 1 line
2.25.1
No, NACK because you removed the kref_put of cache->ref. I find this function quite readable as it is.
Ben