Skip to contentSkip to conversation

ASoC: SOF: amd: Fixed Build error

PATCH In review Syed Saba kareem 2 participants 2 messages May 23, 2022 – May 24, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: SOF: amd: Fixed Build error

Add linux/module.h in acp-pci.c to solve the below dependency

All error/warnings (new ones prefixed by >>):

Quoted 1 line
Quoted 1 line

sound/soc/amd/acp/acp-pci.c:148:1: warning: data definition has no type or storage class

148 | MODULE_DEVICE_TABLE(pci, acp_pci_ids);
| ^~~~~~~~~~~~~~~~~~~

Quoted 1 line
Quoted 1 line

sound/soc/amd/acp/acp-pci.c:148:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int]

...

---
 sound/soc/amd/acp/acp-pci.c | 1 +
 1 file changed, 1 insertion(+)
sound/soc/amd/acp/acp-pci.c +1 -0
index 340e39d7f420..c893963ee2d0 100644
@@ -16,6 +16,7 @@
 #include <linux/pci.h>
 #include <linux/platform_device.h>
 #include <linux/pm_runtime.h>
+#include <linux/module.h>
 
 #include "amd.h"
 #include "../mach-config.h"
Signature · 1 line
2.25.1
maintainer
#1 lore raw
Quoted 11 lines · Syed Saba kareem

Add linux/module.h in acp-pci.c to solve the below dependency

All error/warnings (new ones prefixed by >>):

Quoted 1 line
Quoted 1 line

sound/soc/amd/acp/acp-pci.c:148:1: warning: data definition has no type or storage class

148 | MODULE_DEVICE_TABLE(pci, acp_pci_ids);
| ^~~~~~~~~~~~~~~~~~~

Quoted 1 line
Quoted 1 line

sound/soc/amd/acp/acp-pci.c:148:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int]

...

[...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: SOF: amd: Fixed Build error

      commit: 803a1f7272797faa15a7879cdc70f9adaf3fdcba

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark