Skip to contentSkip to conversation

iio: adc: adi-axi-adc: Fix refcount leak in adi_axi_adc_attach_client

PATCH In review Miaoqian Lin 2 participants 2 messages May 24, 2022 – Jun 3, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: adc: adi-axi-adc: Fix refcount leak in adi_axi_adc_attach_client

of_parse_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak.

Fixes ef04070692a2 ("iio: adc: adi-axi-adc: add support for AXI ADC IP core")
---
 drivers/iio/adc/adi-axi-adc.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/iio/adc/adi-axi-adc.c +3 -0
index a73e3c2d212f..a9e655e69eaa 100644
@@ -322,16 +322,19 @@ static struct adi_axi_adc_client *adi_axi_adc_attach_client(struct device *dev)
 
 		if (!try_module_get(cl->dev->driver->owner)) {
 			mutex_unlock(&registered_clients_lock);
+			of_node_put(cln);
 			return ERR_PTR(-ENODEV);
 		}
 
 		get_device(cl->dev);
 		cl->info = info;
 		mutex_unlock(&registered_clients_lock);
+		of_node_put(cln);
 		return cl;
 	}
 
 	mutex_unlock(&registered_clients_lock);
+	of_node_put(cln);
 
 	return ERR_PTR(-EPROBE_DEFER);
 }
Signature · 1 line
2.25.1
maintainer
#1 lore raw
Quoted 6 lines · On Tue, 24 May 2022 11:45:17 +0400 Miaoqian Lin <[email protected]> wrote:

of_parse_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak.

Fixes ef04070692a2 ("iio: adc: adi-axi-adc: add support for AXI ADC IP core")

Looks 'obviously correct to me' so applied to the fixes togreg branch of iio.git and marked for stable.

Great if anyone more familiar with this driver than me has a chance to take a quick look though.

Thanks,

Jonathan

Quoted 28 lines
---
 drivers/iio/adc/adi-axi-adc.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/iio/adc/adi-axi-adc.c +3 -0
index a73e3c2d212f..a9e655e69eaa 100644
@@ -322,16 +322,19 @@ static struct adi_axi_adc_client *adi_axi_adc_attach_client(struct device *dev)
 
 		if (!try_module_get(cl->dev->driver->owner)) {
 			mutex_unlock(&registered_clients_lock);
+			of_node_put(cln);
 			return ERR_PTR(-ENODEV);
 		}
 
 		get_device(cl->dev);
 		cl->info = info;
 		mutex_unlock(&registered_clients_lock);
+		of_node_put(cln);
 		return cl;
 	}
 
 	mutex_unlock(&registered_clients_lock);
+	of_node_put(cln);
 
 	return ERR_PTR(-EPROBE_DEFER);
 }