iio: adc: adi-axi-adc: Fix refcount leak in adi_axi_adc_attach_client
Subsystems (2)
PATCH 1/1 iio: adc: adi-axi-adc: Fix refcount leak in adi_axi_adc_attach_client
of_parse_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak.
Fixes ef04070692a2 ("iio: adc: adi-axi-adc: add support for AXI ADC IP core")
Signed-off-by Miaoqian Lin <[email protected]>
--- drivers/iio/adc/adi-axi-adc.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/iio/adc/adi-axi-adc.c +3 -0
@@ -322,16 +322,19 @@ static struct adi_axi_adc_client *adi_axi_adc_attach_client(struct device *dev)if (!try_module_get (cl->dev->driver->owner)) {mutex_unlock (®istered_clients_lock); +of_node_put (cln);return ERR_PTR (-ENODEV ); }get_device (cl->dev); cl->info = info;mutex_unlock (®istered_clients_lock); +of_node_put (cln);return cl; }mutex_unlock (®istered_clients_lock); +of_node_put (cln);return ERR_PTR (-EPROBE_DEFER ); }
Signature · 1 line
2.25.1
Jonathan Cameron
maintainerQuoted 6 lines · On Tue, 24 May 2022 11:45:17 +0400 Miaoqian Lin <[email protected]> wrote:
of_parse_phandle()returns a node pointer with refcount incremented, we should useof_node_put()on it when not need anymore. Add missingof_node_put()to avoid refcount leak.Fixes ef04070692a2 ("iio: adc: adi-axi-adc: add support for AXI ADC IP core")Signed-off-by Miaoqian Lin <[email protected]>
Looks 'obviously correct to me' so applied to the fixes togreg branch of iio.git and marked for stable.
Great if anyone more familiar with this driver than me has a chance to take a quick look though.
Thanks,
Jonathan
Quoted 28 lines
--- drivers/iio/adc/adi-axi-adc.c | 3 +++ 1 file changed, 3 insertions(+)drivers/iio/adc/adi-axi-adc.c +3
-0@@ -322,16 +322,19 @@ static struct adi_axi_adc_client *adi_axi_adc_attach_client(struct device *dev)if (!try_module_get (cl->dev->driver->owner)) {mutex_unlock (®istered_clients_lock); +of_node_put (cln);return ERR_PTR (-ENODEV ); }get_device (cl->dev); cl->info = info;mutex_unlock (®istered_clients_lock); +of_node_put (cln);return cl; }mutex_unlock (®istered_clients_lock); +of_node_put (cln);return ERR_PTR (-EPROBE_DEFER ); }