drm/mcde: Fix refcount leak in mcde_dsi_bind
Subsystems (3)
PATCH 1/1 drm/mcde: Fix refcount leak in mcde_dsi_bind
Every iteration of for_each_available_child_of_node() decrements the reference counter of the previous node. There is no decrement when break out from the loop and results in refcount leak. Add missing of_node_put() to fix this.
Fixes 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE")
Signed-off-by Miaoqian Lin <[email protected]>
--- drivers/gpu/drm/mcde/mcde_dsi.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/mcde/mcde_dsi.c +1 -0
@@ -1111,6 +1111,7 @@ static int mcde_dsi_bind(struct device *dev, struct device *master, bridge =of_drm_find_bridge (child);if (!bridge) {dev_err (dev,"failed to find bridge\n" ); +of_node_put (child);return -EINVAL ; } }
Signature · 1 line
2.25.1
Quoted 7 lines · Miaoqian Lin
Every iteration of
for_each_available_child_of_node()decrements the reference counter of the previous node. There is no decrement when break out from the loop and results in refcount leak. Add missingof_node_put()to fix this.Fixes 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE")Signed-off-by Miaoqian Lin <[email protected]>
Patch applied for next as nonurgent fix.
Yours,
Linus Walleij