Skip to contentSkip to conversation

nvme-rdma: fix typo in comment

PATCH In review Max Gurtovoy 2 participants 3 messages May 25, 2022 – Mar 30, 2023 NVMe

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nvme-rdma: fix typo in comment

There is no ib_stop_cq API and the need for the +1 is for ib_drain_qp.

---
 drivers/nvme/host/rdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/host/rdma.c +1 -1
index d9f19d901313..12c7ea61ed0c 100644
@@ -509,7 +509,7 @@ static int nvme_rdma_create_queue_ib(struct nvme_rdma_queue *queue)
 	}
 	ibdev = queue->device->dev;
 
-	/* +1 for ib_stop_cq */
+	/* +1 for ib_drain_qp */
 	queue->cq_size = cq_factor * queue->queue_size + 1;
 
 	ret = nvme_rdma_create_cq(ibdev, queue);
Signature · 1 line
2.18.1
#1 lore raw

Hi Christoph/Sagi,
I've noticed that the bellow patch wasn't merged.
Can we take it for next cycle please ?

Quoted 21 lines · Max Gurtovoy

There is no ib_stop_cq API and the need for the +1 is for ib_drain_qp.

---
  drivers/nvme/host/rdma.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/host/rdma.c +1 -1
index d9f19d901313..12c7ea61ed0c 100644
@@ -509,7 +509,7 @@ static int nvme_rdma_create_queue_ib(struct nvme_rdma_queue *queue)
  	}
  	ibdev = queue->device->dev;
 
-	/* +1 for ib_stop_cq */
+	/* +1 for ib_drain_qp */
  	queue->cq_size = cq_factor * queue->queue_size + 1;
 
  	ret = nvme_rdma_create_cq(ibdev, queue);