nvmet-rdma: calculate the drain completion once
Subsystems (2)
PATCH 1/1 nvmet-rdma: calculate the drain completion once
Keep this calculation at the local variable (nr_cqe) once instead of adding it separately 3 times in one function.
Reviewed-by Israel Rukshin <[email protected]>
Signed-off-by Max Gurtovoy <[email protected]>
--- drivers/nvme/target/rdma.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)
drivers/nvme/target/rdma.c +5 -6
@@ -1263,16 +1263,15 @@ static int nvmet_rdma_create_queue_ib(struct nvmet_rdma_queue *queue)int nr_cqe, ret, i, factor;/* -* Reserve CQ slots for RECV + RDMA_READ/RDMA_WRITE + RDMA_SEND. +* Reserve CQ slots for RECV + RDMA_READ/RDMA_WRITE + RDMA_SEND + drain. */ - nr_cqe = queue->recv_queue_size +2 * queue->send_queue_size; + nr_cqe = queue->recv_queue_size +2 * queue->send_queue_size +1 ; - queue->cq =ib_cq_pool_get (ndev->device, nr_cqe +1 , + queue->cq =ib_cq_pool_get (ndev->device, nr_cqe, queue->comp_vector,IB_POLL_WORKQUEUE );if (IS_ERR (queue->cq)) { ret =PTR_ERR (queue->cq); -pr_err ("failed to create CQ cqe= %d ret= %d\n" , - nr_cqe +1 , ret); +pr_err ("failed to create CQ cqe= %d ret= %d\n" , nr_cqe, ret); goto out; }
@@ -1329,7 +1328,7 @@ static int nvmet_rdma_create_queue_ib(struct nvmet_rdma_queue *queue) err_destroy_qp:rdma_destroy_qp (queue->cm_id); err_destroy_cq: -ib_cq_pool_put (queue->cq, nr_cqe +1 ); +ib_cq_pool_put (queue->cq, nr_cqe); goto out; }
Signature · 1 line
2.18.1