Skip to contentSkip to conversation

dt-bindings: display: ingenic,jz4780-hdmi: Drop undocumented 'ddc-i2c-bus'

PATCH Applied Rob Herring 3 participants 3 messages May 25, 2022 – May 26, 2022

Subsystems (4)
Device tree bindings DRM drivers DRM misc DRM drivers for bridge chips
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: display: ingenic,jz4780-hdmi: Drop undocumented 'ddc-i2c-bus'

While 'ddc-i2c-bus' is a common property, it should be in a connector node rather than the HDMI bridge node as the I2C bus goes to a connector and not the HDMI block. Drop it from the example.

Signed-off-by Rob Herring <[email protected]>
---
 .../devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml  | 1 -
 1 file changed, 1 deletion(-)
Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml +0 -1
index b8219eab4475..89490fdffeb0 100644
@@ -55,7 +55,6 @@ examples:
         compatible = "ingenic,jz4780-dw-hdmi";
         reg = <0x10180000 0x8000>;
         reg-io-width = <4>;
-        ddc-i2c-bus = <&i2c4>;
         interrupt-parent = <&intc>;
         interrupts = <3>;
         clocks = <&cgu JZ4780_CLK_AHB0>, <&cgu JZ4780_CLK_HDMI>;
Signature · 1 line
2.34.1
reviewer Reviewed-by on v1 1/1
#1 lore raw

Hi Rob,

Thank you for the patch.

Quoted 5 lines · Rob Herring

While 'ddc-i2c-bus' is a common property, it should be in a connector node rather than the HDMI bridge node as the I2C bus goes to a connector and not the HDMI block. Drop it from the example.

Signed-off-by Rob Herring <[email protected]>
Reviewed-by Laurent Pinchart <[email protected]>
Quoted 16 lines
---
 .../devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml  | 1 -
 1 file changed, 1 deletion(-)
Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml +0 -1
index b8219eab4475..89490fdffeb0 100644
@@ -55,7 +55,6 @@ examples:
         compatible = "ingenic,jz4780-dw-hdmi";
         reg = <0x10180000 0x8000>;
         reg-io-width = <4>;
-        ddc-i2c-bus = <&i2c4>;
         interrupt-parent = <&intc>;
         interrupts = <3>;
         clocks = <&cgu JZ4780_CLK_AHB0>, <&cgu JZ4780_CLK_HDMI>;
Signature · 3 lines
Regards,

Laurent Pinchart
Applied
#2 lore raw
Quoted 34 lines · Laurent Pinchart

Hi Rob,

Thank you for the patch.

Quoted 5 lines · Rob Herring

While 'ddc-i2c-bus' is a common property, it should be in a connector node rather than the HDMI bridge node as the I2C bus goes to a connector and not the HDMI block. Drop it from the example.

Signed-off-by Rob Herring <[email protected]>
Reviewed-by Laurent Pinchart <[email protected]>
Quoted 9 lines
---
 .../devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml  | 1 -
 1 file changed, 1 deletion(-)
Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml +0 -0
index b8219eab4475..89490fdffeb0 100644

Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml examples: · line 60

Quoted 7 lines
Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml +0 -1
@@ -55,7 +55,6 @@ examples:
         compatible = "ingenic,jz4780-dw-hdmi";
         reg = <0x10180000 0x8000>;
         reg-io-width = <4>;
-        ddc-i2c-bus = <&i2c4>;
         interrupt-parent = <&intc>;
         interrupts = <3>;
         clocks = <&cgu JZ4780_CLK_AHB0>, <&cgu JZ4780_CLK_HDMI>;

--
Regards,

Quoted 1 line

Laurent Pinchart

Applied to drm-misc-next