Skip to contentSkip to conversation

ASoC: imx-audmux: Silence a clang warning

PATCH In review Fabio Estevam 3 participants 3 messages May 26, 2022 – Jun 7, 2022

Subsystems (4)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 ASoC: imx-audmux: Silence a clang warning

Change the of_device_get_match_data() cast to (uintptr_t) to silence the following clang warning:

sound/soc/fsl/imx-audmux.c:301:16: warning: cast to smaller integer type 'enum imx_audmux_type' from 'const void *' [-Wvoid-pointer-to-enum-cast]

Fixes 6a8b8b582db1 ("ASoC: imx-audmux: Remove unused .id_table")
---
 sound/soc/fsl/imx-audmux.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/fsl/imx-audmux.c +1 -1
index dfa05d40b276..a8e5e0f57faf 100644
@@ -298,7 +298,7 @@ static int imx_audmux_probe(struct platform_device *pdev)
 		audmux_clk = NULL;
 	}
 
-	audmux_type = (enum imx_audmux_type)of_device_get_match_data(&pdev->dev);
+	audmux_type = (uintptr_t)of_device_get_match_data(&pdev->dev);
 
 	switch (audmux_type) {
 	case IMX31_AUDMUX:
Signature · 1 line
2.25.1
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Fabio Estevam

Change the of_device_get_match_data() cast to (uintptr_t) to silence the following clang warning:

sound/soc/fsl/imx-audmux.c:301:16: warning: cast to smaller integer type 'enum imx_audmux_type' from 'const void *' [-Wvoid-pointer-to-enum-cast]

Fixes 6a8b8b582db1 ("ASoC: imx-audmux: Remove unused .id_table")

best regards
wang shengjiu

Quoted 23 lines
---
 sound/soc/fsl/imx-audmux.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/fsl/imx-audmux.c +1 -1
index dfa05d40b276..a8e5e0f57faf 100644
@@ -298,7 +298,7 @@ static int imx_audmux_probe(struct platform_device
 *pdev)
                audmux_clk = NULL;
        }
 
-       audmux_type = (enum
 imx_audmux_type)of_device_get_match_data(&pdev->dev);
+       audmux_type = (uintptr_t)of_device_get_match_data(&pdev->dev);
 
        switch (audmux_type) {
        case IMX31_AUDMUX:

--
2.25.1

maintainer
#2 lore raw
In reply to Fabio Estevam
Quoted 6 lines · Fabio Estevam

Change the of_device_get_match_data() cast to (uintptr_t) to silence the following clang warning:

sound/soc/fsl/imx-audmux.c:301:16: warning: cast to smaller integer type 'enum imx_audmux_type' from 'const void *' [-Wvoid-pointer-to-enum-cast]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: imx-audmux: Silence a clang warning

      commit: 2f4a8171da06609bb6a063630ed546ee3d93dad7

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark