Skip to contentSkip to conversation

dt-bindings: watchdog: faraday: Fix typo in example 'timeout-sec' property

PATCH In review Rob Herring 3 participants 3 messages May 26, 2022 – Jun 3, 2022

Subsystems (2)
Device tree bindings Watchdog device drivers
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: watchdog: faraday: Fix typo in example 'timeout-sec' property

The 'unevaluatedProperties' schema checks is not fully working and doesn't catch some cases where there's a $ref to another schema. A fix is pending, but results in new warnings in examples.

The correct common watchdog property is 'timeout-sec', not 'timeout-secs'.

Signed-off-by Rob Herring <[email protected]>
---
 .../devicetree/bindings/watchdog/faraday,ftwdt010.yaml          | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml +1 -1
index ca9e1beff76b..6ecd429f76b5 100644
@@ -55,7 +55,7 @@ examples:
       compatible = "faraday,ftwdt010";
       reg = <0x41000000 0x1000>;
       interrupts = <3 IRQ_TYPE_LEVEL_HIGH>;
-      timeout-secs = <5>;
+      timeout-sec = <5>;
     };
   - |
     watchdog: watchdog@98500000 {
Signature · 1 line
2.34.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Rob Herring

The 'unevaluatedProperties' schema checks is not fully working and doesn't catch some cases where there's a $ref to another schema. A fix is pending, but results in new warnings in examples.

The correct common watchdog property is 'timeout-sec', not 'timeout-secs'.

Signed-off-by Rob Herring <[email protected]>

Good find.

Reviewed-by Guenter Roeck <[email protected]>
Quoted 17 lines
---
  .../devicetree/bindings/watchdog/faraday,ftwdt010.yaml          | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml +1 -1
index ca9e1beff76b..6ecd429f76b5 100644
@@ -55,7 +55,7 @@ examples:
        compatible = "faraday,ftwdt010";
        reg = <0x41000000 0x1000>;
        interrupts = <3 IRQ_TYPE_LEVEL_HIGH>;
-      timeout-secs = <5>;
+      timeout-sec = <5>;
      };
    - |
      watchdog: watchdog@98500000 {
Reviewed-by on v1 1/1
#2 lore raw
In reply to Rob Herring
Quoted 7 lines · Rob Herring

The 'unevaluatedProperties' schema checks is not fully working and doesn't catch some cases where there's a $ref to another schema. A fix is pending, but results in new warnings in examples.

The correct common watchdog property is 'timeout-sec', not 'timeout-secs'.

Signed-off-by Rob Herring <[email protected]>
Reviewed-by Linus Walleij <[email protected]>

This kind of stuff is exactly what we wanted schema to find and fix. And now it is delivering. Success!

Yours,
Linus Walleij