Skip to contentSkip to conversation

dt-bindings: mmc: Fix unevaluatedProperties warnings in examples

PATCH Applied Rob Herring 2 participants 4 messages May 26, 2022 – Jun 1, 2022

Subsystems (4)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: mmc: Fix unevaluatedProperties warnings in examples

The 'unevaluatedProperties' schema checks is not fully working and doesn't catch some cases where there's a $ref to another schema. A fix is pending, but results in new warnings in examples. Fix the warnings by removing spurious properties or adding a missing property to the schema.

---
 Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml  | 2 --
 Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml | 3 +++
 2 files changed, 3 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml +0 -2
index b672202fff4e..5ecdac9de484 100644
@@ -75,7 +75,6 @@ examples:
       sd-uhs-sdr104;
       sdhci,auto-cmd12;
       interrupts = <0x0 0x26 0x4>;
-      interrupt-names = "sdio0_0";
       clocks = <&scmi_clk 245>;
       clock-names = "sw_sdio";
     };
@@ -94,7 +93,6 @@ examples:
       non-removable;
       bus-width = <0x8>;
       interrupts = <0x0 0x27 0x4>;
-      interrupt-names = "sdio1_0";
       clocks = <&scmi_clk 245>;
       clock-names = "sw_sdio";
     };
Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml +3 -0
index c79639e9027e..aca1a4a8daea 100644
@@ -56,6 +56,9 @@ properties:
       - const: core
       - const: axi
 
+  interrupts:
+    maxItems: 1
+
   marvell,xenon-sdhc-id:
     $ref: /schemas/types.yaml#/definitions/uint32
     minimum: 0
Signature · 1 line
2.34.1
Applied
#1 lore raw
Quoted 7 lines · Rob Herring

The 'unevaluatedProperties' schema checks is not fully working and doesn't catch some cases where there's a $ref to another schema. A fix is pending, but results in new warnings in examples. Fix the warnings by removing spurious properties or adding a missing property to the schema.

Queued for v5.20 on the devel branch, thanks!

Kind regards
Uffe

Quoted 42 lines
---
 Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml  | 2 --
 Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml | 3 +++
 2 files changed, 3 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml +0 -2
index b672202fff4e..5ecdac9de484 100644
@@ -75,7 +75,6 @@ examples:
       sd-uhs-sdr104;
       sdhci,auto-cmd12;
       interrupts = <0x0 0x26 0x4>;
-      interrupt-names = "sdio0_0";
       clocks = <&scmi_clk 245>;
       clock-names = "sw_sdio";
     };
@@ -94,7 +93,6 @@ examples:
       non-removable;
       bus-width = <0x8>;
       interrupts = <0x0 0x27 0x4>;
-      interrupt-names = "sdio1_0";
       clocks = <&scmi_clk 245>;
       clock-names = "sw_sdio";
     };
Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml +3 -1
index c79639e9027e..aca1a4a8daea 100644
@@ -56,6 +56,9 @@ properties:
       - const: core
       - const: axi
 
+  interrupts:
+    maxItems: 1
+
   marvell,xenon-sdhc-id:
     $ref: /schemas/types.yaml#/definitions/uint32
     minimum: 0
--

2.34.1

author maintainer
#2 lore raw
Quoted 10 lines · Ulf Hansson
Quoted 7 lines · Rob Herring

The 'unevaluatedProperties' schema checks is not fully working and doesn't catch some cases where there's a $ref to another schema. A fix is pending, but results in new warnings in examples. Fix the warnings by removing spurious properties or adding a missing property to the schema.

Queued for v5.20 on the devel branch, thanks!

Can you take for 5.19 instead so I can enable this in dtschema sooner rather than later?

Rob

#3 lore raw
Quoted 9 lines · Rob Herring
Quoted 7 lines · Ulf Hansson
Quoted 6 lines · Rob Herring

The 'unevaluatedProperties' schema checks is not fully working and doesn't catch some cases where there's a $ref to another schema. A fix is pending, but results in new warnings in examples. Fix the warnings by removing spurious properties or adding a missing property to the schema.

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

Queued for v5.20 on the devel branch, thanks!

Can you take for 5.19 instead so I can enable this in dtschema sooner rather than later?

Sure! I have moved the patch to the fixes branch now.

Kind regards
Uffe