Skip to contentSkip to conversation

criu: fix QA issue about shebang too long

PATCH In review Chen Qi 2 participants 2 messages May 26, 2022 – Jun 7, 2022

lore
Share & tools
lore

Chen Qi

author
#0 lore raw

PATCH 1/1 criu: fix QA issue about shebang too long

There's a QA issue about criu complaining the shebang of crit script is too long. We should replace it with '#!/usr/bin/env python3'.

---
 recipes-containers/criu/criu_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-containers/criu/criu_git.bb +1 -1
index 4b616ccf..77a12abf 100644
@@ -81,7 +81,7 @@ do_install () {
     # scripts. 'crit' is one of those scripts. The "executable" or "e" option to the
     # setup call should fix it, but it is being ignored. So to avoid getting our native
     # intepreter replaced in the script, we'll do an explicit update ourselves.
-    sed -i 's%^\#\!.*%\#\!/usr/bin/env python3%g' ${D}/usr/bin/crit
+    sed -i 's%^\#\!.*%\#\!/usr/bin/env python3%' ${D}/usr/bin/crit ${D}${libdir}/python3*/site-packages/crit-0.0.1-py3*.egg/EGG-INFO/scripts/crit
 }
 
 FILES:${PN} += "${systemd_unitdir}/ \
Signature · 1 line
2.36.0
#1 lore raw

merged (to master and kirkstone)

Bruce

In message: [meta-virtualization][PATCH] criu: fix QA issue about shebang too long

Quoted 35 lines · on 25/05/2022 Chen Qi wrote:

There's a QA issue about criu complaining the shebang of crit script is too long. We should replace it with '#!/usr/bin/env python3'.

---
 recipes-containers/criu/criu_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-containers/criu/criu_git.bb +1 -1
index 4b616ccf..77a12abf 100644
@@ -81,7 +81,7 @@ do_install () {
     # scripts. 'crit' is one of those scripts. The "executable" or "e" option to the
     # setup call should fix it, but it is being ignored. So to avoid getting our native
     # intepreter replaced in the script, we'll do an explicit update ourselves.
-    sed -i 's%^\#\!.*%\#\!/usr/bin/env python3%g' ${D}/usr/bin/crit
+    sed -i 's%^\#\!.*%\#\!/usr/bin/env python3%' ${D}/usr/bin/crit ${D}${libdir}/python3*/site-packages/crit-0.0.1-py3*.egg/EGG-INFO/scripts/crit
 }
 
 FILES:${PN} += "${systemd_unitdir}/ \
Signature · 11 lines
2.36.0



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#7325): https://lists.yoctoproject.org/g/meta-virtualization/message/7325
Mute This Topic: https://lists.yoctoproject.org/mt/91348088/1050810
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-