bus: arm-cci: Fix refcount leak in cci_probe
PATCH 1/1 bus: arm-cci: Fix refcount leak in cci_probe
of_find_matching_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak.
Signed-off-by Miaoqian Lin <[email protected]>
---
I don't include Fixes tag, because related code logic changes , commit includes ed69bdd8fd9b, 896ddd6..., I am not sure if need to determine one.
--- drivers/bus/arm-cci.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/bus/arm-cci.c +4 -1
@@ -538,8 +538,10 @@ static int cci_probe(void)struct resource res; np =of_find_matching_node (NULL , arm_cci_matches); -if (!of_device_is_available (np)) +if (!of_device_is_available (np)) { +of_node_put (np);return -ENODEV ; + } ret =of_address_to_resource (np,0 , &res);if (!ret) {
@@ -548,6 +550,7 @@ static int cci_probe(void) }if (ret || !cci_ctrl_base) {WARN (1 ,"unable to ioremap CCI ctrl\n" ); +of_node_put (np);return -ENXIO ; }
Signature · 1 line
2.25.1