irqchip/gic/realview: Fix refcount leak in realview_gic_of_init
Subsystems (2)
PATCH 1/1 irqchip/gic/realview: Fix refcount leak in realview_gic_of_init
of_find_matching_node_and_match() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak.
--- drivers/irqchip/irq-gic-realview.c | 1 + 1 file changed, 1 insertion(+)
drivers/irqchip/irq-gic-realview.c +1 -0
@@ -57,6 +57,7 @@ realview_gic_of_init(struct device_node *node, struct device_node *parent)/* The PB11MPCore GIC needs to be configured in the syscon */ map =syscon_node_to_regmap (np); +of_node_put (np);if (!IS_ERR (map)) {/* new irq mode with no DCC */ regmap_write(map, REALVIEW_SYS_LOCK_OFFSET,
Signature · 1 line
2.25.1
Marc Zyngier
maintainerQuoted 7 lines · Miaoqian Lin
of_find_matching_node_and_match()returns a node pointer with refcount incremented, we should useof_node_put()on it when not need anymore. Add missingof_node_put()to avoid refcount leak.Fixes 82b0a434b436 ("irqchip/gic/realview: Support more RealView DCC variants")Signed-off-by Miaoqian Lin <[email protected]>
Instead of sending these one after the other, why don't you send a series addressing the irqchip drivers in one go? That'd be much easier to manage and review.
Thanks,
M.
Signature · 1 line
Without deviation from the norm, progress is not possible.
Quoted 11 lines · Marc Zyngier
Quoted 6 lines · Miaoqian Lin
of_find_matching_node_and_match()returns a node pointer with refcount incremented, we should useof_node_put()on it when not need anymore. Add missingof_node_put()to avoid refcount leak.Fixes 82b0a434b436 ("irqchip/gic/realview: Support more RealView DCC variants")Signed-off-by Miaoqian Lin <[email protected]>Instead of sending these one after the other, why don't you send a series addressing the irqchip drivers in one go? That'd be much easier to manage and review.
Hi, Marc
Thanks for your suggestion, I will do that.
Quoted 4 lines
Thanks,
M.