drm/nouveau/fifo/gv100-: set gv100_fifo_runlist storage-class to static
Subsystems (3)
PATCH 1/1 drm/nouveau/fifo/gv100-: set gv100_fifo_runlist storage-class to static
sparse reportsdrivers/gpu/drm/nouveau/nvkm/engine/fifo/gv100.c:56:1: warning: symbol 'gv100_fifo_runlist' was not declared. Should it be static?
gv100_fifo_runlist is only used in gv100.c, so change it to static.
Signed-off-by Tom Rix <[email protected]>
--- drivers/gpu/drm/nouveau/nvkm/engine/fifo/gv100.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/nouveau/nvkm/engine/fifo/gv100.c +1 -1
@@ -52,7 +52,7 @@ gv100_fifo_runlist_cgrp(struct nvkm_fifo_cgrp *cgrp,nvkm_wo32 (memory, offset +0xc ,0x00000000 ); } -const struct gk104_fifo_runlist_func +static const struct gk104_fifo_runlist_func gv100_fifo_runlist = { .size =16 , .cgrp = gv100_fifo_runlist_cgrp,
Signature · 1 line
2.27.0
Reviewed-by Lyude Paul <[email protected]>
Will push to the appropriate branch in a moment
Quoted 25 lines · Tom Rix
sparse reports
drivers/gpu/drm/nouveau/nvkm/engine/fifo/gv100.c:56:1: warning: symbol 'gv100_fifo_runlist' was not declared. Should it be static?
gv100_fifo_runlistis only used ingv100.c, so change it to static.Signed-off-by Tom Rix <[email protected]>---
drivers/gpu/drm/nouveau/nvkm/engine/fifo/gv100.c | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/nouveau/nvkm/engine/fifo/gv100.c +0
-0@@ -52,7 +52,7 @@ gv100_fifo_runlist_cgrp(struct nvkm_fifo_cgrp *cgrp, nvkm_wo32(memory, offset + 0xc, 0x00000000); }drivers/gpu/drm/nouveau/nvkm/engine/fifo/gv100.c +1
-1-const struct gk104_fifo_runlist_func +static const struct gk104_fifo_runlist_funcgv100_fifo_runlist = {
.size = 16,
.cgrp =gv100_fifo_runlist_cgrp,
Signature · 3 lines
Cheers, Lyude Paul (she/her) Software Engineer at Red Hat