USB: serial: option: Add Telit LE910Cx 0x1250 composition
Subsystems (2)
PATCH v3 1/1 USB: serial: option: Add Telit LE910Cx 0x1250 composition
Add support for the following Telit LE910Cx composition:
0x1250: rmnet, tty, tty, tty, tty
---
v3: - fix subject prefix and modem name (s/LN910Cx/LE910Cx)
- more descriptive e-mail content
v2: use RSVD in place of NCTRL for interface 0 (rmnet)
drivers/usb/serial/option.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/usb/serial/option.c +2 -0
@@ -1275,6 +1275,8 @@ static const struct usb_device_id option_ids[] = { .driver_info = NCTRL(0) | RSVD(1) | RSVD(2) }, { USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x1231, 0xff), /* Telit LE910Cx (RNDIS) */ .driver_info = NCTRL(2) | RSVD(3) }, + { USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x1250, 0xff), /* Telit LE910Cx (rmnet) */ + .driver_info = RSVD(0) }, { USB_DEVICE(TELIT_VENDOR_ID, 0x1260), .driver_info = NCTRL(0) | RSVD(1) | RSVD(2) }, { USB_DEVICE(TELIT_VENDOR_ID, 0x1261),
Signature · 1 line
2.25.1
Il giorno mar 31 mag 2022 alle ore 12:23 Carlo Lobrano <[email protected]> ha scritto:
Quoted 6 lines
Add support for the following Telit LE910Cx composition:
0x1250: rmnet, tty, tty, tty, ttySigned-off-by Carlo Lobrano <[email protected]>
Thanks,
Daniele
Quoted 24 lines
---
v3: - fix subject prefix and modem name (s/LN910Cx/LE910Cx)
- more descriptive e-mail content
v2: use RSVD in place of NCTRL for interface 0 (rmnet)drivers/usb/serial/option.c | 2 ++ 1 file changed, 2 insertions(+)drivers/usb/serial/option.c +2
-1@@ -1275,6 +1275,8 @@ static const struct usb_device_id option_ids[] = { .driver_info = NCTRL(0) | RSVD(1) | RSVD(2) }, { USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x1231, 0xff), /* Telit LE910Cx (RNDIS) */ .driver_info = NCTRL(2) | RSVD(3) }, + { USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x1250, 0xff), /* Telit LE910Cx (rmnet) */ + .driver_info = RSVD(0) }, { USB_DEVICE(TELIT_VENDOR_ID, 0x1260), .driver_info = NCTRL(0) | RSVD(1) | RSVD(2) }, { USB_DEVICE(TELIT_VENDOR_ID, 0x1261), --2.25.1
Johan Hovold
maintainerQuoted 9 lines · Carlo Lobrano
Add support for the following Telit LE910Cx composition:
0x1250: rmnet, tty, tty, tty, ttySigned-off-by Carlo Lobrano <[email protected]>---
v3: - fix subject prefix and modem name (s/LN910Cx/LE910Cx)
- more descriptive e-mail content
v2: use RSVD in place of NCTRL for interface 0 (rmnet)
Thanks for the update (and thanks for reviewing, Daniele).
You forgot to include the lsusb output in v2 and v3 but I found it here:
https://lore.kernel.org/r/[email protected]
drivers/usb/serial/option.c static const struct usb_device_id option_ids[] = { · line 1279
Quoted 13 lines
drivers/usb/serial/option.c | 2 ++ 1 file changed, 2 insertions(+)drivers/usb/serial/option.c +2
-0@@ -1275,6 +1275,8 @@ static const struct usb_device_id option_ids[] = { .driver_info = NCTRL(0) | RSVD(1) | RSVD(2) }, { USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x1231, 0xff), /* Telit LE910Cx (RNDIS) */ .driver_info = NCTRL(2) | RSVD(3) }, + { USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x1250, 0xff), /* Telit LE910Cx (rmnet) */ + .driver_info = RSVD(0) },
Looks you can match on the interface SubClass and Protocol using USB_DEVICE_INFO() and avoid using RSVD() here which is preferred when possible.
drivers/usb/serial/option.c static const struct usb_device_id option_ids[] = { · line 1282
Quoted 3 lines
drivers/usb/serial/option.c +0
-0{ USB_DEVICE(TELIT_VENDOR_ID, 0x1260), .driver_info = NCTRL(0) | RSVD(1) | RSVD(2) }, { USB_DEVICE(TELIT_VENDOR_ID, 0x1261),
Care to respin a v4? You can keep Daniele's reviewed-by tag when resending (i.e. include it before your SoB).
Johan
Hi Johan,
Quoted 21 lines · Johan Hovold
Quoted 9 lines · Carlo Lobrano
Add support for the following Telit LE910Cx composition:
0x1250: rmnet, tty, tty, tty, ttySigned-off-by Carlo Lobrano <[email protected]>---
v3: - fix subject prefix and modem name (s/LN910Cx/LE910Cx)
- more descriptive e-mail content
v2: use RSVD in place of NCTRL for interface 0 (rmnet)Thanks for the update (and thanks for reviewing, Daniele).
You forgot to include the lsusb output in v2 and v3 but I found it here:
https://lore.kernel.org/r/[email protected]Quoted 3 lines
drivers/usb/serial/option.c | 2 ++ 1 file changed, 2 insertions(+)
Quoted 14 lines
drivers/usb/serial/option.c static const struct usb_device_id option_ids[] = { · line 1279
Quoted 10 lines
drivers/usb/serial/option.c +2
-0@@ -1275,6 +1275,8 @@ static const struct usb_device_id option_ids[] = { .driver_info = NCTRL(0) | RSVD(1) | RSVD(2) }, { USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x1231, 0xff), /* Telit LE910Cx (RNDIS) */ .driver_info = NCTRL(2) | RSVD(3) }, + { USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x1250, 0xff), /* Telit LE910Cx (rmnet) */ + .driver_info = RSVD(0) },Looks you can match on the interface SubClass and Protocol using
USB_DEVICE_INFO()and avoid usingRSVD()here which is preferred when possible.
This is a good point, I just need to double check if this was true also with older firmwares I think
Quoted 9 lines
drivers/usb/serial/option.c static const struct usb_device_id option_ids[] = { · line 1282
Quoted 4 lines
drivers/usb/serial/option.c +0
-0{ USB_DEVICE(TELIT_VENDOR_ID, 0x1260), .driver_info = NCTRL(0) | RSVD(1) | RSVD(2) }, { USB_DEVICE(TELIT_VENDOR_ID, 0x1261),Care to respin a v4? You can keep Daniele's reviewed-by tag when resending (i.e. include it before your SoB).
Johan
Carlo