Skip to contentSkip to conversation

ice: Fix memory corruption in VF driver

PATCH Superseded Mateusz Palczewski 3 participants 3 messages May 31, 2022 – Jun 2, 2022

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover ice: Fix memory corruption in VF driver

Disable VF queues, when VF requests reset. Add error handling for VIRTCHNL_OP_CONFIG_VSI_QUEUES handler. Without this patch VF driver could experience memory corruption, which lead to crash:

BUG: unable to handle kernel paging request at 00001b9780003237

Przemyslaw Patynowski (2):
ice: Add error handling for queue config fail
ice: Fix memory corruption in VF driver

 drivers/net/ethernet/intel/ice/ice_vf_lib.c   |  5 ++
 drivers/net/ethernet/intel/ice/ice_virtchnl.c | 53 +++++++++----------
 2 files changed, 31 insertions(+), 27 deletions(-)
Signature · 1 line
2.27.0
#1 lore raw

cover ice: Fix memory corruption in VF driver

Dear Mateusz,

Am 31.05.22 um 15:18 schrieb Mateusz Palczewski:

Quoted 5 lines

Disable VF queues, when VF requests reset. Add error handling for VIRTCHNL_OP_CONFIG_VSI_QUEUES handler. Without this patch VF driver could experience memory corruption, which lead to crash:

BUG: unable to handle kernel paging request at 00001b9780003237
Quoted 7 lines

Przemyslaw Patynowski (2):
ice: Add error handling for queue config fail
ice: Fix memory corruption in VF driver

  drivers/net/ethernet/intel/ice/ice_vf_lib.c   |  5 ++
  drivers/net/ethernet/intel/ice/ice_virtchnl.c | 53 +++++++++----------
  2 files changed, 31 insertions(+), 27 deletions(-)

Thank you for the patches. Although you seem to have used git-send-email, the patches messages are not threaded below the cover letter. Do you have an idea why?

Kind regards,

Paul

#2 lore raw
In reply to Mateusz Palczewski
Quoted 5 lines · Mateusz Palczewski

Disable VF queues, when VF requests reset. Add error handling for VIRTCHNL_OP_CONFIG_VSI_QUEUES handler. Without this patch VF driver could experience memory corruption, which lead to crash:

BUG: unable to handle kernel paging request at 00001b9780003237
Quoted 8 lines

Przemyslaw Patynowski (2):
ice: Add error handling for queue config fail
ice: Fix memory corruption in VF driver

 drivers/net/ethernet/intel/ice/ice_vf_lib.c   |  5 ++
 drivers/net/ethernet/intel/ice/ice_virtchnl.c | 53 +++++++++----------
 2 files changed, 31 insertions(+), 27 deletions(-)

The bug that this is fixing is a long-standing bug reported by Red Hat QE. It's been giving us (RH and Intel) many headaches. Red Hat QE tested a previous version of the patchset (with only a minor difference - it did not have the check for a NULL vsi in patch 2) and confirmed it fixed the bug. Michal

_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan