Skip to contentSkip to conversation

libavtp: add recipe to be able to use aaf config for alsa-plugins

PATCH In review Marcel Ziswiler 3 participants 5 messages May 31, 2022 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 libavtp: add recipe to be able to use aaf config for alsa-plugins

From: Peter Bergin <[email protected]>

In order to enable configuration option aaf (AVTP Audio Format) used for AVB the library libavtp is a dependency but no recipe for this library was present. aaf support for alsa-plugins was introduced in ddf5421331180bc45697511b44cdd4a4e6dda6ff.

---
Resurrect from mailing list [1] as this is still not upstream. End-to-end tested on Verdin iMX8M Plus.
Will talk about it at the Embedded World in the TSN & Linux track next month [2].

[1] https://lore.kernel.org/all/[email protected]/
[2] https://events.weka-fachmedien.de/embedded-world-conference/program/

Changes in v2:
- Updated SRC_URI specifying mandatory protocol as https.
- Updated SRCREV to latest.

 meta/recipes-multimedia/libavtp/libavtp_git.bb | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 meta/recipes-multimedia/libavtp/libavtp_git.bb
meta/recipes-multimedia/libavtp/libavtp_git.bb new file +16 -0
new file mode 100644
index 0000000000..aefbee56ea
@@ -0,0 +1,16 @@
+DESCRIPTION = "Open source implementation of Audio Video Transport Protocol (AVTP) \
+               specified in IEEE 1722-2016 spec."
+HOMEPAGE = "https://github.com/Avnu/libavtp"
+LICENSE = "BSD-3-Clause"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=7fcb4331e23e45e171cd5693c1ff7d3e"
+
+PROVIDES = "avtp"
+
+SRC_URI = "git://github.com/Avnu/libavtp.git;branch=master;protocol=https"
+SRCREV = "3599a5bf2d18fc3ae89b64f208d8380e6ee3a866"
+
+S = "${WORKDIR}/git"
+
+inherit meson pkgconfig
+
+EXTRA_OEMESON = "-Dtests=disabled"
Signature · 1 line
2.36.1
#1 lore raw
Quoted 17 lines · Marcel Ziswiler

From: Peter Bergin <[email protected]>

In order to enable configuration option aaf (AVTP Audio Format) used for AVB the library libavtp is a dependency but no recipe for this library was present. aaf support for alsa-plugins was introduced in ddf5421331180bc45697511b44cdd4a4e6dda6ff.

---
Resurrect from mailing list [1] as this is still not upstream. End-to-end tested on Verdin iMX8M Plus.
Will talk about it at the Embedded World in the TSN & Linux track next month [2].

Quoted 8 lines

[1] https://lore.kernel.org/all/[email protected]/
[2] https://events.weka-fachmedien.de/embedded-world-conference/program/

Changes in v2:
- Updated SRC_URI specifying mandatory protocol as https.
- Updated SRCREV to latest.

 meta/recipes-multimedia/libavtp/libavtp_git.bb | 16 ++++++++++++++++

There was a 0.2.0 release https://github.com/Avnu/libavtp/releases/tag/v0.2.0
so I wonder if we should use the release tagged SRC_URI and call the PV = 0.2.0

Quoted 9 lines
 1 file changed, 16 insertions(+)
 create mode 100644 meta/recipes-multimedia/libavtp/libavtp_git.bb
meta/recipes-multimedia/libavtp/libavtp_git.bb new file +0 -0
new file mode 100644
index 0000000000..aefbee56ea

meta/recipes-multimedia/libavtp/libavtp_git.bb line 7

Quoted 7 lines
meta/recipes-multimedia/libavtp/libavtp_git.bb new file +7 -0
@@ -0,0 +1,16 @@
+DESCRIPTION = "Open source implementation of Audio Video Transport Protocol (AVTP) \
+               specified in IEEE 1722-2016 spec."
+HOMEPAGE = "https://github.com/Avnu/libavtp"
+LICENSE = "BSD-3-Clause"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=7fcb4331e23e45e171cd5693c1ff7d3e"
+
+PROVIDES = "avtp"

why is this provides needed ?

Quoted 21 lines
meta/recipes-multimedia/libavtp/libavtp_git.bb new file +9 -1
+
+SRC_URI = "git://github.com/Avnu/libavtp.git;branch=master;protocol=https"
+SRCREV = "3599a5bf2d18fc3ae89b64f208d8380e6ee3a866"
+
+S = "${WORKDIR}/git"
+
+inherit meson pkgconfig
+
+EXTRA_OEMESON = "-Dtests=disabled"
--

2.36.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#166321): https://lists.openembedded.org/g/openembedded-core/message/166321
Mute This Topic: https://lists.openembedded.org/mt/91454504/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#2 lore raw

Hi,

thanks Marcel for bumping this patch again!

Quoted 20 lines · Khem Raj
Quoted 19 lines · Marcel Ziswiler

From: Peter Bergin <[email protected]>

In order to enable configuration option aaf (AVTP Audio Format) used for AVB the library libavtp is a dependency but no recipe for this library was present. aaf support for alsa-plugins was introduced in ddf5421331180bc45697511b44cdd4a4e6dda6ff.

---
Resurrect from mailing list [1] as this is still not upstream. End-to-end tested on Verdin iMX8M Plus.
Will talk about it at the Embedded World in the TSN & Linux track next month [2].

[1] https://lore.kernel.org/all/[email protected]/
[2] https://events.weka-fachmedien.de/embedded-world-conference/program/

Quoted 7 lines
Quoted 5 lines

Changes in v2:
- Updated SRC_URI specifying mandatory protocol as https.
- Updated SRCREV to latest.

  meta/recipes-multimedia/libavtp/libavtp_git.bb | 16 ++++++++++++++++

There was a 0.2.0 release https://github.com/Avnu/libavtp/releases/tag/v0.2.0
so I wonder if we should use the release tagged SRC_URI and call the PV = 0.2.0

This tag was set after I sent my initial patch. I think this is a good thing to do.

Quoted 4 lines
Quoted 4 lines
  1 file changed, 16 insertions(+)

create mode 100644 meta/recipes-multimedia/libavtp/libavtp_git.bb

Quoted 14 lines

meta/recipes-multimedia/libavtp/libavtp_git.bb line 7

Quoted 13 lines
meta/recipes-multimedia/libavtp/libavtp_git.bb new file +7 -0
new file mode 100644
index 0000000000..aefbee56ea
@@ -0,0 +1,16 @@
+DESCRIPTION = "Open source implementation of Audio Video Transport Protocol (AVTP) \
+               specified in IEEE 1722-2016 spec."
+HOMEPAGE = "https://github.com/Avnu/libavtp"
+LICENSE = "BSD-3-Clause"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=7fcb4331e23e45e171cd5693c1ff7d3e"
+
+PROVIDES = "avtp"

why is this provides needed ?

It is because recipe meta/recipes-multimedia/alsa/alsa-plugins_1.2.6.bb has this PACKAGECONFIG:

  PACKAGECONFIG[aaf] = "--enable-aaf,--disable-aaf,avtp"

So either this PROVIDES or also change PACKAGECONFIG for alsa-plugins?

/Peter

Quoted 18 lines
Quoted 18 lines
meta/recipes-multimedia/libavtp/libavtp_git.bb new file +9 -1
+
+SRC_URI = "git://github.com/Avnu/libavtp.git;branch=master;protocol=https"
+SRCREV = "3599a5bf2d18fc3ae89b64f208d8380e6ee3a866"
+
+S = "${WORKDIR}/git"
+
+inherit meson pkgconfig
+
+EXTRA_OEMESON = "-Dtests=disabled"
--

2.36.1

#3 lore raw

Maybe call the recipe avtp

Quoted 98 lines · Peter Bergin

Hi,

thanks Marcel for bumping this patch again!

Quoted 1 line · Khem Raj

On Tue, May 31, 2022 at 8:57 AM Marcel Ziswiler <[email protected]>

Quoted 10 lines · wrote:
Quoted 10 lines

From: Peter Bergin <[email protected]>

In order to enable configuration option aaf (AVTP Audio Format) used for AVB the library libavtp is a dependency but no recipe for this library was present. aaf support for alsa-plugins was introduced in ddf5421331180bc45697511b44cdd4a4e6dda6ff.

Quoted 7 lines
Quoted 7 lines

---
Resurrect from mailing list [1] as this is still not upstream. End-to-end tested on Verdin iMX8M Plus.
Will talk about it at the Embedded World in the TSN & Linux track next month [2].

[1]

https://lore.kernel.org/all/[email protected]/

Quoted 1 line
Quoted 1 line

[2]

https://events.weka-fachmedien.de/embedded-world-conference/program/

Quoted 7 lines
Quoted 6 lines

Changes in v2:
- Updated SRC_URI specifying mandatory protocol as https.
- Updated SRCREV to latest.

  meta/recipes-multimedia/libavtp/libavtp_git.bb | 16 ++++++++++++++++

There was a 0.2.0 release

https://github.com/Avnu/libavtp/releases/tag/v0.2.0

Quoted 1 line

so I wonder if we should use the release tagged SRC_URI and call the PV

= 0.2.0
This tag was set after I sent my initial patch. I think this is a good thing to do.

Quoted 5 lines

Review

Quoted 5 lines
  1 file changed, 16 insertions(+)

create mode 100644 meta/recipes-multimedia/libavtp/libavtp_git.bb

(quoted diff) +0 -0

b/meta/recipes-multimedia/libavtp/libavtp_git.bb

Quoted 6 lines

meta/recipes-multimedia/libavtp/libavtp_git.bb line 1

Quoted 6 lines

new file mode 100644
index 0000000000..aefbee56ea

meta/recipes-multimedia/libavtp/libavtp_git.bb new file +1 -0
@@ -0,0 +1,16 @@
+DESCRIPTION = "Open source implementation of Audio Video Transport

Protocol (AVTP) \

Quoted 4 lines

meta/recipes-multimedia/libavtp/libavtp_git.bb

Quoted 4 lines
meta/recipes-multimedia/libavtp/libavtp_git.bb new file +4 -0
+               specified in IEEE 1722-2016 spec."
+HOMEPAGE = "https://github.com/Avnu/libavtp"
+LICENSE = "BSD-3-Clause"
+LIC_FILES_CHKSUM =

"file://LICENSE;md5=7fcb4331e23e45e171cd5693c1ff7d3e"

Quoted 3 lines

meta/recipes-multimedia/libavtp/libavtp_git.bb line 7

Quoted 2 lines
meta/recipes-multimedia/libavtp/libavtp_git.bb new file +2 -0
+
+PROVIDES = "avtp"

why is this provides needed ?

It is because recipe meta/recipes-multimedia/alsa/alsa-plugins_1.2.6.bb has this PACKAGECONFIG:

PACKAGECONFIG[aaf] = "--enable-aaf,--disable-aaf,avtp"

So either this PROVIDES or also change PACKAGECONFIG for alsa-plugins?

/Peter

Quoted 2 lines

meta/recipes-multimedia/libavtp/libavtp_git.bb line 9

Quoted 2 lines
meta/recipes-multimedia/libavtp/libavtp_git.bb new file +2 -0
+
+SRC_URI = "git://

github.com/Avnu/libavtp.git;branch=master;protocol=https"

Quoted 14 lines
Quoted 14 lines
meta/recipes-multimedia/libavtp/libavtp_git.bb new file +7 -1
+SRCREV = "3599a5bf2d18fc3ae89b64f208d8380e6ee3a866"
+
+S = "${WORKDIR}/git"
+
+inherit meson pkgconfig
+
+EXTRA_OEMESON = "-Dtests=disabled"
--

2.36.1

Quoted 3 lines
Quoted 3 lines

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#166324):

https://lists.openembedded.org/g/openembedded-core/message/166324

Quoted 3 lines
Quoted 3 lines

Mute This Topic: https://lists.openembedded.org/mt/91454504/3617552
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [

[email protected]]

Quoted 2 lines
Quoted 2 lines

-=-=-=-=-=-=-=-=-=-=-=-

A message that is not in the archive (sent off-list or not yet received): [email protected]

#5 lore raw
Quoted 7 lines · Marcel Ziswiler
Quoted 1 line · Khem Raj

Maybe call the recipe avtp

No, here I disagree. As mentioned before the project and everything is really called libavtp everywhere. So I
think the better solution is to consistently use libavtp in openembedded-core everywhere as well.

That’s fine with me I don’t have hard stand on the name changing existing packageconfog can be a change for someone who might be using it already but that’s fine we have warnings in place to address these

Quoted 109 lines
Quoted 4 lines

On Tue, May 31, 2022 at 11:36 AM Peter Bergin <[email protected]>

Quoted 6 lines · wrote:
Quoted 6 lines

Hi,

thanks Marcel for bumping this patch again!

Quoted 1 line · Khem Raj

On Tue, May 31, 2022 at 8:57 AM Marcel Ziswiler <[email protected]>

Quoted 7 lines · wrote:
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

From: Peter Bergin <[email protected]>

In order to enable configuration option aaf (AVTP Audio Format) used for AVB the library libavtp is a dependency but no recipe for this library was present. aaf support for alsa-plugins was introduced in ddf5421331180bc45697511b44cdd4a4e6dda6ff.

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

---
Resurrect from mailing list [1] as this is still not upstream. End-to-end tested on Verdin iMX8M Plus.
Will talk about it at the Embedded World in the TSN & Linux track

next

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

month [2].

[1]

https://lore.kernel.org/all/[email protected]/

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

[2]

https://events.weka-fachmedien.de/embedded-world-conference/program/

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

Changes in v2:
- Updated SRC_URI specifying mandatory protocol as https.
- Updated SRCREV to latest.

   meta/recipes-multimedia/libavtp/libavtp_git.bb | 16

++++++++++++++++

Quoted 1 line
Quoted 1 line
Quoted 1 line

There was a 0.2.0 release

https://github.com/Avnu/libavtp/releases/tag/v0.2.0

Quoted 1 line
Quoted 1 line
Quoted 1 line

so I wonder if we should use the release tagged SRC_URI and call the

PV = 0.2.0

Quoted 5 lines
Quoted 5 lines

This tag was set after I sent my initial patch. I think this is a good thing to do.

Quoted 3 lines
Quoted 3 lines
   1 file changed, 16 insertions(+)

create mode 100644 meta/recipes-multimedia/libavtp/

libavtp_git.bb

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Review

Quoted 2 lines
(quoted diff) +0 -0

b/meta/recipes-

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

meta/recipes-multimedia/libavtp/libavtp_git.bb line 1

Quoted 7 lines

multimedia/libavtp/libavtp_git.bb
new file mode 100644
index 0000000000..aefbee56ea

meta/recipes-multimedia/libavtp/libavtp_git.bb new file +1 -0
@@ -0,0 +1,16 @@
+DESCRIPTION = "Open source implementation of Audio Video

Transport Protocol (AVTP) \

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

meta/recipes-multimedia/libavtp/libavtp_git.bb

Quoted 4 lines
meta/recipes-multimedia/libavtp/libavtp_git.bb new file +4 -0
+               specified in IEEE 1722-2016 spec."
+HOMEPAGE = "https://github.com/Avnu/libavtp"
+LICENSE = "BSD-3-Clause"
+LIC_FILES_CHKSUM =

"file://LICENSE;md5=7fcb4331e23e45e171cd5693c1ff7d3e"

Quoted 5 lines
Quoted 5 lines
Quoted 3 lines

meta/recipes-multimedia/libavtp/libavtp_git.bb line 7

Quoted 2 lines
meta/recipes-multimedia/libavtp/libavtp_git.bb new file +2 -0
+
+PROVIDES = "avtp"

why is this provides needed ?

It is because recipe meta/recipes-multimedia/alsa/

alsa-plugins_1.2.6.bb

Quoted 10 lines
Quoted 10 lines

has this PACKAGECONFIG:

PACKAGECONFIG[aaf] = "--enable-aaf,--disable-aaf,avtp"

So either this PROVIDES or also change PACKAGECONFIG for alsa-plugins?

/Peter

Quoted 2 lines

meta/recipes-multimedia/libavtp/libavtp_git.bb line 9

Quoted 2 lines
meta/recipes-multimedia/libavtp/libavtp_git.bb new file +2 -0
+
+SRC_URI = "git://

github.com/Avnu/libavtp.git;branch=master;protocol=https"

Quoted 14 lines
Quoted 14 lines
Quoted 14 lines
Quoted 14 lines
meta/recipes-multimedia/libavtp/libavtp_git.bb new file +7 -1
+SRCREV = "3599a5bf2d18fc3ae89b64f208d8380e6ee3a866"
+
+S = "${WORKDIR}/git"
+
+inherit meson pkgconfig
+
+EXTRA_OEMESON = "-Dtests=disabled"
--

2.36.1

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#166324):

https://lists.openembedded.org/g/openembedded-core/message/166324

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

Mute This Topic:

https://lists.openembedded.org/mt/91454504/3617552

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Group Owner: [email protected] Unsubscribe:

https://lists.openembedded.org/g/openembedded-core/unsub [ [email protected]]

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

-=-=-=-=-=-=-=-=-=-=-=-