Skip to contentSkip to conversation

mfd: max77620: Fix refcount leak in max77620_initialise_fps

PATCH Applied Miaoqian Lin 3 participants 3 messages Jun 1, 2022 – Jun 15, 2022 Multifunction devices (MFD)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mfd: max77620: Fix refcount leak in max77620_initialise_fps

of_get_child_by_name() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak.

Fixes 327156c59360 ("mfd: max77620: Add core driver for MAX77620/MAX20024")
---
 drivers/mfd/max77620.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/mfd/max77620.c +2 -0
index fec2096474ad..a6661e07035b 100644
@@ -419,9 +419,11 @@ static int max77620_initialise_fps(struct max77620_chip *chip)
 		ret = max77620_config_fps(chip, fps_child);
 		if (ret < 0) {
 			of_node_put(fps_child);
+			of_node_put(fps_np);
 			return ret;
 		}
 	}
+	of_node_put(fps_np);
 
 	config = chip->enable_global_lpm ? MAX77620_ONOFFCNFG2_SLP_LPM_MSK : 0;
 	ret = regmap_update_bits(chip->rmap, MAX77620_REG_ONOFFCNFG2,
Signature · 1 line
2.25.1
Applied
#2 lore raw
In reply to Miaoqian Lin
Quoted 9 lines · Miaoqian Lin

of_get_child_by_name() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak.

Fixes 327156c59360 ("mfd: max77620: Add core driver for MAX77620/MAX20024")
---
 drivers/mfd/max77620.c | 2 ++
 1 file changed, 2 insertions(+)

Applied, thanks.

Signature · 4 lines
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog