Skip to contentSkip to conversation

firmware: stratix10-svc: fix NULL vs IS_ERR() checking

PATCH New Miaoqian Lin 1 participant 1 message Jun 2, 2022 Intel STRATIX10 firmware drivers

v2 of 3 New Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 firmware: stratix10-svc: fix NULL vs IS_ERR() checking

The svc_create_memory_pool function does not return NULL. It returns error pointers.

Fixes 7ca5ce896524 ("firmware: add Intel Stratix10 service layer driver")

---
Changes in v2:
- add Fixes tag.

---
 drivers/firmware/stratix10-svc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/firmware/stratix10-svc.c +2 -2
index 8177a0fae11d..132ea721c9a0 100644
@@ -996,8 +996,8 @@ static int stratix10_svc_drv_probe(struct platform_device *pdev)
 		return ret;
 
 	genpool = svc_create_memory_pool(pdev, sh_memory);
-	if (!genpool)
-		return -ENOMEM;
+	if (IS_ERR(genpool))
+		return PTR_ERR(genpool);
 
 	/* allocate service controller and supporting channel */
 	controller = devm_kzalloc(dev, sizeof(*controller), GFP_KERNEL);
Signature · 1 line
2.25.1