target/ppc: fix unreachable code in fpu_helper.c
PATCH 1/1 target/ppc: fix unreachable code in fpu_helper.c
Commit c29018cc7395 added an env->fpscr OR operation using a ternary that checks if 'error' is not zero:
env->fpscr |= error ? FP_FEX : 0;
However, in the current body of do_fpscr_check_status(), 'error' is granted to be always non-zero at that point. The result is that Coverity is less than pleased:
Control flow issues (DEADCODE)
Execution cannot reach the expression "0ULL" inside this statement:
"env->fpscr |= (error ? 1073...".
Remove the ternary and always make env->fpscr |= FP_FEX.
--- target/ppc/fpu_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
target/ppc/fpu_helper.c +1 -1
@@ -464,7 +464,7 @@ static void do_fpscr_check_status(CPUPPCState *env, uintptr_t raddr) } cs->exception_index =POWERPC_EXCP_PROGRAM ; env->error_code = error |POWERPC_EXCP_FP ; - env->fpscr |= error ?FP_FEX :0 ; + env->fpscr |=FP_FEX ;/* Deferred floating-point exception after target FPSCR update */ if (fp_exceptions_enabled (env)) { raise_exception_err_ra(env, cs->exception_index,
Signature · 1 line
2.36.1
Quoted 13 lines · Daniel Henrique Barboza
Commit
c29018cc7395added anenv->fpscrOR operation using a ternary that checks if 'error' is not zero:env->fpscr |= error ? FP_FEX : 0;However, in the current body of
do_fpscr_check_status(), 'error' is granted to be always non-zero at that point. The result is that Coverity is less than pleased:Control flow issues (DEADCODE)
Execution cannot reach the expression "0ULL" inside this statement:
"env->fpscr|= (error ? 1073...".
Quoted 9 lines
Remove the ternary and always make
env->fpscr|=FP_FEX.Cc Lucas Mateus Castro (alqotel)<[email protected]>Cc Richard Henderson<[email protected]>Fixes Coverity CID 1489442Fixes c29018cc7395 ("target/ppc: Implemented xvf*ger*")Signed-off-by Daniel Henrique Barboza<[email protected]>---
Signature · 5 lines
Lucas Mateus M. Araujo e Castro Instituto de Pesquisas ELDORADO <https://www.eldorado.org.br/?utm_campaign=assinatura_de_e-mail&utm_medium=email&utm_source=RD+Station> Departamento Computação Embarcada Analista de Software Trainee Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>
Daniel Henrique Barboza
AppliedQueued in gitlab.com/danielhb/qemu/tree/ppc-next. Thanks,
Daniel
Quoted 37 lines · Daniel Henrique Barboza
Commit
c29018cc7395added anenv->fpscrOR operation using a ternary that checks if 'error' is not zero:env->fpscr |= error ? FP_FEX : 0;However, in the current body of
do_fpscr_check_status(), 'error' is granted to be always non-zero at that point. The result is that Coverity is less than pleased:Control flow issues (DEADCODE)
Execution cannot reach the expression "0ULL" inside this statement:
"env->fpscr|= (error ? 1073...".Remove the ternary and always make
env->fpscr|=FP_FEX.Cc Lucas Mateus Castro (alqotel) <[email protected]>Cc Richard Henderson <[email protected]>Fixes Coverity CID 1489442Fixes c29018cc7395 ("target/ppc: Implemented xvf*ger*")Signed-off-by Daniel Henrique Barboza <[email protected]>--- target/ppc/fpu_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)target/ppc/fpu_helper.c +1
-1@@ -464,7 +464,7 @@ static void do_fpscr_check_status(CPUPPCState *env, uintptr_t raddr) } cs->exception_index =POWERPC_EXCP_PROGRAM ; env->error_code = error |POWERPC_EXCP_FP ; - env->fpscr |= error ?FP_FEX :0 ; + env->fpscr |=FP_FEX ;/* Deferred floating-point exception after target FPSCR update */ if (fp_exceptions_enabled (env)) { raise_exception_err_ra(env, cs->exception_index,