hwmon: Remove xgene driver
PATCH 1/1 hwmon: Remove xgene driver
Similar to the situation in commit 9049572fb145 ("hwmon: Remove amd_energy driver"), access to power information can be used as the basis for a side- channel attack. Removing unprivileged access to monitoring information would effectively make the driver useless, so simply remove the driver.
---
I've put a cc: stable here, though I see that wasn't done for the removal of the amd_energy driver. I'm assuming that removing a driver wouldn't normally be sent to stable, but should it be if it's being removed for a security issue?
drivers/hwmon/Kconfig | 7 - drivers/hwmon/Makefile | 1 - drivers/hwmon/xgene-hwmon.c | 792 ------------------------------------ 3 files changed, 800 deletions(-) delete mode 100644 drivers/hwmon/xgene-hwmon.c
drivers/hwmon/Kconfig +0 -7
@@ -2280,13 +2280,6 @@ config SENSORS_ULTRA45 This driver provides support for the Ultra45 workstation environmental sensors. -config SENSORS_XGENE - tristate "APM X-Gene SoC hardware monitoring driver" - depends on XGENE_SLIMPRO_MBOX || PCC - help - If you say yes here you get support for the temperature - and power sensors for APM X-Gene SoC. - config SENSORS_INTEL_M10_BMC_HWMON tristate "Intel MAX10 BMC Hardware Monitoring" depends on MFD_INTEL_M10_BMC
drivers/hwmon/Makefile +0 -1
@@ -212,7 +212,6 @@ obj-$(CONFIG_SENSORS_W83L785TS) += w83l785ts.o obj-$(CONFIG_SENSORS_W83L786NG) += w83l786ng.o obj-$(CONFIG_SENSORS_WM831X) += wm831x-hwmon.o obj-$(CONFIG_SENSORS_WM8350) += wm8350-hwmon.o -obj-$(CONFIG_SENSORS_XGENE) += xgene-hwmon.o obj-$(CONFIG_SENSORS_OCC) += occ/ obj-$(CONFIG_SENSORS_PECI) += peci/
drivers/hwmon/xgene-hwmon.c deleted +0 -792
792 lines not on this page · raw message
Signature · 1 line
2.35.1
Quoted 4 lines · D Scott Phillips
Similar to the situation in commit
9049572fb145("hwmon: Removeamd_energydriver"), access to power information can be used as the basis for a side- channel attack. Removing unprivileged access to monitoring information would effectively make the driver useless, so simply remove the driver.
Well not really useless, there's still baby in this bath water. Specifically, there's no reason to remove the temperature monitor capabilities here. Sorry for the noise, I'll come back with something better thought out.