Skip to contentSkip to conversation

3rd set of IIO export namespaces.

PATCH In review Jonathan Cameron 3 participants 9 messages Jun 4, 2022 – Jul 1, 2022

Subsystems (3)
lore
Share & tools
lore

Jonathan Cameron

author maintainer
#0 lore raw

v2 cover 3rd set of IIO export namespaces.

From: Jonathan Cameron <[email protected]>

Changes since v1:
- Rebase (bit of fuzz in patches 1 and 4)

I sent v1 out in Feb and only got review on one patch (which I've since applied - thanks Nuno).

Looking for a quick sanity check of these 4 that remain from anyone who has the time. Whilst this is mechanical stuff, I've made enough dumb mistakes in such patches over the years that I still like to get a second set of eyes on them if at all possible!

Cc Tomasz Duszynski <[email protected]>
Cc Nuno Sá <[email protected]>
Cc Dmitry Baryshkov <[email protected]>
Cc Siddartha Mohanadoss <[email protected]>

Jonathan Cameron (4):
iio: imu: bmi160: Move exported symbols to IIO_BMI160 namespace
iio: pressure: bmp280: Move symbol exports to IIO_BMP280 namespace
iio: chemical: sps30: Move symbol exports into IIO_SPS30 namespace
iio: adc: qcom-vadc: Move symbol exports to IIO_QCOM_VADC namespace

 drivers/iio/adc/qcom-pm8xxx-xoadc.c  |  1 +
 drivers/iio/adc/qcom-spmi-adc5.c     |  1 +
 drivers/iio/adc/qcom-spmi-vadc.c     |  1 +
 drivers/iio/adc/qcom-vadc-common.c   | 16 ++++++++--------
 drivers/iio/chemical/sps30.c         |  2 +-
 drivers/iio/chemical/sps30_i2c.c     |  1 +
 drivers/iio/chemical/sps30_serial.c  |  1 +
 drivers/iio/imu/bmi160/bmi160_core.c |  6 +++---
 drivers/iio/imu/bmi160/bmi160_i2c.c  |  1 +
 drivers/iio/imu/bmi160/bmi160_spi.c  |  1 +
 drivers/iio/pressure/bmp280-core.c   |  2 +-
 drivers/iio/pressure/bmp280-i2c.c    |  1 +
 drivers/iio/pressure/bmp280-regmap.c |  4 ++--
 drivers/iio/pressure/bmp280-spi.c    |  1 +
 14 files changed, 24 insertions(+), 15 deletions(-)
Signature · 1 line
2.36.1
author maintainer
#1 lore raw

PATCH v2 1/4 iio: imu: bmi160: Move exported symbols to IIO_BMI160 namespace

From: Jonathan Cameron <[email protected]>

Avoid unnecessary pollution of the global symbol namespace by moving library functions in to a specific namespace and import that into the drivers that make use of the functions.

For more info: https://lwn.net/Articles/760045/

---
 drivers/iio/imu/bmi160/bmi160_core.c | 6 +++---
 drivers/iio/imu/bmi160/bmi160_i2c.c  | 1 +
 drivers/iio/imu/bmi160/bmi160_spi.c  | 1 +
 3 files changed, 5 insertions(+), 3 deletions(-)
drivers/iio/imu/bmi160/bmi160_core.c +3 -3
index e7aec56ea136..a77f1a8348ff 100644
@@ -143,7 +143,7 @@ const struct regmap_config bmi160_regmap_config = {
 	.reg_bits = 8,
 	.val_bits = 8,
 };
-EXPORT_SYMBOL(bmi160_regmap_config);
+EXPORT_SYMBOL_NS(bmi160_regmap_config, IIO_BMI160);
 
 struct bmi160_regs {
 	u8 data; /* LSB byte register for X-axis */
@@ -633,7 +633,7 @@ int bmi160_enable_irq(struct regmap *regmap, bool enable)
 				     BMI160_DRDY_INT_EN, enable_bit,
 				     BMI160_NORMAL_WRITE_USLEEP);
 }
-EXPORT_SYMBOL(bmi160_enable_irq);
+EXPORT_SYMBOL_NS(bmi160_enable_irq, IIO_BMI160);
 
 static int bmi160_get_irq(struct fwnode_handle *fwnode, enum bmi160_int_pin *pin)
 {
@@ -884,7 +884,7 @@ int bmi160_core_probe(struct device *dev, struct regmap *regmap,
 
 	return devm_iio_device_register(dev, indio_dev);
 }
-EXPORT_SYMBOL_GPL(bmi160_core_probe);
+EXPORT_SYMBOL_NS_GPL(bmi160_core_probe, IIO_BMI160);
 
 MODULE_AUTHOR("Daniel Baluta <[email protected]>");
 MODULE_DESCRIPTION("Bosch BMI160 driver");
drivers/iio/imu/bmi160/bmi160_i2c.c +1 -0
index 02f149d37b17..d93f4fa2ad55 100644
@@ -68,3 +68,4 @@ module_i2c_driver(bmi160_i2c_driver);
 MODULE_AUTHOR("Daniel Baluta <[email protected]>");
 MODULE_DESCRIPTION("BMI160 I2C driver");
 MODULE_LICENSE("GPL v2");
+MODULE_IMPORT_NS(IIO_BMI160);
drivers/iio/imu/bmi160/bmi160_spi.c +1 -0
index 24f7d75c7903..8b573ea99af2 100644
@@ -65,3 +65,4 @@ module_spi_driver(bmi160_spi_driver);
 MODULE_AUTHOR("Daniel Baluta <[email protected]");
 MODULE_DESCRIPTION("Bosch BMI160 SPI driver");
 MODULE_LICENSE("GPL v2");
+MODULE_IMPORT_NS(IIO_BMI160);
Signature · 1 line
2.36.1
author maintainer
#2 lore raw

PATCH v2 2/4 iio: pressure: bmp280: Move symbol exports to IIO_BMP280 namespace

In reply to Jonathan Cameron

From: Jonathan Cameron <[email protected]>

Avoid unnecessary pollution of the global symbol namespace by moving library functions in to a specific namespace and import that into the drivers that make use of the functions.

For more info: https://lwn.net/Articles/760045/

---
 drivers/iio/pressure/bmp280-core.c   | 2 +-
 drivers/iio/pressure/bmp280-i2c.c    | 1 +
 drivers/iio/pressure/bmp280-regmap.c | 4 ++--
 drivers/iio/pressure/bmp280-spi.c    | 1 +
 4 files changed, 5 insertions(+), 3 deletions(-)
drivers/iio/pressure/bmp280-core.c +1 -1
index bf8167f43c56..fe7aa81e7cc9 100644
@@ -1136,7 +1136,7 @@ int bmp280_common_probe(struct device *dev,
 
 	return devm_iio_device_register(dev, indio_dev);
 }
-EXPORT_SYMBOL(bmp280_common_probe);
+EXPORT_SYMBOL_NS(bmp280_common_probe, IIO_BMP280);
 
 static int bmp280_runtime_suspend(struct device *dev)
 {
drivers/iio/pressure/bmp280-i2c.c +1 -0
index 35045bd92846..bf4a7a617537 100644
@@ -68,3 +68,4 @@ module_i2c_driver(bmp280_i2c_driver);
 MODULE_AUTHOR("Vlad Dogaru <[email protected]>");
 MODULE_DESCRIPTION("Driver for Bosch Sensortec BMP180/BMP280 pressure and temperature sensor");
 MODULE_LICENSE("GPL v2");
+MODULE_IMPORT_NS(IIO_BMP280);
drivers/iio/pressure/bmp280-regmap.c +2 -2
index da136dbadc8f..969698518984 100644
@@ -39,7 +39,7 @@ const struct regmap_config bmp180_regmap_config = {
 	.writeable_reg = bmp180_is_writeable_reg,
 	.volatile_reg = bmp180_is_volatile_reg,
 };
-EXPORT_SYMBOL(bmp180_regmap_config);
+EXPORT_SYMBOL_NS(bmp180_regmap_config, IIO_BMP280);
 
 static bool bmp280_is_writeable_reg(struct device *dev, unsigned int reg)
 {
@@ -82,4 +82,4 @@ const struct regmap_config bmp280_regmap_config = {
 	.writeable_reg = bmp280_is_writeable_reg,
 	.volatile_reg = bmp280_is_volatile_reg,
 };
-EXPORT_SYMBOL(bmp280_regmap_config);
+EXPORT_SYMBOL_NS(bmp280_regmap_config, IIO_BMP280);
drivers/iio/pressure/bmp280-spi.c +1 -0
index 41f6cc56d229..4cfaf3e869b8 100644
@@ -118,3 +118,4 @@ module_spi_driver(bmp280_spi_driver);
 
 MODULE_DESCRIPTION("BMP280 SPI bus driver");
 MODULE_LICENSE("GPL");
+MODULE_IMPORT_NS(IIO_BMP280);
Signature · 1 line
2.36.1
author maintainer
#3 lore raw

PATCH v2 3/4 iio: chemical: sps30: Move symbol exports into IIO_SPS30 namespace

In reply to Jonathan Cameron

From: Jonathan Cameron <[email protected]>

Avoid unnecessary pollution of the global symbol namespace by moving library functions in to a specific namespace and import that into the drivers that make use of the functions.

For more info: https://lwn.net/Articles/760045/

---
 drivers/iio/chemical/sps30.c        | 2 +-
 drivers/iio/chemical/sps30_i2c.c    | 1 +
 drivers/iio/chemical/sps30_serial.c | 1 +
 3 files changed, 3 insertions(+), 1 deletion(-)
drivers/iio/chemical/sps30.c +1 -1
index abd67559e451..814ce0aad1cc 100644
@@ -372,7 +372,7 @@ int sps30_probe(struct device *dev, const char *name, void *priv, const struct s
 
 	return devm_iio_device_register(dev, indio_dev);
 }
-EXPORT_SYMBOL_GPL(sps30_probe);
+EXPORT_SYMBOL_NS_GPL(sps30_probe, IIO_SPS30);
 
 MODULE_AUTHOR("Tomasz Duszynski <[email protected]>");
 MODULE_DESCRIPTION("Sensirion SPS30 particulate matter sensor driver");
drivers/iio/chemical/sps30_i2c.c +1 -0
index d33560ed7184..2aed483a2fde 100644
@@ -256,3 +256,4 @@ module_i2c_driver(sps30_i2c_driver);
 MODULE_AUTHOR("Tomasz Duszynski <[email protected]>");
 MODULE_DESCRIPTION("Sensirion SPS30 particulate matter sensor i2c driver");
 MODULE_LICENSE("GPL v2");
+MODULE_IMPORT_NS(IIO_SPS30);
drivers/iio/chemical/sps30_serial.c +1 -0
index 3f311d50087c..164f4b3e025c 100644
@@ -429,3 +429,4 @@ module_serdev_device_driver(sps30_serial_driver);
 MODULE_AUTHOR("Tomasz Duszynski <[email protected]>");
 MODULE_DESCRIPTION("Sensirion SPS30 particulate matter sensor serial driver");
 MODULE_LICENSE("GPL v2");
+MODULE_IMPORT_NS(IIO_SPS30);
Signature · 1 line
2.36.1
author maintainer
#4 lore raw

PATCH v2 4/4 iio: adc: qcom-vadc: Move symbol exports to IIO_QCOM_VADC namespace

In reply to Jonathan Cameron

From: Jonathan Cameron <[email protected]>

Avoid unnecessary pollution of the global symbol namespace by moving library functions in to a specific namespace and import that into the drivers that make use of the functions.

For more info: https://lwn.net/Articles/760045/

---
 drivers/iio/adc/qcom-pm8xxx-xoadc.c |  1 +
 drivers/iio/adc/qcom-spmi-adc5.c    |  1 +
 drivers/iio/adc/qcom-spmi-vadc.c    |  1 +
 drivers/iio/adc/qcom-vadc-common.c  | 16 ++++++++--------
 4 files changed, 11 insertions(+), 8 deletions(-)
drivers/iio/adc/qcom-pm8xxx-xoadc.c +1 -0
index 5e9e56821075..e2ef89dcaa5e 100644
@@ -1028,3 +1028,4 @@ module_platform_driver(pm8xxx_xoadc_driver);
 MODULE_DESCRIPTION("PM8xxx XOADC driver");
 MODULE_LICENSE("GPL v2");
 MODULE_ALIAS("platform:pm8xxx-xoadc");
+MODULE_IMPORT_NS(IIO_QCOM_VADC);
drivers/iio/adc/qcom-spmi-adc5.c +1 -0
index 87438d1e5c0b..10bb51b648c1 100644
@@ -925,3 +925,4 @@ module_platform_driver(adc5_driver);
 MODULE_ALIAS("platform:qcom-spmi-adc5");
 MODULE_DESCRIPTION("Qualcomm Technologies Inc. PMIC5 ADC driver");
 MODULE_LICENSE("GPL v2");
+MODULE_IMPORT_NS(IIO_QCOM_VADC);
drivers/iio/adc/qcom-spmi-vadc.c +1 -0
index 34202ba52469..cb0c6af091ac 100644
@@ -935,3 +935,4 @@ MODULE_DESCRIPTION("Qualcomm SPMI PMIC voltage ADC driver");
 MODULE_LICENSE("GPL v2");
 MODULE_AUTHOR("Stanimir Varbanov <[email protected]>");
 MODULE_AUTHOR("Ivan T. Ivanov <[email protected]>");
+MODULE_IMPORT_NS(IIO_QCOM_VADC);
drivers/iio/adc/qcom-vadc-common.c +8 -8
index d5209f32adb3..7ca191ea1a65 100644
@@ -662,7 +662,7 @@ int qcom_vadc_scale(enum vadc_scale_fn_type scaletype,
 		return -EINVAL;
 	}
 }
-EXPORT_SYMBOL(qcom_vadc_scale);
+EXPORT_SYMBOL_NS(qcom_vadc_scale, IIO_QCOM_VADC);
 
 u16 qcom_adc_tm5_temp_volt_scale(unsigned int prescale_ratio,
 				 u32 full_scale_code_volt, int temp)
@@ -675,7 +675,7 @@ u16 qcom_adc_tm5_temp_volt_scale(unsigned int prescale_ratio,
 					     temp);
 	return qcom_vadc_scale_voltage_code(voltage, prescale, full_scale_code_volt, 1000);
 }
-EXPORT_SYMBOL(qcom_adc_tm5_temp_volt_scale);
+EXPORT_SYMBOL_NS(qcom_adc_tm5_temp_volt_scale, IIO_QCOM_VADC);
 
 u16 qcom_adc_tm5_gen2_temp_res_scale(int temp)
 {
@@ -704,7 +704,7 @@ int qcom_adc5_hw_scale(enum vadc_scale_fn_type scaletype,
 	return scale_adc5_fn[scaletype].scale_fn(prescale, data,
 					adc_code, result);
 }
-EXPORT_SYMBOL(qcom_adc5_hw_scale);
+EXPORT_SYMBOL_NS(qcom_adc5_hw_scale, IIO_QCOM_VADC);
 
 int qcom_adc5_prescaling_from_dt(u32 numerator, u32 denominator)
 {
@@ -720,7 +720,7 @@ int qcom_adc5_prescaling_from_dt(u32 numerator, u32 denominator)
 
 	return pre;
 }
-EXPORT_SYMBOL(qcom_adc5_prescaling_from_dt);
+EXPORT_SYMBOL_NS(qcom_adc5_prescaling_from_dt, IIO_QCOM_VADC);
 
 int qcom_adc5_hw_settle_time_from_dt(u32 value,
 				     const unsigned int *hw_settle)
@@ -734,7 +734,7 @@ int qcom_adc5_hw_settle_time_from_dt(u32 value,
 
 	return -EINVAL;
 }
-EXPORT_SYMBOL(qcom_adc5_hw_settle_time_from_dt);
+EXPORT_SYMBOL_NS(qcom_adc5_hw_settle_time_from_dt, IIO_QCOM_VADC);
 
 int qcom_adc5_avg_samples_from_dt(u32 value)
 {
@@ -743,7 +743,7 @@ int qcom_adc5_avg_samples_from_dt(u32 value)
 
 	return __ffs(value);
 }
-EXPORT_SYMBOL(qcom_adc5_avg_samples_from_dt);
+EXPORT_SYMBOL_NS(qcom_adc5_avg_samples_from_dt, IIO_QCOM_VADC);
 
 int qcom_adc5_decimation_from_dt(u32 value, const unsigned int *decimation)
 {
@@ -756,7 +756,7 @@ int qcom_adc5_decimation_from_dt(u32 value, const unsigned int *decimation)
 
 	return -EINVAL;
 }
-EXPORT_SYMBOL(qcom_adc5_decimation_from_dt);
+EXPORT_SYMBOL_NS(qcom_adc5_decimation_from_dt, IIO_QCOM_VADC);
 
 int qcom_vadc_decimation_from_dt(u32 value)
 {
@@ -766,7 +766,7 @@ int qcom_vadc_decimation_from_dt(u32 value)
 
 	return __ffs64(value / VADC_DECIMATION_MIN);
 }
-EXPORT_SYMBOL(qcom_vadc_decimation_from_dt);
+EXPORT_SYMBOL_NS(qcom_vadc_decimation_from_dt, IIO_QCOM_VADC);
 
 MODULE_LICENSE("GPL v2");
 MODULE_DESCRIPTION("Qualcomm ADC common functionality");
Signature · 1 line
2.36.1
author maintainer
#6 lore raw
In reply to Jonathan Cameron
Quoted 4 lines · On Sat, 4 Jun 2022 16:53:02 +0100 Jonathan Cameron <[email protected]> wrote:

From: Jonathan Cameron <[email protected]>

Changes since v1:
- Rebase (bit of fuzz in patches 1 and 4)

If anyone has time to take a quick look through this lot and sanity check I haven't done anything stupid it would be much appreciated.

Disadvantage of being the maintainer is there isn't anyone else you can moan about when no one reviews your patches. Of course I never moan about other maintainers and I'm sure no one ever moans about me :)

Quoted 36 lines

I sent v1 out in Feb and only got review on one patch (which I've since applied - thanks Nuno).

Looking for a quick sanity check of these 4 that remain from anyone who has the time. Whilst this is mechanical stuff, I've made enough dumb mistakes in such patches over the years that I still like to get a second set of eyes on them if at all possible!

Cc Tomasz Duszynski <[email protected]>
Cc Nuno Sá <[email protected]>
Cc Dmitry Baryshkov <[email protected]>
Cc Siddartha Mohanadoss <[email protected]>

Jonathan Cameron (4):
iio: imu: bmi160: Move exported symbols to IIO_BMI160 namespace
iio: pressure: bmp280: Move symbol exports to IIO_BMP280 namespace
iio: chemical: sps30: Move symbol exports into IIO_SPS30 namespace
iio: adc: qcom-vadc: Move symbol exports to IIO_QCOM_VADC namespace

 drivers/iio/adc/qcom-pm8xxx-xoadc.c  |  1 +
 drivers/iio/adc/qcom-spmi-adc5.c     |  1 +
 drivers/iio/adc/qcom-spmi-vadc.c     |  1 +
 drivers/iio/adc/qcom-vadc-common.c   | 16 ++++++++--------
 drivers/iio/chemical/sps30.c         |  2 +-
 drivers/iio/chemical/sps30_i2c.c     |  1 +
 drivers/iio/chemical/sps30_serial.c  |  1 +
 drivers/iio/imu/bmi160/bmi160_core.c |  6 +++---
 drivers/iio/imu/bmi160/bmi160_i2c.c  |  1 +
 drivers/iio/imu/bmi160/bmi160_spi.c  |  1 +
 drivers/iio/pressure/bmp280-core.c   |  2 +-
 drivers/iio/pressure/bmp280-i2c.c    |  1 +
 drivers/iio/pressure/bmp280-regmap.c |  4 ++--
 drivers/iio/pressure/bmp280-spi.c    |  1 +
 14 files changed, 24 insertions(+), 15 deletions(-)
#7 lore raw
Quoted 10 lines · Jonathan Cameron
Quoted 4 lines · On Sat, 4 Jun 2022 16:53:02 +0100 Jonathan Cameron <[email protected]> wrote:

From: Jonathan Cameron <[email protected]>

Changes since v1:
- Rebase (bit of fuzz in patches 1 and 4)

If anyone has time to take a quick look through this lot and sanity check I haven't done anything stupid it would be much appreciated.

FWIW, 1 through 4 look good to me.

Joe

Quoted 43 lines

Disadvantage of being the maintainer is there isn't anyone else you can moan about when no one reviews your patches. Of course I never moan about other maintainers and I'm sure no one ever moans about me :)

Quoted 36 lines

I sent v1 out in Feb and only got review on one patch (which I've since applied - thanks Nuno).

Looking for a quick sanity check of these 4 that remain from anyone who has the time. Whilst this is mechanical stuff, I've made enough dumb mistakes in such patches over the years that I still like to get a second set of eyes on them if at all possible!

Cc Tomasz Duszynski <[email protected]>
Cc Nuno Sá <[email protected]>
Cc Dmitry Baryshkov <[email protected]>
Cc Siddartha Mohanadoss <[email protected]>

Jonathan Cameron (4):
iio: imu: bmi160: Move exported symbols to IIO_BMI160 namespace
iio: pressure: bmp280: Move symbol exports to IIO_BMP280 namespace
iio: chemical: sps30: Move symbol exports into IIO_SPS30 namespace
iio: adc: qcom-vadc: Move symbol exports to IIO_QCOM_VADC namespace

 drivers/iio/adc/qcom-pm8xxx-xoadc.c  |  1 +
 drivers/iio/adc/qcom-spmi-adc5.c     |  1 +
 drivers/iio/adc/qcom-spmi-vadc.c     |  1 +
 drivers/iio/adc/qcom-vadc-common.c   | 16 ++++++++--------
 drivers/iio/chemical/sps30.c         |  2 +-
 drivers/iio/chemical/sps30_i2c.c     |  1 +
 drivers/iio/chemical/sps30_serial.c  |  1 +
 drivers/iio/imu/bmi160/bmi160_core.c |  6 +++---
 drivers/iio/imu/bmi160/bmi160_i2c.c  |  1 +
 drivers/iio/imu/bmi160/bmi160_spi.c  |  1 +
 drivers/iio/pressure/bmp280-core.c   |  2 +-
 drivers/iio/pressure/bmp280-i2c.c    |  1 +
 drivers/iio/pressure/bmp280-regmap.c |  4 ++--
 drivers/iio/pressure/bmp280-spi.c    |  1 +
 14 files changed, 24 insertions(+), 15 deletions(-)
author maintainer
#8 lore raw
Quoted 9 lines · On Mon, 20 Jun 2022 23:37:22 -0400 Joe Simmons-Talbott <[email protected]>…
Quoted 8 lines · Jonathan Cameron
Quoted 4 lines · On Sat, 4 Jun 2022 16:53:02 +0100 Jonathan Cameron <[email protected]> wrote:

From: Jonathan Cameron <[email protected]>

Changes since v1:
- Rebase (bit of fuzz in patches 1 and 4)

Quoted 7 lines
Quoted 2 lines

If anyone has time to take a quick look through this lot and sanity check I haven't done anything stupid it would be much appreciated.

FWIW, 1 through 4 look good to me.

Thanks!

Applied to the togreg branch of iio.git and pushed out as testing to see if 0-day finds anything we missed.

Thanks,

Jonathan

Quoted 44 lines

Joe

Quoted 43 lines

Disadvantage of being the maintainer is there isn't anyone else you can moan about when no one reviews your patches. Of course I never moan about other maintainers and I'm sure no one ever moans about me :)

Quoted 36 lines

I sent v1 out in Feb and only got review on one patch (which I've since applied - thanks Nuno).

Looking for a quick sanity check of these 4 that remain from anyone who has the time. Whilst this is mechanical stuff, I've made enough dumb mistakes in such patches over the years that I still like to get a second set of eyes on them if at all possible!

Cc Tomasz Duszynski <[email protected]>
Cc Nuno Sá <[email protected]>
Cc Dmitry Baryshkov <[email protected]>
Cc Siddartha Mohanadoss <[email protected]>

Jonathan Cameron (4):
iio: imu: bmi160: Move exported symbols to IIO_BMI160 namespace
iio: pressure: bmp280: Move symbol exports to IIO_BMP280 namespace
iio: chemical: sps30: Move symbol exports into IIO_SPS30 namespace
iio: adc: qcom-vadc: Move symbol exports to IIO_QCOM_VADC namespace

 drivers/iio/adc/qcom-pm8xxx-xoadc.c  |  1 +
 drivers/iio/adc/qcom-spmi-adc5.c     |  1 +
 drivers/iio/adc/qcom-spmi-vadc.c     |  1 +
 drivers/iio/adc/qcom-vadc-common.c   | 16 ++++++++--------
 drivers/iio/chemical/sps30.c         |  2 +-
 drivers/iio/chemical/sps30_i2c.c     |  1 +
 drivers/iio/chemical/sps30_serial.c  |  1 +
 drivers/iio/imu/bmi160/bmi160_core.c |  6 +++---
 drivers/iio/imu/bmi160/bmi160_i2c.c  |  1 +
 drivers/iio/imu/bmi160/bmi160_spi.c  |  1 +
 drivers/iio/pressure/bmp280-core.c   |  2 +-
 drivers/iio/pressure/bmp280-i2c.c    |  1 +
 drivers/iio/pressure/bmp280-regmap.c |  4 ++--
 drivers/iio/pressure/bmp280-spi.c    |  1 +
 14 files changed, 24 insertions(+), 15 deletions(-)
#5 lore raw

Re: [PATCH v2 4/4] iio: adc: qcom-vadc: Move symbol exports to IIO_QCOM_VADC namespace

In reply to Jonathan Cameron
Quoted 6 lines · On Sat, 4 Jun 2022 16:53:06 +0100 Jonathan Cameron <[email protected]> wrote:

From: Jonathan Cameron <[email protected]>

Avoid unnecessary pollution of the global symbol namespace by moving library functions in to a specific namespace and import that into the drivers that make use of the functions.

Quoted 6 lines

For more info: https://lwn.net/Articles/760045/

Dropped for now after a build issue found in linux next as there are a few calls into this made from a thermal driver.

I'll send out a new version at somepoint.

Thanks,

Jonathan

Quoted 110 lines
---
 drivers/iio/adc/qcom-pm8xxx-xoadc.c |  1 +
 drivers/iio/adc/qcom-spmi-adc5.c    |  1 +
 drivers/iio/adc/qcom-spmi-vadc.c    |  1 +
 drivers/iio/adc/qcom-vadc-common.c  | 16 ++++++++--------
 4 files changed, 11 insertions(+), 8 deletions(-)
drivers/iio/adc/qcom-pm8xxx-xoadc.c +1 -0
index 5e9e56821075..e2ef89dcaa5e 100644
@@ -1028,3 +1028,4 @@ module_platform_driver(pm8xxx_xoadc_driver);
 MODULE_DESCRIPTION("PM8xxx XOADC driver");
 MODULE_LICENSE("GPL v2");
 MODULE_ALIAS("platform:pm8xxx-xoadc");
+MODULE_IMPORT_NS(IIO_QCOM_VADC);
drivers/iio/adc/qcom-spmi-adc5.c +1 -0
index 87438d1e5c0b..10bb51b648c1 100644
@@ -925,3 +925,4 @@ module_platform_driver(adc5_driver);
 MODULE_ALIAS("platform:qcom-spmi-adc5");
 MODULE_DESCRIPTION("Qualcomm Technologies Inc. PMIC5 ADC driver");
 MODULE_LICENSE("GPL v2");
+MODULE_IMPORT_NS(IIO_QCOM_VADC);
drivers/iio/adc/qcom-spmi-vadc.c +1 -0
index 34202ba52469..cb0c6af091ac 100644
@@ -935,3 +935,4 @@ MODULE_DESCRIPTION("Qualcomm SPMI PMIC voltage ADC driver");
 MODULE_LICENSE("GPL v2");
 MODULE_AUTHOR("Stanimir Varbanov <[email protected]>");
 MODULE_AUTHOR("Ivan T. Ivanov <[email protected]>");
+MODULE_IMPORT_NS(IIO_QCOM_VADC);
drivers/iio/adc/qcom-vadc-common.c +8 -8
index d5209f32adb3..7ca191ea1a65 100644
@@ -662,7 +662,7 @@ int qcom_vadc_scale(enum vadc_scale_fn_type scaletype,
 		return -EINVAL;
 	}
 }
-EXPORT_SYMBOL(qcom_vadc_scale);
+EXPORT_SYMBOL_NS(qcom_vadc_scale, IIO_QCOM_VADC);
 
 u16 qcom_adc_tm5_temp_volt_scale(unsigned int prescale_ratio,
 				 u32 full_scale_code_volt, int temp)
@@ -675,7 +675,7 @@ u16 qcom_adc_tm5_temp_volt_scale(unsigned int prescale_ratio,
 					     temp);
 	return qcom_vadc_scale_voltage_code(voltage, prescale, full_scale_code_volt, 1000);
 }
-EXPORT_SYMBOL(qcom_adc_tm5_temp_volt_scale);
+EXPORT_SYMBOL_NS(qcom_adc_tm5_temp_volt_scale, IIO_QCOM_VADC);
 
 u16 qcom_adc_tm5_gen2_temp_res_scale(int temp)
 {
@@ -704,7 +704,7 @@ int qcom_adc5_hw_scale(enum vadc_scale_fn_type scaletype,
 	return scale_adc5_fn[scaletype].scale_fn(prescale, data,
 					adc_code, result);
 }
-EXPORT_SYMBOL(qcom_adc5_hw_scale);
+EXPORT_SYMBOL_NS(qcom_adc5_hw_scale, IIO_QCOM_VADC);
 
 int qcom_adc5_prescaling_from_dt(u32 numerator, u32 denominator)
 {
@@ -720,7 +720,7 @@ int qcom_adc5_prescaling_from_dt(u32 numerator, u32 denominator)
 
 	return pre;
 }
-EXPORT_SYMBOL(qcom_adc5_prescaling_from_dt);
+EXPORT_SYMBOL_NS(qcom_adc5_prescaling_from_dt, IIO_QCOM_VADC);
 
 int qcom_adc5_hw_settle_time_from_dt(u32 value,
 				     const unsigned int *hw_settle)
@@ -734,7 +734,7 @@ int qcom_adc5_hw_settle_time_from_dt(u32 value,
 
 	return -EINVAL;
 }
-EXPORT_SYMBOL(qcom_adc5_hw_settle_time_from_dt);
+EXPORT_SYMBOL_NS(qcom_adc5_hw_settle_time_from_dt, IIO_QCOM_VADC);
 
 int qcom_adc5_avg_samples_from_dt(u32 value)
 {
@@ -743,7 +743,7 @@ int qcom_adc5_avg_samples_from_dt(u32 value)
 
 	return __ffs(value);
 }
-EXPORT_SYMBOL(qcom_adc5_avg_samples_from_dt);
+EXPORT_SYMBOL_NS(qcom_adc5_avg_samples_from_dt, IIO_QCOM_VADC);
 
 int qcom_adc5_decimation_from_dt(u32 value, const unsigned int *decimation)
 {
@@ -756,7 +756,7 @@ int qcom_adc5_decimation_from_dt(u32 value, const unsigned int *decimation)
 
 	return -EINVAL;
 }
-EXPORT_SYMBOL(qcom_adc5_decimation_from_dt);
+EXPORT_SYMBOL_NS(qcom_adc5_decimation_from_dt, IIO_QCOM_VADC);
 
 int qcom_vadc_decimation_from_dt(u32 value)
 {
@@ -766,7 +766,7 @@ int qcom_vadc_decimation_from_dt(u32 value)
 
 	return __ffs64(value / VADC_DECIMATION_MIN);
 }
-EXPORT_SYMBOL(qcom_vadc_decimation_from_dt);
+EXPORT_SYMBOL_NS(qcom_vadc_decimation_from_dt, IIO_QCOM_VADC);
 
 MODULE_LICENSE("GPL v2");
 MODULE_DESCRIPTION("Qualcomm ADC common functionality");