Skip to contentSkip to conversation

mtd: parsers: ofpart: Fix refcount leak in bcm4908_partitions_fw_offset

PATCH Applied Miaoqian Lin 2 participants 2 messages Jun 5, 2022 – Jun 9, 2022 Memory technology devices (MTD)

lore
Share & tools
lore

Miaoqian Lin

author
#0 lore raw

PATCH 1/1 mtd: parsers: ofpart: Fix refcount leak in bcm4908_partitions_fw_offset

of_find_node_by_path() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.

Fixes bb17230c61a6 ("mtd: parsers: ofpart: support BCM4908 fixed partitions")
Signed-off-by Miaoqian Lin <[email protected]>
---
 drivers/mtd/parsers/ofpart_bcm4908.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/mtd/parsers/ofpart_bcm4908.c +3 -0
index 0eddef4c198e..bb072a0940e4 100644
@@ -35,12 +35,15 @@ static long long bcm4908_partitions_fw_offset(void)
 		err = kstrtoul(s + len + 1, 0, &offset);
 		if (err) {
 			pr_err("failed to parse %s\n", s + len + 1);
+			of_node_put(root);
 			return err;
 		}
 
+		of_node_put(root);
 		return offset << 10;
 	}
 
+	of_node_put(root);
 	return -ENOENT;
 }
Signature · 1 line
2.25.1