remoteproc: k3-r5: Fix refcount leak in k3_r5_cluster_of_init
PATCH 1/1 remoteproc: k3-r5: Fix refcount leak in k3_r5_cluster_of_init
Every iteration of for_each_available_child_of_node() decrements the reference count of the previous node.
When breaking early from a for_each_available_child_of_node() loop, we need to explicitly call of_node_put() on the child node. Add missing of_node_put() to avoid refcount leak.
--- drivers/remoteproc/ti_k3_r5_remoteproc.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/remoteproc/ti_k3_r5_remoteproc.c +2 -0
@@ -1655,6 +1655,7 @@ static int k3_r5_cluster_of_init(struct platform_device *pdev)if (!cpdev) { ret = -ENODEV ;dev_err (dev,"could not get R5 core platform device\n" ); +of_node_put (child); goto fail; }
@@ -1663,6 +1664,7 @@ static int k3_r5_cluster_of_init(struct platform_device *pdev)dev_err (dev,"k3_r5_core_of_init failed, ret = %d\n" , ret);put_device (&cpdev->dev); +of_node_put (child); goto fail; }
Signature · 1 line
2.25.1
Hi Miaoqian,
Quoted 5 lines · Miaoqian Lin
Every iteration of
for_each_available_child_of_node()decrements the reference count of the previous node.
When breaking early from afor_each_available_child_of_node()loop, we need to explicitly callof_node_put()on the child node. Add missingof_node_put()to avoid refcount leak.
Thanks for catching this.
Quoted 3 lines
Fixes 6dedbd1d5443 ("remoteproc: k3-r5: Add a remoteproc driver for R5F subsystem")Signed-off-by Miaoqian Lin <[email protected]>
regards
Suman
Quoted 24 lines
--- drivers/remoteproc/ti_k3_r5_remoteproc.c | 2 ++ 1 file changed, 2 insertions(+)drivers/remoteproc/ti_k3_r5_remoteproc.c +2
-0@@ -1655,6 +1655,7 @@ static int k3_r5_cluster_of_init(struct platform_device *pdev)if (!cpdev) { ret = -ENODEV ;dev_err (dev,"could not get R5 core platform device\n" ); +of_node_put (child); goto fail; }@@ -1663,6 +1664,7 @@ static int k3_r5_cluster_of_init(struct platform_device *pdev)dev_err (dev,"k3_r5_core_of_init failed, ret = %d\n" , ret);put_device (&cpdev->dev); +of_node_put (child); goto fail; }
Mathieu Poirier
maintainerQuoted 11 lines · Miaoqian Lin
Every iteration of
for_each_available_child_of_node()decrements the reference count of the previous node.
When breaking early from afor_each_available_child_of_node()loop, we need to explicitly callof_node_put()on the child node. Add missingof_node_put()to avoid refcount leak.Fixes 6dedbd1d5443 ("remoteproc: k3-r5: Add a remoteproc driver for R5F subsystem")Signed-off-by Miaoqian Lin <[email protected]>--- drivers/remoteproc/ti_k3_r5_remoteproc.c | 2 ++ 1 file changed, 2 insertions(+)
I have applied this patch.
Thanks,
Mathieu
Quoted 24 lines
drivers/remoteproc/ti_k3_r5_remoteproc.c +2
-0@@ -1655,6 +1655,7 @@ static int k3_r5_cluster_of_init(struct platform_device *pdev)if (!cpdev) { ret = -ENODEV ;dev_err (dev,"could not get R5 core platform device\n" ); +of_node_put (child); goto fail; }@@ -1663,6 +1664,7 @@ static int k3_r5_cluster_of_init(struct platform_device *pdev)dev_err (dev,"k3_r5_core_of_init failed, ret = %d\n" , ret);put_device (&cpdev->dev); +of_node_put (child); goto fail; }Signature · 1 line
2.25.1