hwmon: (occ) Delete unnecessary NULL check
Quoted 7 lines · Ziyang Xuan
kvfree(NULL) is safe. NULL check before
kvfree()is not needed. Delete them to simplify the code.Generated by coccinelle script:
scripts/coccinelle/free/ifnullfree.cocciSigned-off-by Ziyang Xuan <[email protected]>
Applied to hwmon-next.
Thanks,
Guenter
Quoted 31 lines
--- drivers/hwmon/occ/p9_sbe.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)drivers/hwmon/occ/p9_sbe.c +2
-4@@ -55,8 +55,7 @@ static bool p9_sbe_occ_save_ffdc(struct p9_sbe_occ *ctx, const void *resp,mutex_lock (&ctx->sbe_error_lock);if (!ctx->sbe_error) {if (resp_len > ctx->ffdc_size) { -if (ctx->ffdc) -kvfree (ctx->ffdc); +kvfree (ctx->ffdc); ctx->ffdc =kvmalloc (resp_len,GFP_KERNEL );if (!ctx->ffdc) { ctx->ffdc_len =0 ;@@ -171,8 +170,7 @@ static int p9_sbe_occ_remove(struct platform_device *pdev) ctx->sbe =NULL ;occ_shutdown (occ); -if (ctx->ffdc) -kvfree (ctx->ffdc); +kvfree (ctx->ffdc);return 0 ; }Signature · 1 line
2.25.1