hwmon: (occ) Lock mutex in shutdown to prevent race with occ_active
PATCH 1/1 hwmon: (occ) Lock mutex in shutdown to prevent race with occ_active
Unbinding the driver or removing the parent device at the same time as using the OCC active sysfs file can cause the driver to unregister the hwmon device twice. Prevent this by locking the occ mutex in the shutdown function.
Signed-off-by Eddie James <[email protected]>
--- drivers/hwmon/occ/common.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/hwmon/occ/common.c +5 -0
@@ -1228,10 +1228,15 @@ EXPORT_SYMBOL_GPL(occ_setup);void occ_shutdown (struct occ *occ) { +mutex_lock (&occ->lock); +occ_shutdown_sysfs (occ);if (occ->hwmon)hwmon_device_unregister (occ->hwmon); + occ->hwmon =NULL ; + +mutex_unlock (&occ->lock); }EXPORT_SYMBOL_GPL (occ_shutdown);
Signature · 1 line
2.31.1
Quoted 6 lines · Eddie James
Unbinding the driver or removing the parent device at the same time as using the OCC active sysfs file can cause the driver to unregister the hwmon device twice. Prevent this by locking the occ mutex in the shutdown function.
Signed-off-by Eddie James <[email protected]>
Applied.
Thanks,
Guenter
Quoted 24 lines
--- drivers/hwmon/occ/common.c | 5 +++++ 1 file changed, 5 insertions(+)drivers/hwmon/occ/common.c +5
-0@@ -1228,10 +1228,15 @@ EXPORT_SYMBOL_GPL(occ_setup);void occ_shutdown (struct occ *occ) { +mutex_lock (&occ->lock); +occ_shutdown_sysfs (occ);if (occ->hwmon)hwmon_device_unregister (occ->hwmon); + occ->hwmon =NULL ; + +mutex_unlock (&occ->lock); }EXPORT_SYMBOL_GPL (occ_shutdown);