Skip to contentSkip to conversation

ARM: dts: at91: sam9x60ek: fix eeprom compatible and size

PATCH Applied Eugen Hristev 2 participants 6 messages Jun 7, 2022 – Jun 28, 2022

Subsystems (2)
lore
Share & tools
lore
#1 lore raw

PATCH 2/2 ARM: dts: at91: sama5d2_icp: fix eeprom compatibles

In reply to Eugen Hristev

The eeprom memories on the board are microchip 24aa025e48, which are 2 Kbits and are compatible with at24c02 not at24c32.

Fixes 68a95ef72cefe ("ARM: dts: at91: sama5d2-icp: add SAMA5D2-ICP")
---
 arch/arm/boot/dts/at91-sama5d2_icp.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/at91-sama5d2_icp.dts +3 -3
index 806eb1d911d7c..164201a8fbf2d 100644
@@ -329,21 +329,21 @@ &i2c1 {
 	status = "okay";
 
 	eeprom@50 {
-		compatible = "atmel,24c32";
+		compatible = "atmel,24c02";
 		reg = <0x50>;
 		pagesize = <16>;
 		status = "okay";
 	};
 
 	eeprom@52 {
-		compatible = "atmel,24c32";
+		compatible = "atmel,24c02";
 		reg = <0x52>;
 		pagesize = <16>;
 		status = "disabled";
 	};
 
 	eeprom@53 {
-		compatible = "atmel,24c32";
+		compatible = "atmel,24c02";
 		reg = <0x53>;
 		pagesize = <16>;
 		status = "disabled";
Signature · 1 line
2.25.1
#0 lore raw

PATCH 1/2 ARM: dts: at91: sam9x60ek: fix eeprom compatible and size

The board has a microchip 24aa025e48 eeprom, which is a 2 Kbits memory, so it's compatible with at24c02 not at24c32.
Also the size property is wrong, it's not 128 bytes, but 256 bytes. Thus removing and leaving it to the default (256).

Fixes 1e5f532c27371 ("ARM: dts: at91: sam9x60: add device tree for soc and board")
---
 arch/arm/boot/dts/at91-sam9x60ek.dts | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
arch/arm/boot/dts/at91-sam9x60ek.dts +1 -2
index 7719ea3d4933c..81ccb0636a009 100644
@@ -233,10 +233,9 @@ i2c0: i2c@600 {
 		status = "okay";
 
 		eeprom@53 {
-			compatible = "atmel,24c32";
+			compatible = "atmel,24c02";
 			reg = <0x53>;
 			pagesize = <16>;
-			size = <128>;
 			status = "okay";
 		};
 	};
Signature · 1 line
2.25.1
Reviewed-by on v1 1/2
#4 lore raw
Quoted 7 lines · Eugen Hristev

The board has a microchip 24aa025e48 eeprom, which is a 2 Kbits memory, so it's compatible with at24c02 not at24c32.
Also the size property is wrong, it's not 128 bytes, but 256 bytes. Thus removing and leaving it to the default (256).

Fixes 1e5f532c27371 ("ARM: dts: at91: sam9x60: add device tree for soc and board")
Quoted 10 lines
---
 arch/arm/boot/dts/at91-sam9x60ek.dts | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
arch/arm/boot/dts/at91-sam9x60ek.dts +0 -0
index 7719ea3d4933c..81ccb0636a009 100644
@@ -233,10 +233,9 @@ i2c0: i2c@600 {
 		status = "okay";

arch/arm/boot/dts/at91-sam9x60ek.dts i2c0: i2c@600 { · line 241

Quoted 10 lines
arch/arm/boot/dts/at91-sam9x60ek.dts +1 -2
 
 		eeprom@53 {
-			compatible = "atmel,24c32";
+			compatible = "atmel,24c02";
 			reg = <0x53>;
 			pagesize = <16>;
-			size = <128>;
 			status = "okay";
 		};
 	};

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] ARM: dts: at91: sama5d2_icp: fix eeprom compatibles

In reply to Eugen Hristev
Quoted 5 lines · Eugen Hristev

The eeprom memories on the board are microchip 24aa025e48, which are 2 Kbits and are compatible with at24c02 not at24c32.

Fixes 68a95ef72cefe ("ARM: dts: at91: sama5d2-icp: add SAMA5D2-ICP")
Quoted 23 lines
---
 arch/arm/boot/dts/at91-sama5d2_icp.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/at91-sama5d2_icp.dts +2 -2
index 806eb1d911d7c..164201a8fbf2d 100644
@@ -329,21 +329,21 @@ &i2c1 {
 	status = "okay";
 
 	eeprom@50 {
-		compatible = "atmel,24c32";
+		compatible = "atmel,24c02";
 		reg = <0x50>;
 		pagesize = <16>;
 		status = "okay";
 	};
 
 	eeprom@52 {
-		compatible = "atmel,24c32";
+		compatible = "atmel,24c02";
 		reg = <0x52>;

arch/arm/boot/dts/at91-sama5d2_icp.dts &i2c1 { · line 349

Quoted 10 lines
arch/arm/boot/dts/at91-sama5d2_icp.dts +1 -1
 		pagesize = <16>;
 		status = "disabled";
 	};
 
 	eeprom@53 {
-		compatible = "atmel,24c32";
+		compatible = "atmel,24c02";
 		reg = <0x53>;
 		pagesize = <16>;
 		status = "disabled";

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#5 lore raw
In reply to Eugen Hristev
Quoted 7 lines · Eugen Hristev

The board has a microchip 24aa025e48 eeprom, which is a 2 Kbits memory, so it's compatible with at24c02 not at24c32.
Also the size property is wrong, it's not 128 bytes, but 256 bytes. Thus removing and leaving it to the default (256).

Fixes 1e5f532c27371 ("ARM: dts: at91: sam9x60: add device tree for soc and board")

Applied to at91-fixes. Thanks!

Quoted 20 lines
---
 arch/arm/boot/dts/at91-sam9x60ek.dts | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
arch/arm/boot/dts/at91-sam9x60ek.dts +1 -2
index 7719ea3d4933c..81ccb0636a009 100644
@@ -233,10 +233,9 @@ i2c0: i2c@600 {
 		status = "okay";
 
 		eeprom@53 {
-			compatible = "atmel,24c32";
+			compatible = "atmel,24c02";
 			reg = <0x53>;
 			pagesize = <16>;
-			size = <128>;
 			status = "okay";
 		};
 	};
#3 lore raw

Re: [PATCH 2/2] ARM: dts: at91: sama5d2_icp: fix eeprom compatibles

In reply to Eugen Hristev
Quoted 5 lines · Eugen Hristev

The eeprom memories on the board are microchip 24aa025e48, which are 2 Kbits and are compatible with at24c02 not at24c32.

Fixes 68a95ef72cefe ("ARM: dts: at91: sama5d2-icp: add SAMA5D2-ICP")

Applied to at91-fixes. Thanks!

Quoted 33 lines
---
 arch/arm/boot/dts/at91-sama5d2_icp.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/at91-sama5d2_icp.dts +3 -3
index 806eb1d911d7c..164201a8fbf2d 100644
@@ -329,21 +329,21 @@ &i2c1 {
 	status = "okay";
 
 	eeprom@50 {
-		compatible = "atmel,24c32";
+		compatible = "atmel,24c02";
 		reg = <0x50>;
 		pagesize = <16>;
 		status = "okay";
 	};
 
 	eeprom@52 {
-		compatible = "atmel,24c32";
+		compatible = "atmel,24c02";
 		reg = <0x52>;
 		pagesize = <16>;
 		status = "disabled";
 	};
 
 	eeprom@53 {
-		compatible = "atmel,24c32";
+		compatible = "atmel,24c02";
 		reg = <0x53>;
 		pagesize = <16>;
 		status = "disabled";