prime_busy: Replace open-coded spinner with igt_spin_t

PATCH Superseded Ramalingam C 3 participants 4 messages Jun 7, 2022 – Jun 8, 2022

lore

Share & tools

lore

Ramalingam C

author

2022-06-07 14:31 UTC #0 lore raw

PATCH 1/1 prime_busy: Replace open-coded spinner with igt_spin_t

From: Chris Wilson <[email protected]>

Now that we can create arbitrary dependencies with the igt_spin_t dummy load, we can replace the custom spinner in prime_busy.

Signed-off-by Chris Wilson <[email protected]>

Signed-off-by Ramalingam C <[email protected]>

---
 tests/prime_busy.c | 137 +++++++++------------------------------------
 1 file changed, 25 insertions(+), 112 deletions(-)

tests/prime_busy.c +25 ~~-112~~

index 0b657b67a03e..41ef666a6e84 100644
@@ -42,112 +42,37 @@ static bool prime_busy(struct pollfd *pfd, bool excl)
 
 static void busy(int fd, const intel_ctx_t *ctx, unsigned ring, unsigned flags)
 {
-	const int gen = intel_gen(intel_get_drm_devid(fd));
-	const uint32_t _bbe = MI_BATCH_BUFFER_END;
-	struct drm_i915_gem_exec_object2 obj[2];
-	struct pollfd pfd[2];
 #define SCRATCH 0
 #define BATCH 1
-	struct drm_i915_gem_relocation_entry store[1024+1];
-	struct drm_i915_gem_execbuffer2 execbuf;
-	unsigned size = ALIGN(ARRAY_SIZE(store)*16 + 4, 4096);
-	struct timespec tv;
-	uint32_t *batch, *bbe;
-	int i, count, timeout;
+	uint32_t handle = gem_create(fd, 4096);
+	struct pollfd pfd[2] = {};
+	uint64_t ahnd;
+	igt_spin_t *spin;
+	int timeout;
 
 	gem_quiescent_gpu(fd);
 
-	memset(&execbuf, 0, sizeof(execbuf));
-	execbuf.buffers_ptr = to_user_pointer(obj);
-	execbuf.buffer_count = 2;
-	execbuf.flags = ring;
-	if (gen < 6)
-		execbuf.flags |= I915_EXEC_SECURE;
-	execbuf.rsvd1 = ctx->id;
-
-	memset(obj, 0, sizeof(obj));
-	obj[SCRATCH].handle = gem_create(fd, 4096);
-
-	obj[BATCH].handle = gem_create(fd, size);
-	obj[BATCH].offset = 1 << 20;
-	gem_write(fd, obj[BATCH].handle, 0, &_bbe, sizeof(_bbe));
-	igt_require(__gem_execbuf(fd, &execbuf) == 0); /* prebind the buffers */
-
-	obj[BATCH].relocs_ptr = to_user_pointer(store);
-	obj[BATCH].relocation_count = ARRAY_SIZE(store);
-	memset(store, 0, sizeof(store));
+	ahnd = get_reloc_ahnd(fd, ctx->id);
+	spin = igt_spin_new(fd,
+			    .ahnd = ahnd,
+			    .ctx = ctx, .engine = ring,
+			    .dependency = handle,
+			    .flags = (flags & HANG ? IGT_SPIN_NO_PREEMPTION : 0));
+	igt_spin_end(spin);
+	gem_sync(fd, spin->handle);
 
 	if (flags & BEFORE) {
-		memset(pfd, 0, sizeof(pfd));
-		pfd[SCRATCH].fd = prime_handle_to_fd(fd, obj[SCRATCH].handle);
-		pfd[BATCH].fd = prime_handle_to_fd(fd, obj[BATCH].handle);
-	}
-
-	batch = gem_mmap__device_coherent(fd, obj[BATCH].handle, 0, size, PROT_WRITE);
-	gem_set_domain(fd, obj[BATCH].handle,
-			I915_GEM_DOMAIN_GTT, I915_GEM_DOMAIN_GTT);
-
-	i = 0;
-	for (count = 0; count < 1024; count++) {
-		uint64_t offset;
-
-		store[count].target_handle = obj[SCRATCH].handle;
-		store[count].presumed_offset = obj[SCRATCH].offset;
-		store[count].offset = sizeof(uint32_t) * (i + 1);
-		store[count].delta = sizeof(uint32_t) * count;
-		store[count].read_domains = I915_GEM_DOMAIN_RENDER;
-		store[count].write_domain = I915_GEM_DOMAIN_RENDER;
-
-		offset = store[count].presumed_offset + store[count].delta;
-
-		batch[i] = MI_STORE_DWORD_IMM | (gen < 6 ? 1 << 22 : 0);
-		if (gen >= 8) {
-			batch[++i] = offset;
-			batch[++i] = offset >> 32;
-		} else if (gen >= 4) {
-			batch[++i] = 0;
-			batch[++i] = offset;
-			store[count].offset += sizeof(uint32_t);
-		} else {
-			batch[i]--;
-			batch[++i] = offset;
-		}
-		batch[++i] = count;
-		i++;
-	}
+		pfd[SCRATCH].fd = prime_handle_to_fd(fd, spin->obj[SCRATCH].handle);
+		pfd[BATCH].fd = prime_handle_to_fd(fd, spin->obj[BATCH].handle);
 
-	bbe = &batch[i];
-	store[count].target_handle = obj[BATCH].handle; /* recurse */
-	store[count].presumed_offset = obj[BATCH].offset;
-	store[count].offset = sizeof(uint32_t) * (i + 1);
-	store[count].delta = 0;
-	store[count].read_domains = I915_GEM_DOMAIN_COMMAND;
-	store[count].write_domain = 0;
-	batch[i] = MI_BATCH_BUFFER_START;
-	if (gen >= 8) {
-		batch[i] |= 1 << 8 | 1;
-		batch[++i] = obj[BATCH].offset;
-		batch[++i] = obj[BATCH].offset >> 32;
-	} else if (gen >= 6) {
-		batch[i] |= 1 << 8;
-		batch[++i] = obj[BATCH].offset;
-	} else {
-		batch[i] |= 2 << 6;
-		batch[++i] = obj[BATCH].offset;
-		if (gen < 4) {
-			batch[i] |= 1;
-			store[count].delta = 1;
-		}
 	}
-	i++;
 
-	igt_assert(i < size/sizeof(*batch));
-	igt_require(__gem_execbuf(fd, &execbuf) == 0);
+	igt_spin_reset(spin);
+	gem_execbuf(fd, &spin->execbuf);
 
 	if (flags & AFTER) {
-		memset(pfd, 0, sizeof(pfd));
-		pfd[SCRATCH].fd = prime_handle_to_fd(fd, obj[SCRATCH].handle);
-		pfd[BATCH].fd = prime_handle_to_fd(fd, obj[BATCH].handle);
+		pfd[SCRATCH].fd = prime_handle_to_fd(fd, spin->obj[SCRATCH].handle);
+		pfd[BATCH].fd = prime_handle_to_fd(fd, spin->obj[BATCH].handle);
 	}
 
 	igt_assert(prime_busy(&pfd[SCRATCH], false));

@@ -158,8 +83,7 @@ static void busy(int fd, const intel_ctx_t *ctx, unsigned ring, unsigned flags)
 
 	timeout = 120;
 	if ((flags & HANG) == 0) {
-		*bbe = MI_BATCH_BUFFER_END;
-		__sync_synchronize();
+		igt_spin_end(spin);
 		timeout = 1;
 	}

@@ -168,23 +92,18 @@ static void busy(int fd, const intel_ctx_t *ctx, unsigned ring, unsigned flags)
 		pfd[BATCH].events = POLLOUT;
 		igt_assert(poll(pfd, 1, timeout * 1000) == 1);
 	} else {
-		memset(&tv, 0, sizeof(tv));
+		struct timespec tv = {};
 		while (prime_busy(&pfd[BATCH], true))
 			igt_assert(igt_seconds_elapsed(&tv) < timeout);
 	}
 	igt_assert(!prime_busy(&pfd[SCRATCH], true));
 
-	munmap(batch, size);
-	batch = gem_mmap__device_coherent(fd, obj[SCRATCH].handle, 0, 4096, PROT_READ);
-	for (i = 0; i < 1024; i++)
-		igt_assert_eq_u32(batch[i], i);
-	munmap(batch, 4096);
-
-	gem_close(fd, obj[BATCH].handle);
-	gem_close(fd, obj[SCRATCH].handle);
+	igt_spin_free(fd, spin);
+	gem_close(fd, handle);
 
 	close(pfd[BATCH].fd);
 	close(pfd[SCRATCH].fd);
+	intel_allocator_close(ahnd);
 }
 
 static void test_mode(int fd, const intel_ctx_t *ctx, unsigned int flags)

@@ -198,12 +117,6 @@ static void test_mode(int fd, const intel_ctx_t *ctx, unsigned int flags)
 		hang = igt_allow_hang(fd, ctx->id, 0);
 
 	for_each_ctx_engine(fd, ctx, e) {
-		if (!gem_class_can_store_dword(fd, e->class))
-			continue;
-
-		if (!gem_class_has_mutable_submission(fd, e->class))
-			continue;
-
 		igt_dynamic_f("%s", e->name)
 			busy(fd, ctx, e->flags, flags);
 	}

@@ -220,7 +133,7 @@ igt_main
 	int fd = -1;
 
 	igt_fixture {
-		fd = drm_open_driver_master(DRIVER_INTEL);
+		fd = drm_open_driver(DRIVER_INTEL);
 		igt_require_gem(fd);
 		ctx = intel_ctx_create_all_physical(fd);
 	}

Signature · 1 line

2.20.1

Patchwork

2022-06-07 15:20 UTC #1 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for prime_busy: Replace open-coded spinner with igt_spin_t

== Series Details ==

Series: prime_busy: Replace open-coded spinner with igt_spin_t
URL : https://patchwork.freedesktop.org/series/104820/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_11730 -> IGTPW_7247
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/index.html

Participating hosts (42 -> 44)
------------------------------

Additional (5): bat-dg1-6 bat-dg1-5 bat-dg2-8 bat-dg2-9 bat-rpls-2
Missing (3): bat-adln-1 fi-icl-u2 fi-bdw-samus

Known issues
------------

Here are the changes found in IGTPW_7247 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@fbdev@nullptr:
- bat-dg1-5: NOTRUN -> [SKIP][1] ([i915#2582]) +4 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/bat-dg1-5/igt@[email protected]

* igt@gem_mmap@basic:
- bat-dg1-5: NOTRUN -> [SKIP][2] ([i915#4083])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/bat-dg1-5/igt@[email protected]
- bat-dg1-6: NOTRUN -> [SKIP][3] ([i915#4083])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/bat-dg1-6/igt@[email protected]

* igt@gem_render_tiled_blits@basic:
- bat-dg1-6: NOTRUN -> [SKIP][4] ([i915#4079]) +1 similar issue
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/bat-dg1-6/igt@[email protected]

* igt@gem_tiled_blits@basic:
- bat-dg1-5: NOTRUN -> [SKIP][5] ([i915#4077]) +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/bat-dg1-5/igt@[email protected]

* igt@gem_tiled_fence_blits@basic:
- bat-dg1-6: NOTRUN -> [SKIP][6] ([i915#4077]) +2 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/bat-dg1-6/igt@[email protected]

* igt@gem_tiled_pread_basic:
- bat-dg1-5: NOTRUN -> [SKIP][7] ([i915#4079]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/bat-dg1-5/igt@gem_tiled_pread_basic.html

* igt@i915_pm_backlight@basic-brightness:
- bat-dg1-6: NOTRUN -> [SKIP][8] ([i915#1155])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/bat-dg1-6/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][9] ([i915#1155])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/bat-dg1-5/igt@[email protected]

* igt@i915_pm_rpm@basic-rte:
- fi-cfl-8109u: [PASS][10] -> [DMESG-WARN][11] ([i915#1888] / [i915#62])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/fi-cfl-8109u/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/fi-cfl-8109u/igt@[email protected]

* igt@i915_pm_rpm@module-reload:
- fi-cfl-8109u: [PASS][12] -> [DMESG-FAIL][13] ([i915#62])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/fi-cfl-8109u/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/fi-cfl-8109u/igt@[email protected]

* igt@i915_selftest@live@hangcheck:
- bat-dg1-5: NOTRUN -> [DMESG-FAIL][14] ([i915#4494] / [i915#4957])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/bat-dg1-5/igt@i915_selftest@[email protected]
- fi-bdw-5557u: NOTRUN -> [INCOMPLETE][15] ([i915#3921])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/fi-bdw-5557u/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@late_gt_pm:
- fi-cfl-8109u: [PASS][16] -> [DMESG-WARN][17] ([i915#5904]) +11 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/fi-cfl-8109u/igt@i915_selftest@live@late_gt_pm.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/fi-cfl-8109u/igt@i915_selftest@live@late_gt_pm.html

* igt@i915_selftest@live@requests:
- fi-blb-e6850: [PASS][18] -> [DMESG-FAIL][19] ([i915#4528])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/fi-blb-e6850/igt@i915_selftest@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/fi-blb-e6850/igt@i915_selftest@[email protected]

* igt@i915_suspend@basic-s2idle-without-i915:
- fi-cfl-8109u: [PASS][20] -> [DMESG-WARN][21] ([i915#5904] / [i915#62])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/fi-cfl-8109u/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/fi-cfl-8109u/igt@[email protected]
- bat-dg1-6: NOTRUN -> [INCOMPLETE][22] ([i915#6011])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/bat-dg1-6/igt@[email protected]
- bat-dg1-5: NOTRUN -> [INCOMPLETE][23] ([i915#6011])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/bat-dg1-5/igt@[email protected]

* igt@kms_addfb_basic@basic-x-tiled-legacy:
- bat-dg1-5: NOTRUN -> [SKIP][24] ([i915#4212]) +7 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/bat-dg1-5/igt@[email protected]

* igt@kms_addfb_basic@basic-y-tiled-legacy:
- bat-dg1-5: NOTRUN -> [SKIP][25] ([i915#4215])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/bat-dg1-5/igt@[email protected]
- bat-dg1-6: NOTRUN -> [SKIP][26] ([i915#4215])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/bat-dg1-6/igt@[email protected]

* igt@kms_addfb_basic@tile-pitch-mismatch:
- bat-dg1-6: NOTRUN -> [SKIP][27] ([i915#4212]) +7 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/bat-dg1-6/igt@[email protected]

* igt@kms_addfb_basic@too-high:
- fi-cfl-8109u: [PASS][28] -> [DMESG-WARN][29] ([i915#62]) +77 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/fi-cfl-8109u/igt@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/fi-cfl-8109u/igt@[email protected]

* igt@kms_busy@basic:
- bat-dg1-5: NOTRUN -> [SKIP][30] ([i915#1845] / [i915#4303])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/bat-dg1-5/igt@[email protected]

* igt@kms_chamelium@dp-crc-fast:
- bat-dg1-5: NOTRUN -> [SKIP][31] ([fdo#111827]) +7 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/bat-dg1-5/igt@[email protected]

* igt@kms_chamelium@hdmi-crc-fast:
- bat-dg1-6: NOTRUN -> [SKIP][32] ([fdo#111827]) +7 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/bat-dg1-6/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- bat-dg1-6: NOTRUN -> [SKIP][33] ([i915#4103] / [i915#4213]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/bat-dg1-6/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- bat-dg1-5: NOTRUN -> [SKIP][34] ([i915#4103] / [i915#4213]) +1 similar issue
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/bat-dg1-5/igt@[email protected]

* igt@kms_force_connector_basic@force-load-detect:
- bat-dg1-5: NOTRUN -> [SKIP][35] ([fdo#109285])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/bat-dg1-5/igt@[email protected]
- bat-dg1-6: NOTRUN -> [SKIP][36] ([fdo#109285])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/bat-dg1-6/igt@[email protected]

* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a:
- bat-dg1-5: NOTRUN -> [SKIP][37] ([i915#4078]) +21 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/bat-dg1-5/igt@[email protected]

* igt@kms_psr@primary_page_flip:
- bat-dg1-5: NOTRUN -> [SKIP][38] ([i915#1072] / [i915#4078]) +3 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/bat-dg1-5/igt@kms_psr@primary_page_flip.html

* igt@kms_psr@sprite_plane_onoff:
- bat-dg1-6: NOTRUN -> [SKIP][39] ([i915#1072] / [i915#4078]) +3 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/bat-dg1-6/igt@kms_psr@sprite_plane_onoff.html

* igt@kms_setmode@basic-clone-single-crtc:
- bat-dg1-5: NOTRUN -> [SKIP][40] ([i915#3555])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/bat-dg1-5/igt@[email protected]
- bat-dg1-6: NOTRUN -> [SKIP][41] ([i915#3555])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/bat-dg1-6/igt@[email protected]

* igt@prime_vgem@basic-fence-flip:
- bat-dg1-5: NOTRUN -> [SKIP][42] ([i915#1845] / [i915#3708])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/bat-dg1-5/igt@[email protected]

* igt@prime_vgem@basic-fence-read:
- bat-dg1-5: NOTRUN -> [SKIP][43] ([i915#3708]) +2 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/bat-dg1-5/igt@[email protected]

* igt@prime_vgem@basic-gtt:
- bat-dg1-6: NOTRUN -> [SKIP][44] ([i915#3708] / [i915#4077]) +1 similar issue
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/bat-dg1-6/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][45] ([i915#3708] / [i915#4077]) +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/bat-dg1-5/igt@[email protected]

* igt@prime_vgem@basic-userptr:
- bat-dg1-6: NOTRUN -> [SKIP][46] ([i915#3708] / [i915#4873])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/bat-dg1-6/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][47] ([i915#3708] / [i915#4873])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/bat-dg1-5/igt@[email protected]

* igt@prime_vgem@basic-write:
- bat-dg1-6: NOTRUN -> [SKIP][48] ([i915#3708]) +3 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/bat-dg1-6/igt@[email protected]

* igt@runner@aborted:
- bat-dg1-5: NOTRUN -> [FAIL][49] ([i915#4312] / [i915#5257])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/bat-dg1-5/igt@[email protected]
- bat-dg1-6: NOTRUN -> [FAIL][50] ([i915#4312] / [i915#5257])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/bat-dg1-6/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_suspend@basic-s0@smem:
- {fi-ehl-2}: [DMESG-WARN][51] ([i915#5122]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/fi-ehl-2/igt@gem_exec_suspend@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/fi-ehl-2/igt@gem_exec_suspend@[email protected]

* igt@i915_hangman@error-state-basic:
- fi-skl-guc: [DMESG-WARN][53] -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/fi-skl-guc/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/fi-skl-guc/igt@[email protected]

* igt@i915_selftest@live@gem_contexts:
- fi-bdw-5557u: [INCOMPLETE][55] ([i915#5502]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/fi-bdw-5557u/igt@i915_selftest@live@gem_contexts.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/fi-bdw-5557u/igt@i915_selftest@live@gem_contexts.html

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6510 -> IGTPW_7247

CI-20190529: 20190529
CI_DRM_11730: 5e7f37992081d4600d6329a745ab7edb2ee42bcd @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_7247: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/index.html
IGT_6510: dacfa80158d586cd0fe322f25f5275f224a946dd @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/index.html

Patchwork

2022-06-07 18:34 UTC #2 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for prime_busy: Replace open-coded spinner with igt_spin_t

In reply to Ramalingam C

== Series Details ==

Series: prime_busy: Replace open-coded spinner with igt_spin_t
URL : https://patchwork.freedesktop.org/series/104820/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_11730_full -> IGTPW_7247_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/index.html

Participating hosts (10 -> 9)
------------------------------

Additional (2): shard-dg1 shard-tglu
Missing (3): pig-skl-6260u pig-kbl-iris pig-glk-j5005

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_7247_full:

### IGT changes ###

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@kms_3d:
- {shard-dg1}: NOTRUN -> [SKIP][1] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-dg1-17/igt@kms_3d.html

* igt@kms_draw_crc@draw-method-rgb565-render-xtiled:
- {shard-dg1}: NOTRUN -> [FAIL][2] +10 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-dg1-17/igt@[email protected]

* igt@kms_invalid_mode@zero-clock:
- {shard-dg1}: NOTRUN -> [WARN][3] +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-dg1-17/igt@[email protected]

* igt@kms_setmode@clone-exclusive-crtc:
- {shard-dg1}: NOTRUN -> [INCOMPLETE][4]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-dg1-17/igt@[email protected]

Known issues
------------

Here are the changes found in IGTPW_7247_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_ccs@ctrl-surf-copy:
- shard-tglb: NOTRUN -> [SKIP][5] ([i915#3555] / [i915#5325])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-tglb1/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][6] ([i915#5327])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-iclb2/igt@[email protected]

* igt@gem_ctx_persistence@hostile:
- shard-snb: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#1099])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-snb2/igt@[email protected]

* igt@gem_eio@unwedge-stress:
- shard-snb: NOTRUN -> [FAIL][8] ([i915#3354])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-snb4/igt@[email protected]
- shard-tglb: NOTRUN -> [FAIL][9] ([i915#5784])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-tglb1/igt@[email protected]

* igt@gem_exec_balancer@parallel-keep-in-fence:
- shard-iclb: [PASS][10] -> [SKIP][11] ([i915#4525]) +3 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-iclb4/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-iclb8/igt@[email protected]

* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-tglb: [PASS][12] -> [FAIL][13] ([i915#2842]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-tglb6/igt@gem_exec_fair@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-tglb1/igt@gem_exec_fair@[email protected]
- shard-glk: [PASS][14] -> [FAIL][15] ([i915#2842])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-glk5/igt@gem_exec_fair@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-glk7/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: NOTRUN -> [FAIL][16] ([i915#2842])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-tglb3/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@rcs0:
- shard-kbl: [PASS][17] -> [FAIL][18] ([i915#2842]) +3 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-kbl4/igt@gem_exec_fair@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-kbl7/igt@gem_exec_fair@[email protected]

* igt@gem_exec_flush@basic-uc-prw-default:
- shard-snb: [PASS][19] -> [SKIP][20] ([fdo#109271])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-snb4/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-snb6/igt@[email protected]

* igt@gem_exec_params@secure-non-root:
- shard-iclb: NOTRUN -> [SKIP][21] ([fdo#112283])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-iclb6/igt@[email protected]

* igt@gem_exec_schedule@thriceslice:
- shard-snb: NOTRUN -> [SKIP][22] ([fdo#109271]) +36 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-snb4/igt@[email protected]

* igt@gem_exec_suspend@basic-s3@smem:
- shard-apl: [PASS][23] -> [DMESG-WARN][24] ([i915#180]) +2 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-apl8/igt@gem_exec_suspend@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-apl3/igt@gem_exec_suspend@[email protected]

* igt@gem_lmem_swapping@smem-oom:
- shard-kbl: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#4613])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-kbl7/igt@[email protected]

* igt@gem_pxp@verify-pxp-stale-buf-execution:
- shard-iclb: NOTRUN -> [SKIP][26] ([i915#4270])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-iclb4/igt@[email protected]

* igt@gem_render_copy@yf-tiled-to-vebox-y-tiled:
- shard-iclb: NOTRUN -> [SKIP][27] ([i915#768]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-iclb7/igt@[email protected]

* igt@gem_spin_batch@legacy@render:
- shard-apl: [PASS][28] -> [FAIL][29] ([i915#2898])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-apl7/igt@gem_spin_batch@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-apl3/igt@gem_spin_batch@[email protected]

* igt@gen9_exec_parse@bb-chained:
- shard-tglb: NOTRUN -> [SKIP][30] ([i915#2527] / [i915#2856])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-tglb7/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][31] ([i915#2856])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-iclb6/igt@[email protected]

* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][32] -> [FAIL][33] ([i915#454])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-iclb5/igt@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-iclb7/igt@[email protected]

* igt@i915_pm_dc@dc9-dpms:
- shard-apl: [PASS][34] -> [SKIP][35] ([fdo#109271]) +2 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-apl7/igt@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-apl3/igt@[email protected]

* igt@i915_query@query-topology-known-pci-ids:
- shard-tglb: NOTRUN -> [SKIP][36] ([fdo#109303])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-tglb7/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][37] ([fdo#109303])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-iclb1/igt@[email protected]

* igt@i915_suspend@debugfs-reader:
- shard-kbl: [PASS][38] -> [INCOMPLETE][39] ([i915#3614])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-kbl4/igt@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-kbl4/igt@[email protected]

* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
- shard-glk: NOTRUN -> [SKIP][40] ([fdo#109271]) +25 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-glk2/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
- shard-tglb: NOTRUN -> [SKIP][41] ([i915#5286])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-tglb5/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html

* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-iclb: NOTRUN -> [SKIP][42] ([i915#5286]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-iclb7/igt@[email protected]

* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip:
- shard-iclb: NOTRUN -> [SKIP][43] ([fdo#110723])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-iclb6/igt@[email protected]

* igt@kms_ccs@pipe-a-bad-pixel-format-4_tiled_dg2_rc_ccs:
- shard-iclb: NOTRUN -> [SKIP][44] ([fdo#109278]) +10 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-iclb4/igt@kms_ccs@pipe-a-bad-pixel-format-4_tiled_dg2_rc_ccs.html

* igt@kms_ccs@pipe-a-missing-ccs-buffer-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][45] ([fdo#111615] / [i915#3689])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-tglb7/igt@kms_ccs@pipe-a-missing-ccs-buffer-yf_tiled_ccs.html

* igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][46] ([fdo#109271] / [i915#3886]) +5 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-kbl4/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-b-crc-sprite-planes-basic-4_tiled_dg2_rc_ccs_cc:
- shard-tglb: NOTRUN -> [SKIP][47] ([i915#3689]) +2 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-tglb3/igt@kms_ccs@pipe-b-crc-sprite-planes-basic-4_tiled_dg2_rc_ccs_cc.html

* igt@kms_ccs@pipe-d-crc-primary-basic-4_tiled_dg2_rc_ccs:
- shard-tglb: NOTRUN -> [SKIP][48] ([i915#6095])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-tglb2/igt@kms_ccs@pipe-d-crc-primary-basic-4_tiled_dg2_rc_ccs.html

* igt@kms_chamelium@dp-audio:
- shard-iclb: NOTRUN -> [SKIP][49] ([fdo#109284] / [fdo#111827]) +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-iclb1/igt@[email protected]

* igt@kms_chamelium@hdmi-mode-timings:
- shard-kbl: NOTRUN -> [SKIP][50] ([fdo#109271] / [fdo#111827]) +11 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-kbl4/igt@[email protected]

* igt@kms_color_chamelium@pipe-a-ctm-0-25:
- shard-snb: NOTRUN -> [SKIP][51] ([fdo#109271] / [fdo#111827]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-snb7/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][52] ([fdo#109271] / [fdo#111827]) +5 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-apl6/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][53] ([fdo#109284] / [fdo#111827]) +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-tglb5/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][54] ([fdo#109271] / [fdo#111827]) +1 similar issue
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-glk7/igt@[email protected]

* igt@kms_content_protection@atomic:
- shard-apl: NOTRUN -> [TIMEOUT][55] ([i915#1319])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-apl4/igt@[email protected]
- shard-kbl: NOTRUN -> [TIMEOUT][56] ([i915#1319])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-kbl6/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-512x512-sliding:
- shard-tglb: NOTRUN -> [SKIP][57] ([fdo#109279] / [i915#3359])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-tglb3/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][58] ([fdo#109278] / [fdo#109279])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-iclb2/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-32x10-onscreen:
- shard-tglb: NOTRUN -> [SKIP][59] ([i915#3359]) +2 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-tglb7/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-max-size-onscreen:
- shard-kbl: NOTRUN -> [SKIP][60] ([fdo#109271]) +164 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-kbl7/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: NOTRUN -> [DMESG-WARN][61] ([i915#180]) +2 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-kbl4/igt@[email protected]

* igt@kms_cursor_crc@pipe-d-cursor-128x42-rapid-movement:
- shard-apl: NOTRUN -> [SKIP][62] ([fdo#109271]) +57 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-apl6/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- shard-tglb: NOTRUN -> [SKIP][63] ([i915#4103]) +1 similar issue
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-tglb1/igt@[email protected]

* igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size:
- shard-iclb: [PASS][64] -> [FAIL][65] ([i915#5072])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-iclb3/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-iclb7/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size.html

* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-iclb: [PASS][66] -> [FAIL][67] ([i915#2346])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-iclb1/igt@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-iclb7/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-glk: [PASS][68] -> [FAIL][69] ([i915#2346] / [i915#533])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-glk6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-glk7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html

* igt@kms_cursor_legacy@pipe-d-torture-bo:
- shard-apl: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#533])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-apl4/igt@[email protected]

* igt@kms_draw_crc@draw-method-xrgb2101010-blt-4tiled:
- shard-iclb: NOTRUN -> [SKIP][71] ([i915#5287])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-iclb2/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][72] ([i915#5287])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-tglb5/igt@[email protected]

* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: [PASS][73] -> [INCOMPLETE][74] ([i915#180])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-kbl7/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-kbl4/igt@[email protected]

* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-iclb: NOTRUN -> [SKIP][75] ([fdo#109274]) +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-iclb8/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][76] ([fdo#109274] / [fdo#111825])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-tglb1/igt@[email protected]

* igt@kms_flip@flip-vs-panning-vs-hang@c-dp1:
- shard-kbl: [PASS][77] -> [SKIP][78] ([fdo#109271]) +1 similar issue
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-kbl7/igt@kms_flip@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-kbl6/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-panning-vs-hang@c-hdmi-a1:
- shard-glk: [PASS][79] -> [SKIP][80] ([fdo#109271]) +3 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-glk5/igt@kms_flip@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-glk7/igt@kms_flip@[email protected]

* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [PASS][81] -> [DMESG-WARN][82] ([i915#180]) +2 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-kbl3/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-kbl1/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-onoff:
- shard-tglb: NOTRUN -> [SKIP][83] ([fdo#109280] / [fdo#111825]) +1 similar issue
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-tglb2/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-2p-primscrn-indfb-pgflip-blt:
- shard-iclb: NOTRUN -> [SKIP][84] ([fdo#109280]) +5 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-iclb2/igt@[email protected]

* igt@kms_hdr@bpc-switch@pipe-a-dp-1:
- shard-kbl: [PASS][85] -> [FAIL][86] ([i915#1188])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-kbl7/igt@kms_hdr@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-kbl1/igt@kms_hdr@[email protected]

* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-iclb: [PASS][87] -> [SKIP][88] ([fdo#109642] / [fdo#111068] / [i915#658])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-iclb2/igt@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-iclb5/igt@[email protected]

* igt@kms_psr2_su@page_flip-p010:
- shard-kbl: NOTRUN -> [SKIP][89] ([fdo#109271] / [i915#658]) +3 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-kbl4/igt@kms_psr2_su@page_flip-p010.html

* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-apl: NOTRUN -> [SKIP][90] ([fdo#109271] / [i915#658])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-apl6/igt@kms_psr2_su@page_flip-xrgb8888.html

* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: NOTRUN -> [SKIP][91] ([fdo#109441]) +1 similar issue
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-iclb4/igt@kms_psr@psr2_cursor_blt.html
- shard-tglb: NOTRUN -> [FAIL][92] ([i915#132] / [i915#3467])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-tglb6/igt@kms_psr@psr2_cursor_blt.html

* igt@kms_psr@psr2_sprite_plane_onoff:
- shard-iclb: [PASS][93] -> [SKIP][94] ([fdo#109441]) +1 similar issue
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-iclb2/igt@kms_psr@psr2_sprite_plane_onoff.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-iclb5/igt@kms_psr@psr2_sprite_plane_onoff.html

* igt@kms_rotation_crc@primary-rotation-180:
- shard-glk: [PASS][95] -> [DMESG-FAIL][96] ([i915#118])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-glk4/igt@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-glk8/igt@[email protected]

* igt@kms_vblank@pipe-d-wait-idle:
- shard-kbl: NOTRUN -> [SKIP][97] ([fdo#109271] / [i915#533]) +2 similar issues
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-kbl4/igt@[email protected]

* igt@nouveau_crc@pipe-a-ctx-flip-skip-current-frame:
- shard-tglb: NOTRUN -> [SKIP][98] ([i915#2530])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-tglb2/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][99] ([i915#2530])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-iclb8/igt@[email protected]

* igt@prime_nv_pcopy@test_semaphore:
- shard-tglb: NOTRUN -> [SKIP][100] ([fdo#109291])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-tglb3/igt@prime_nv_pcopy@test_semaphore.html
- shard-iclb: NOTRUN -> [SKIP][101] ([fdo#109291])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-iclb4/igt@prime_nv_pcopy@test_semaphore.html

* igt@sysfs_clients@fair-0:
- shard-iclb: NOTRUN -> [SKIP][102] ([i915#2994])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-iclb4/igt@[email protected]

* igt@sysfs_clients@recycle-many:
- shard-kbl: NOTRUN -> [SKIP][103] ([fdo#109271] / [i915#2994]) +1 similar issue
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-kbl4/igt@[email protected]

#### Possible fixes ####

* igt@drm_read@short-buffer-block:
- shard-kbl: [DMESG-WARN][104] ([i915#62] / [i915#92]) -> [PASS][105] +19 similar issues
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-kbl3/igt@[email protected]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-kbl4/igt@[email protected]

* igt@gem_exec_balancer@parallel-out-fence:
- shard-iclb: [SKIP][106] ([i915#4525]) -> [PASS][107] +1 similar issue
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-iclb7/igt@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-iclb1/igt@[email protected]

* igt@gem_exec_capture@pi@rcs0:
- shard-iclb: [INCOMPLETE][108] ([i915#3371]) -> [PASS][109]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-iclb6/igt@gem_exec_capture@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-iclb4/igt@gem_exec_capture@[email protected]

* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-glk: [FAIL][110] ([i915#2842]) -> [PASS][111]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-glk3/igt@gem_exec_fair@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-glk8/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none@vcs0:
- shard-apl: [FAIL][112] ([i915#2842]) -> [PASS][113]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-apl1/igt@gem_exec_fair@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-apl6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [FAIL][114] ([i915#2849]) -> [PASS][115]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-iclb5/igt@gem_exec_fair@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-iclb3/igt@gem_exec_fair@[email protected]

* igt@gem_exec_flush@basic-uc-ro-default:
- shard-snb: [SKIP][116] ([fdo#109271]) -> [PASS][117] +1 similar issue
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-snb6/igt@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-snb4/igt@[email protected]

* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: [FAIL][118] ([i915#454]) -> [PASS][119]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-iclb3/igt@[email protected]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-iclb5/igt@[email protected]

* igt@i915_pm_dc@dc9-dpms:
- shard-iclb: [SKIP][120] ([i915#4281]) -> [PASS][121]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-iclb3/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-iclb6/igt@[email protected]

* igt@i915_selftest@live@hangcheck:
- shard-tglb: [DMESG-WARN][122] ([i915#5591]) -> [PASS][123]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-tglb5/igt@i915_selftest@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-tglb6/igt@i915_selftest@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
- shard-kbl: [DMESG-WARN][124] ([i915#180]) -> [PASS][125] +2 similar issues
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-kbl7/igt@kms_flip@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-kbl3/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend@b-dp1:
- shard-apl: [DMESG-WARN][126] ([i915#180]) -> [PASS][127]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-apl8/igt@kms_flip@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-apl1/igt@kms_flip@[email protected]

* igt@kms_flip@plain-flip-ts-check-interruptible@a-dp1:
- shard-kbl: [DMESG-WARN][128] ([i915#1982] / [i915#62] / [i915#92]) -> [PASS][129]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-kbl3/igt@kms_flip@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-kbl3/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling:
- shard-iclb: [SKIP][130] ([i915#3701]) -> [PASS][131] +1 similar issue
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-iclb7/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling.html

* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [SKIP][132] ([fdo#109441]) -> [PASS][133] +2 similar issues
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-iclb7/igt@kms_psr@psr2_no_drrs.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-iclb2/igt@kms_psr@psr2_no_drrs.html

* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- shard-iclb: [SKIP][134] ([i915#5519]) -> [PASS][135]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-iclb4/igt@[email protected]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-iclb8/igt@[email protected]

#### Warnings ####

* igt@kms_content_protection@srm:
- shard-kbl: [SKIP][136] ([fdo#109271] / [i915#92]) -> [TIMEOUT][137] ([i915#1319])
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-kbl3/igt@[email protected]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-kbl7/igt@[email protected]

* igt@kms_cursor_crc@pipe-d-cursor-256x256-onscreen:
- shard-kbl: [SKIP][138] ([fdo#109271] / [i915#92]) -> [SKIP][139] ([fdo#109271]) +12 similar issues
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-kbl3/igt@[email protected]
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-kbl7/igt@[email protected]

* igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1:
- shard-kbl: [FAIL][140] ([i915#1188]) -> [DMESG-WARN][141] ([i915#180])
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-kbl3/igt@kms_hdr@[email protected]
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-kbl1/igt@kms_hdr@[email protected]

* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf:
- shard-iclb: [SKIP][142] ([i915#2920]) -> [SKIP][143] ([i915#658])
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-iclb2/igt@[email protected]
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-iclb6/igt@[email protected]

* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf:
- shard-iclb: [SKIP][144] ([i915#658]) -> [SKIP][145] ([i915#2920]) +1 similar issue
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-iclb4/igt@[email protected]
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-iclb2/igt@[email protected]

* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-iclb: [SKIP][146] ([i915#2920]) -> [SKIP][147] ([fdo#111068] / [i915#658])
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11730/shard-iclb2/igt@[email protected]
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/shard-iclb1/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6510 -> IGTPW_7247
* Piglit: piglit_4509 -> None

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7247/index.html

Zbigniew Kempczyński

Reviewed-by on v1 1/1

2022-06-08 08:00 UTC #3 lore raw

In reply to Ramalingam C

Quoted 98 lines · Ramalingam C

From: Chris Wilson <[email protected]>

Now that we can create arbitrary dependencies with the igt_spin_t dummy load, we can replace the custom spinner in prime_busy.

Signed-off-by Chris Wilson <[email protected]>

Signed-off-by Ramalingam C <[email protected]>

---
 tests/prime_busy.c | 137 +++++++++------------------------------------
 1 file changed, 25 insertions(+), 112 deletions(-)

tests/prime_busy.c +13 ~~-59~~

index 0b657b67a03e..41ef666a6e84 100644
@@ -42,112 +42,37 @@ static bool prime_busy(struct pollfd *pfd, bool excl)
 
 static void busy(int fd, const intel_ctx_t *ctx, unsigned ring, unsigned flags)
 {
-	const int gen = intel_gen(intel_get_drm_devid(fd));
-	const uint32_t _bbe = MI_BATCH_BUFFER_END;
-	struct drm_i915_gem_exec_object2 obj[2];
-	struct pollfd pfd[2];
 #define SCRATCH 0
 #define BATCH 1
-	struct drm_i915_gem_relocation_entry store[1024+1];
-	struct drm_i915_gem_execbuffer2 execbuf;
-	unsigned size = ALIGN(ARRAY_SIZE(store)*16 + 4, 4096);
-	struct timespec tv;
-	uint32_t *batch, *bbe;
-	int i, count, timeout;
+	uint32_t handle = gem_create(fd, 4096);
+	struct pollfd pfd[2] = {};
+	uint64_t ahnd;
+	igt_spin_t *spin;
+	int timeout;
 
 	gem_quiescent_gpu(fd);
 
-	memset(&execbuf, 0, sizeof(execbuf));
-	execbuf.buffers_ptr = to_user_pointer(obj);
-	execbuf.buffer_count = 2;
-	execbuf.flags = ring;
-	if (gen < 6)
-		execbuf.flags |= I915_EXEC_SECURE;
-	execbuf.rsvd1 = ctx->id;
-
-	memset(obj, 0, sizeof(obj));
-	obj[SCRATCH].handle = gem_create(fd, 4096);
-
-	obj[BATCH].handle = gem_create(fd, size);
-	obj[BATCH].offset = 1 << 20;
-	gem_write(fd, obj[BATCH].handle, 0, &_bbe, sizeof(_bbe));
-	igt_require(__gem_execbuf(fd, &execbuf) == 0); /* prebind the buffers */
-
-	obj[BATCH].relocs_ptr = to_user_pointer(store);
-	obj[BATCH].relocation_count = ARRAY_SIZE(store);
-	memset(store, 0, sizeof(store));
+	ahnd = get_reloc_ahnd(fd, ctx->id);
+	spin = igt_spin_new(fd,
+			    .ahnd = ahnd,
+			    .ctx = ctx, .engine = ring,
+			    .dependency = handle,
+			    .flags = (flags & HANG ? IGT_SPIN_NO_PREEMPTION : 0));
+	igt_spin_end(spin);
+	gem_sync(fd, spin->handle);
 
 	if (flags & BEFORE) {
-		memset(pfd, 0, sizeof(pfd));
-		pfd[SCRATCH].fd = prime_handle_to_fd(fd, obj[SCRATCH].handle);
-		pfd[BATCH].fd = prime_handle_to_fd(fd, obj[BATCH].handle);
-	}
-
-	batch = gem_mmap__device_coherent(fd, obj[BATCH].handle, 0, size, PROT_WRITE);
-	gem_set_domain(fd, obj[BATCH].handle,
-			I915_GEM_DOMAIN_GTT, I915_GEM_DOMAIN_GTT);
-
-	i = 0;
-	for (count = 0; count < 1024; count++) {
-		uint64_t offset;
-
-		store[count].target_handle = obj[SCRATCH].handle;
-		store[count].presumed_offset = obj[SCRATCH].offset;
-		store[count].offset = sizeof(uint32_t) * (i + 1);
-		store[count].delta = sizeof(uint32_t) * count;
-		store[count].read_domains = I915_GEM_DOMAIN_RENDER;
-		store[count].write_domain = I915_GEM_DOMAIN_RENDER;
-
-		offset = store[count].presumed_offset + store[count].delta;
-
-		batch[i] = MI_STORE_DWORD_IMM | (gen < 6 ? 1 << 22 : 0);
-		if (gen >= 8) {
-			batch[++i] = offset;
-			batch[++i] = offset >> 32;
-		} else if (gen >= 4) {
-			batch[++i] = 0;
-			batch[++i] = offset;
-			store[count].offset += sizeof(uint32_t);

tests/prime_busy.c static bool prime_busy(struct pollfd *pfd, bool excl) · line 67

Quoted 10 lines

tests/prime_busy.c +2 -7

-		} else {
-			batch[i]--;
-			batch[++i] = offset;
-		}
-		batch[++i] = count;
-		i++;
-	}
+		pfd[SCRATCH].fd = prime_handle_to_fd(fd, spin->obj[SCRATCH].handle);
+		pfd[BATCH].fd = prime_handle_to_fd(fd, spin->obj[BATCH].handle);

Unnecessary empty line in if block.

Quoted 54 lines

tests/prime_busy.c +5 ~~-31~~

-	bbe = &batch[i];
-	store[count].target_handle = obj[BATCH].handle; /* recurse */
-	store[count].presumed_offset = obj[BATCH].offset;
-	store[count].offset = sizeof(uint32_t) * (i + 1);
-	store[count].delta = 0;
-	store[count].read_domains = I915_GEM_DOMAIN_COMMAND;
-	store[count].write_domain = 0;
-	batch[i] = MI_BATCH_BUFFER_START;
-	if (gen >= 8) {
-		batch[i] |= 1 << 8 | 1;
-		batch[++i] = obj[BATCH].offset;
-		batch[++i] = obj[BATCH].offset >> 32;
-	} else if (gen >= 6) {
-		batch[i] |= 1 << 8;
-		batch[++i] = obj[BATCH].offset;
-	} else {
-		batch[i] |= 2 << 6;
-		batch[++i] = obj[BATCH].offset;
-		if (gen < 4) {
-			batch[i] |= 1;
-			store[count].delta = 1;
-		}
 	}
-	i++;
 
-	igt_assert(i < size/sizeof(*batch));
-	igt_require(__gem_execbuf(fd, &execbuf) == 0);
+	igt_spin_reset(spin);
+	gem_execbuf(fd, &spin->execbuf);
 
 	if (flags & AFTER) {
-		memset(pfd, 0, sizeof(pfd));
-		pfd[SCRATCH].fd = prime_handle_to_fd(fd, obj[SCRATCH].handle);
-		pfd[BATCH].fd = prime_handle_to_fd(fd, obj[BATCH].handle);
+		pfd[SCRATCH].fd = prime_handle_to_fd(fd, spin->obj[SCRATCH].handle);
+		pfd[BATCH].fd = prime_handle_to_fd(fd, spin->obj[BATCH].handle);
 	}
 
 	igt_assert(prime_busy(&pfd[SCRATCH], false));

@@ -158,8 +83,7 @@ static void busy(int fd, const intel_ctx_t *ctx, unsigned ring, unsigned flags)
 
 	timeout = 120;
 	if ((flags & HANG) == 0) {
-		*bbe = MI_BATCH_BUFFER_END;
-		__sync_synchronize();
+		igt_spin_end(spin);
 		timeout = 1;
 	}

@@ -168,23 +92,18 @@ static void busy(int fd, const intel_ctx_t *ctx, unsigned ring, unsigned flags)
 		pfd[BATCH].events = POLLOUT;
 		igt_assert(poll(pfd, 1, timeout * 1000) == 1);
 	} else {
-		memset(&tv, 0, sizeof(tv));

tests/prime_busy.c static void busy(int fd, const intel_ctx_t *ctx, unsigned ring, unsigned flags) · line 180

Quoted 10 lines

tests/prime_busy.c +1 -4

+		struct timespec tv = {};
 		while (prime_busy(&pfd[BATCH], true))
 			igt_assert(igt_seconds_elapsed(&tv) < timeout);
 	}
 	igt_assert(!prime_busy(&pfd[SCRATCH], true));
 
-	munmap(batch, size);
-	batch = gem_mmap__device_coherent(fd, obj[SCRATCH].handle, 0, 4096, PROT_READ);
-	for (i = 0; i < 1024; i++)
-		igt_assert_eq_u32(batch[i], i);

Previously we just verified data are visible. Do I understand that we're not interested to check this?

tests/prime_busy.c static void busy(int fd, const intel_ctx_t *ctx, unsigned ring, unsigned flags) · line 106

Quoted 10 lines

tests/prime_busy.c +3 -4

-	munmap(batch, 4096);
-
-	gem_close(fd, obj[BATCH].handle);
-	gem_close(fd, obj[SCRATCH].handle);
+	igt_spin_free(fd, spin);
+	gem_close(fd, handle);
 
 	close(pfd[BATCH].fd);
 	close(pfd[SCRATCH].fd);
+	intel_allocator_close(ahnd);

Use put_ahnd() wrapper instead, for older gens it will just skip entering allocator code.

Quoted 28 lines

tests/prime_busy.c +1 -7

 }
 
 static void test_mode(int fd, const intel_ctx_t *ctx, unsigned int flags)

@@ -198,12 +117,6 @@ static void test_mode(int fd, const intel_ctx_t *ctx, unsigned int flags)
 		hang = igt_allow_hang(fd, ctx->id, 0);
 
 	for_each_ctx_engine(fd, ctx, e) {
-		if (!gem_class_can_store_dword(fd, e->class))
-			continue;
-
-		if (!gem_class_has_mutable_submission(fd, e->class))
-			continue;
-
 		igt_dynamic_f("%s", e->name)
 			busy(fd, ctx, e->flags, flags);
 	}

@@ -220,7 +133,7 @@ igt_main
 	int fd = -1;
 
 	igt_fixture {
-		fd = drm_open_driver_master(DRIVER_INTEL);
+		fd = drm_open_driver(DRIVER_INTEL);
 		igt_require_gem(fd);
 		ctx = intel_ctx_create_all_physical(fd);
 	}

Signature · 1 line

2.20.1

So if we're not interested in checking expected values but checking prime dmabufs busyness with small nit (put_ahnd()):

Reviewed-by Zbigniew Kempczyński <[email protected]>

--
Zbigniew