usb: host: ehci-generic: Make resets and clocks optional
Subsystems (3)
PATCH 1/1 usb: host: ehci-generic: Make resets and clocks optional
The generic EHCI binding does not *require* resets and clocks properties, and indeed for instance the Allwinner A20 SoCs does not need or define any resets in its DT.
Don't easily give up if clk_get_bulk() or reset_get_bulk() return an error, but check if that is due to the DT simply having no entries for either of them.
This fixes USB operation on all boards with an Allwinner A10 or A20 SoC, which were reporting an error after commit ba96176ab70e2999:
=======================
Bus usb@1c14000: ehci_generic usb@1c14000: Failed to get resets (err=-2) probe failed, error -2
=======================
--- drivers/usb/host/ehci-generic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/usb/host/ehci-generic.c +2 -2
@@ -69,7 +69,7 @@ static int ehci_usb_probe(struct udevice *dev) err =0 ; ret =clk_get_bulk (dev, &priv->clocks); -if (ret) { +if (ret && ret != -ENOENT ) {dev_err (dev,"Failed to get clocks (ret=%d)\n" , ret);return ret; }
@@ -81,7 +81,7 @@ static int ehci_usb_probe(struct udevice *dev) } err =reset_get_bulk (dev, &priv->resets); -if (err) { +if (ret && ret != -ENOENT ) {dev_err (dev,"Failed to get resets (err=%d)\n" , err); goto clk_err; }
Signature · 1 line
2.35.3
Hi Andre
Quoted 34 lines · Andre Przywara
The generic EHCI binding does not *require* resets and clocks properties, and indeed for instance the Allwinner A20 SoCs does not need or define any resets in its DT.
Don't easily give up if
clk_get_bulk()orreset_get_bulk()return an error, but check if that is due to the DT simply having no entries for either of them.This fixes USB operation on all boards with an Allwinner A10 or A20 SoC, which were reporting an error after commit
ba96176ab70e2999:
=======================
Bus usb@1c14000:ehci_genericusb@1c14000: Failed to get resets (err=-2) probe failed, error -2
=======================Signed-off-by Andre Przywara <[email protected]>--- drivers/usb/host/ehci-generic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/usb/host/ehci-generic.c +1
-1@@ -69,7 +69,7 @@ static int ehci_usb_probe(struct udevice *dev) err =0 ; ret =clk_get_bulk (dev, &priv->clocks); -if (ret) { +if (ret && ret != -ENOENT ) {dev_err (dev,"Failed to get clocks (ret=%d)\n" , ret);return ret; }
drivers/usb/host/ehci-generic.c static int ehci_usb_probe(struct udevice *dev) · line 87
Quoted 8 lines
drivers/usb/host/ehci-generic.c +1
-1@@ -81,7 +81,7 @@ static int ehci_usb_probe(struct udevice *dev) } err =reset_get_bulk (dev, &priv->resets); -if (err) { +if (ret && ret != -ENOENT ) {dev_err (dev,"Failed to get resets (err=%d)\n" , err); goto clk_err; }
Thanks
Patrice
Quoted 15 lines · Andre Przywara
The generic EHCI binding does not *require* resets and clocks properties, and indeed for instance the Allwinner A20 SoCs does not need or define any resets in its DT.
Don't easily give up if
clk_get_bulk()orreset_get_bulk()return an error, but check if that is due to the DT simply having no entries for either of them.This fixes USB operation on all boards with an Allwinner A10 or A20 SoC, which were reporting an error after commit
ba96176ab70e2999:
=======================
Bus usb@1c14000:ehci_genericusb@1c14000: Failed to get resets (err=-2) probe failed, error -2
=======================
Quoted 2 lines
Signed-off-by Andre Przywara <[email protected]>Reviewed-by Patrice Chotard <[email protected]>
Applied to u-boot/master, thanks!
Signature · 1 line
Tom