i915/gem_exec_fair: Add subtests description

PATCH In review [email protected] 3 participants 5 messages Jun 8, 2022 – Jun 9, 2022

lore

Share & tools

lore

[email protected]

author

2022-06-08 05:55 UTC #0 lore raw

cover i915/gem_exec_fair: Add subtests description

From: Sinjan Kumar <[email protected]>

Add subtests description

Sinjan Kumar (2):
i915/gem_exec_fair: Add subtests description
HAX: don't do full run

 tests/i915/gem_exec_fair.c            |   7 +
 tests/intel-ci/fast-feedback.testlist | 186 +-------------------------
 2 files changed, 8 insertions(+), 185 deletions(-)

Signature · 1 line

2.25.1

[email protected]

author

2022-06-08 05:55 UTC #1 lore raw

PATCH 1/2 i915/gem_exec_fair: Add subtests description

From: Sinjan Kumar <[email protected]>

add subtest description

Cc Kamil Konieczny <[email protected]>

Cc Priyanka Dandamudi <[email protected]>

Signed-off-by Sinjan Kumar <[email protected]>

---
 tests/i915/gem_exec_fair.c | 7 +++++++
 1 file changed, 7 insertions(+)

tests/i915/gem_exec_fair.c +7 -0

index 935f9c4a..f856be1d 100644
@@ -1351,8 +1351,15 @@ igt_main
 		}
 	}
 
+        igt_describe("Test forks N independent clients and put an equal "
+                     "amount of work in client and asserts that all of "
+                     "them finishes within the given timeline.");
 	igt_subtest("basic-deadline")
 		deadline(i915, &cfg, 2, 0);
+        igt_describe("Test forks N independent clients and put an equal "
+                     "amount of work in client and asserts that all of "
+                     "them finishes within the given timeline "
+                     "when task priority is also set.");
 	igt_subtest("deadline-prio")
 		deadline(i915, &cfg, 2, DL_PRIO);

Signature · 1 line

2.25.1

Kamil Konieczny

2022-06-09 11:24 UTC #2 lore raw

Hi Sinjan,

Quoted 3 lines · On 2022-06-08 at 11:25:07 +0530, [email protected] wrote:

From: Sinjan Kumar <[email protected]>
add subtest description

- ^ -------- ^---------- ^^

This can be improved a little: Add subtests descriptions.

Quoted 13 lines

Cc Kamil Konieczny <[email protected]>
Cc Priyanka Dandamudi <[email protected]>
Signed-off-by Sinjan Kumar <[email protected]>
---
 tests/i915/gem_exec_fair.c | 7 +++++++
 1 file changed, 7 insertions(+)
tests/i915/gem_exec_fair.c +0 -0
index 935f9c4a..f856be1d 100644

tests/i915/gem_exec_fair.c igt_main · line 1356

Quoted 6 lines

tests/i915/gem_exec_fair.c +3 -0

@@ -1351,8 +1351,15 @@ igt_main
 		}
 	}
 
+        igt_describe("Test forks N independent clients and put an equal "
+                     "amount of work in client and asserts that all of "
+                     "them finishes within the given timeline.");

Please do not write down exact code steps taken, rather than that try to describe what subtest is doing. Search for igt_describe inside lib/igt_core.h for tips. You may also run git log to see history (maybe with -p option):

git log tests/i915/gem_exec_fair.c

Other way you can try reaching to developer(s) who written these tests, for example on irc, or search mailing list history.

Last one, after you add description, compile it and run with:

sudo ./gem_exec_fair --describe

to see what other ones are missing.

tests/i915/gem_exec_fair.c igt_main · line 1362

Quoted 6 lines

tests/i915/gem_exec_fair.c +4 -0

 	igt_subtest("basic-deadline")
 		deadline(i915, &cfg, 2, 0);
+        igt_describe("Test forks N independent clients and put an equal "
+                     "amount of work in client and asserts that all of "
+                     "them finishes within the given timeline "
+                     "when task priority is also set.");

imho this one also needs improvement. You can work on other descriptions step by step, just extend this patch, so it will be only one patch per test file.

Regards,
Kamil

Quoted 6 lines

tests/i915/gem_exec_fair.c +0 -0
 	igt_subtest("deadline-prio")
 		deadline(i915, &cfg, 2, DL_PRIO);
 
Signature · 1 line
2.25.1

[email protected]

author

2022-06-08 05:55 UTC #3 lore raw

PATCH 2/2 HAX: don't do full run

In reply to [email protected]

From: Sinjan Kumar <[email protected]>

Just for test description, no full run is necessary

Cc Kamil Konieczny <[email protected]>

Cc Priyanka Dandamudi <[email protected]>

Signed-off-by Sinjan Kumar <[email protected]>

---
 tests/intel-ci/fast-feedback.testlist | 186 +-------------------------
 1 file changed, 1 insertion(+), 185 deletions(-)

tests/intel-ci/fast-feedback.testlist +1 ~~-185~~

index 14cad7c0..9f8e18ce 100644
@@ -1,185 +1 @@
-# Keep alphabetically sorted by default
-
-igt@core_auth@basic-auth
-igt@debugfs_test@read_all_entries
-igt@fbdev@eof
-igt@fbdev@info
-igt@fbdev@nullptr
-igt@fbdev@read
-igt@fbdev@write
-igt@gem_basic@bad-close
-igt@gem_basic@create-close
-igt@gem_basic@create-fd-close
-igt@gem_busy@busy@all
-igt@gem_close_race@basic-process
-igt@gem_close_race@basic-threads
-igt@gem_ctx_create@basic
-igt@gem_ctx_create@basic-files
-igt@gem_ctx_exec@basic
-igt@gem_exec_basic@basic
-igt@gem_exec_create@basic
-igt@gem_exec_fence@basic-busy
-igt@gem_exec_fence@basic-wait
-igt@gem_exec_fence@basic-await
-igt@gem_exec_fence@nb-await
-igt@gem_exec_gttfill@basic
-igt@gem_exec_parallel@engines
-igt@gem_exec_store@basic
-igt@gem_flink_basic@bad-flink
-igt@gem_flink_basic@bad-open
-igt@gem_flink_basic@basic
-igt@gem_flink_basic@double-flink
-igt@gem_flink_basic@flink-lifetime
-igt@gem_huc_copy@huc-copy
-igt@gem_linear_blits@basic
-igt@gem_mmap@basic
-igt@gem_mmap_gtt@basic
-igt@gem_render_linear_blits@basic
-igt@gem_render_tiled_blits@basic
-igt@gem_ringfill@basic-all
-igt@gem_softpin@allocator-basic
-igt@gem_softpin@allocator-basic-reserve
-igt@gem_softpin@safe-alignment
-igt@gem_sync@basic-all
-igt@gem_sync@basic-each
-igt@gem_tiled_blits@basic
-igt@gem_tiled_fence_blits@basic
-igt@gem_tiled_pread_basic
-igt@gem_wait@busy@all
-igt@gem_wait@wait@all
-igt@i915_getparams_basic@basic-eu-total
-igt@i915_getparams_basic@basic-subslice-total
-igt@i915_hangman@error-state-basic
-igt@i915_pciid
-igt@kms_addfb_basic@addfb25-bad-modifier
-igt@kms_addfb_basic@addfb25-framebuffer-vs-set-tiling
-igt@kms_addfb_basic@addfb25-modifier-no-flag
-igt@kms_addfb_basic@addfb25-x-tiled-legacy
-igt@kms_addfb_basic@addfb25-x-tiled-mismatch-legacy
-igt@kms_addfb_basic@addfb25-yf-tiled-legacy
-igt@kms_addfb_basic@addfb25-y-tiled-legacy
-igt@kms_addfb_basic@addfb25-y-tiled-small-legacy
-igt@kms_addfb_basic@bad-pitch-0
-igt@kms_addfb_basic@bad-pitch-1024
-igt@kms_addfb_basic@bad-pitch-128
-igt@kms_addfb_basic@bad-pitch-256
-igt@kms_addfb_basic@bad-pitch-32
-igt@kms_addfb_basic@bad-pitch-63
-igt@kms_addfb_basic@bad-pitch-65536
-igt@kms_addfb_basic@bad-pitch-999
-igt@kms_addfb_basic@basic
-igt@kms_addfb_basic@basic-x-tiled-legacy
-igt@kms_addfb_basic@basic-y-tiled-legacy
-igt@kms_addfb_basic@bo-too-small
-igt@kms_addfb_basic@bo-too-small-due-to-tiling
-igt@kms_addfb_basic@clobberred-modifier
-igt@kms_addfb_basic@framebuffer-vs-set-tiling
-igt@kms_addfb_basic@invalid-get-prop
-igt@kms_addfb_basic@invalid-get-prop-any
-igt@kms_addfb_basic@invalid-set-prop
-igt@kms_addfb_basic@invalid-set-prop-any
-igt@kms_addfb_basic@no-handle
-igt@kms_addfb_basic@size-max
-igt@kms_addfb_basic@small-bo
-igt@kms_addfb_basic@tile-pitch-mismatch
-igt@kms_addfb_basic@too-high
-igt@kms_addfb_basic@too-wide
-igt@kms_addfb_basic@unused-handle
-igt@kms_addfb_basic@unused-modifier
-igt@kms_addfb_basic@unused-offsets
-igt@kms_addfb_basic@unused-pitches
-igt@kms_busy@basic
-igt@kms_chamelium@dp-hpd-fast
-igt@kms_chamelium@dp-edid-read
-igt@kms_chamelium@dp-crc-fast
-igt@kms_chamelium@hdmi-hpd-fast
-igt@kms_chamelium@hdmi-edid-read
-igt@kms_chamelium@hdmi-crc-fast
-igt@kms_chamelium@vga-hpd-fast
-igt@kms_chamelium@vga-edid-read
-igt@kms_prop_blob@basic
-igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic
-igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy
-igt@kms_cursor_legacy@basic-flip-after-cursor-atomic
-igt@kms_cursor_legacy@basic-flip-after-cursor-legacy
-igt@kms_cursor_legacy@basic-flip-after-cursor-varying-size
-igt@kms_cursor_legacy@basic-flip-before-cursor-atomic
-igt@kms_cursor_legacy@basic-flip-before-cursor-legacy
-igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size
-igt@kms_flip@basic-flip-vs-dpms
-igt@kms_flip@basic-flip-vs-modeset
-igt@kms_flip@basic-flip-vs-wf_vblank
-igt@kms_flip@basic-plain-flip
-igt@kms_force_connector_basic@force-connector-state
-igt@kms_force_connector_basic@force-edid
-igt@kms_force_connector_basic@force-load-detect
-igt@kms_force_connector_basic@prune-stale-modes
-igt@kms_frontbuffer_tracking@basic
-igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-a
-igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b
-igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c
-igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d
-igt@kms_pipe_crc_basic@hang-read-crc-pipe-a
-igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a
-igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence
-igt@kms_pipe_crc_basic@read-crc-pipe-a
-igt@kms_pipe_crc_basic@read-crc-pipe-b
-igt@kms_pipe_crc_basic@read-crc-pipe-c
-igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence
-igt@kms_psr@primary_page_flip
-igt@kms_psr@cursor_plane_move
-igt@kms_psr@sprite_plane_onoff
-igt@kms_psr@primary_mmap_gtt
-igt@kms_setmode@basic-clone-single-crtc
-igt@i915_pm_backlight@basic-brightness
-igt@i915_pm_rpm@basic-pci-d3-state
-igt@i915_pm_rpm@basic-rte
-igt@i915_pm_rps@basic-api
-igt@prime_self_import@basic-llseek-bad
-igt@prime_self_import@basic-llseek-size
-igt@prime_self_import@basic-with_fd_dup
-igt@prime_self_import@basic-with_one_bo
-igt@prime_self_import@basic-with_one_bo_two_files
-igt@prime_self_import@basic-with_two_bos
-igt@prime_vgem@basic-fence-flip
-igt@prime_vgem@basic-fence-mmap
-igt@prime_vgem@basic-fence-read
-igt@prime_vgem@basic-gtt
-igt@prime_vgem@basic-read
-igt@prime_vgem@basic-write
-igt@prime_vgem@basic-userptr
-igt@vgem_basic@setversion
-igt@vgem_basic@create
-igt@vgem_basic@debugfs
-igt@vgem_basic@dmabuf-export
-igt@vgem_basic@dmabuf-fence
-igt@vgem_basic@dmabuf-fence-before
-igt@vgem_basic@dmabuf-mmap
-igt@vgem_basic@mmap
-igt@vgem_basic@second-client
-igt@vgem_basic@sysfs
-
-# All tests that do module unloading and reloading are executed last.
-# They will sometimes reveal issues of earlier tests leaving the
-# driver in a broken state that is not otherwise noticed in that test.
-
-igt@core_hotunplug@unbind-rebind
-igt@vgem_basic@unload
-igt@i915_module_load@reload
-igt@gem_lmem_swapping@basic
-igt@gem_lmem_swapping@parallel-random-engines
-igt@gem_lmem_swapping@random-engines
-igt@gem_lmem_swapping@verify-random
-igt@i915_pm_rpm@module-reload
-
-# Kernel selftests
-igt@i915_selftest@live
-igt@dmabuf@all
-
-# System wide suspend tests
-igt@i915_suspend@basic-s2idle-without-i915
-igt@i915_suspend@basic-s3-without-i915
-igt@gem_exec_suspend@basic-s0
-igt@gem_exec_suspend@basic-s3
-igt@kms_chamelium@common-hpd-after-suspend
-igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a
+igt@meta_test@fail-result

Signature · 1 line

2.25.1

Patchwork

2022-06-08 07:47 UTC #4 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for i915/gem_exec_fair: Add subtests description

In reply to [email protected]

== Series Details ==

Series: i915/gem_exec_fair: Add subtests description
URL : https://patchwork.freedesktop.org/series/104874/
State : failure

== Summary ==

CI Bug Log - changes from IGT_6513 -> IGTPW_7252
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_7252 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_7252, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7252/index.html

Participating hosts (45 -> 40)
------------------------------

Additional (1): fi-rkl-11600
Missing (6): fi-icl-u2 bat-adlp-4 bat-atsm-1 fi-bdw-samus bat-jsl-2 bat-jsl-1

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_7252:

### IGT changes ###

#### Possible regressions ####

New tests
---------

New tests have been introduced between IGT_6513 and IGTPW_7252:

### New IGT tests (1) ###

* igt@meta_test@fail-result:
- Statuses : 40 fail(s)
- Exec time: [0.00, 0.23] s

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6513 -> IGTPW_7252

CI-20190529: 20190529
CI_DRM_11733: 4a478d4716b11a64fbc702a176ec3d078a168bc5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_7252: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7252/index.html
IGT_6513: 2aff41793e5f7f23206547ff615187708e728b92 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7252/index.html