Skip to contentSkip to conversation

ARM: dts: aspeed: Add a palmetto board (AST2400)

PATCH Superseded Cédric Le Goater 2 participants 3 messages Jun 8, 2022 Arm (32-bit)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: aspeed: Add a palmetto board (AST2400)

Palmettos were the first OpenPOWER systems built by Tyan with the product name: GN70-BP010. They contained an IBM POWER8 Turismo SCM processor and an Aspeed AST2400 SoC.

---
 arch/arm/dts/Makefile              |   1 +
 arch/arm/dts/ast2400-palmetto.dts  | 102 +++++++++++++++++++++++++++++
 configs/ast2400-palmetto_defconfig |  74 +++++++++++++++++++++
 3 files changed, 177 insertions(+)
 create mode 100644 arch/arm/dts/ast2400-palmetto.dts
 create mode 100644 configs/ast2400-palmetto_defconfig
arch/arm/dts/Makefile +1 -0
index 3515100c65ce..4faf29d747bd 100755
@@ -676,6 +676,7 @@ dtb-$(CONFIG_ARCH_BCM6858) += \
 
 dtb-$(CONFIG_ARCH_ASPEED) += \
 	ast2400-evb.dtb \
+	ast2400-palmetto.dtb \
 	ast2400-ahe-50dc.dtb \
 	ast2500-evb.dtb \
 	ast2600a0-evb.dtb \
arch/arm/dts/ast2400-palmetto.dts new file +102 -0

102 lines not on this page · raw message

configs/ast2400-palmetto_defconfig new file +74 -0

74 lines not on this page · raw message

Signature · 1 line
2.35.3
#1 lore raw
Quoted 4 lines · Cédric Le Goater

Palmettos were the first OpenPOWER systems built by Tyan with the product name: GN70-BP010. They contained an IBM POWER8 Turismo SCM processor and an Aspeed AST2400 SoC.

Good idea.

Quoted 43 lines
---
 arch/arm/dts/Makefile              |   1 +
 arch/arm/dts/ast2400-palmetto.dts  | 102 +++++++++++++++++++++++++++++
 configs/ast2400-palmetto_defconfig |  74 +++++++++++++++++++++
 3 files changed, 177 insertions(+)
 create mode 100644 arch/arm/dts/ast2400-palmetto.dts
 create mode 100644 configs/ast2400-palmetto_defconfig
arch/arm/dts/Makefile +1 -0
index 3515100c65ce..4faf29d747bd 100755
@@ -676,6 +676,7 @@ dtb-$(CONFIG_ARCH_BCM6858) += \
 
 dtb-$(CONFIG_ARCH_ASPEED) += \
        ast2400-evb.dtb \
+       ast2400-palmetto.dtb \
        ast2400-ahe-50dc.dtb \
        ast2500-evb.dtb \
        ast2600a0-evb.dtb \
arch/arm/dts/ast2400-palmetto.dts new file +14 -0
new file mode 100644
index 000000000000..a512f602d2f1
@@ -0,0 +1,102 @@
+// SPDX-License-Identifier: GPL-2.0+
+/dts-v1/;
+
+#include "ast2400-u-boot.dtsi"
+
+/ {
+       model = "Palmetto BMC";
+       compatible = "tyan,palmetto-bmc", "aspeed,ast2400";
+
+       memory@40000000 {
+               device_type = "memory";
+               reg = <0x40000000 0x10000000>;
+       };
+

arch/arm/dts/ast2400-palmetto.dts line 24

Quoted 10 lines
arch/arm/dts/ast2400-palmetto.dts new file +10 -0
+       chosen {
+               stdout-path = &uart5;
+               bootargs = "console=ttyS4,115200 earlyprintk";
+       };
+
+       aliases {
+               spi0 = &fmc;
+               spi1 = &spi1;
+               ethernet0 = &mac0;
+               ethernet1 = &mac1;

They only had one ethernet connection.

Quoted 32 lines
arch/arm/dts/ast2400-palmetto.dts new file +32 -0
+       };
+};
+
+&uart5 {
+       u-boot,dm-pre-reloc;
+       status = "okay";
+};
+
+&sdrammc {
+       clock-frequency = <200000000>;
+};
+
+&wdt1 {
+       u-boot,dm-pre-reloc;
+       status = "okay";
+};
+
+&wdt2 {
+       u-boot,dm-pre-reloc;
+       status = "okay";
+};
+
+&mac0 {
+       status = "okay";
+       phy-mode = "rgmii";
+
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_mac1link_default &pinctrl_mdio1_default>;
+};
+
+&mac1 {
+       status = "okay";

arch/arm/dts/ast2400-palmetto.dts line 66

Quoted 10 lines
arch/arm/dts/ast2400-palmetto.dts new file +10 -0
+       phy-mode = "rgmii";
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_mac2link_default &pinctrl_mdio2_default>;
+};
+
+
+&fmc {
+       status = "okay";
+       flash@0 {
+               compatible = "spi-flash", "sst,w25q256";

You just removed all of these :)

Quoted 11 lines
arch/arm/dts/ast2400-palmetto.dts new file +11 -0
+               status = "okay";
+               spi-max-frequency = <50000000>;
+               spi-tx-bus-width = <2>;
+               spi-rx-bus-width = <2>;
+       };
+
+       flash@1 {
+                compatible = "spi-flash", "sst,w25q256";
+                status = "okay";
+                spi-max-frequency = <50000000>;
+                spi-tx-bus-width = <2>;

arch/arm/dts/ast2400-palmetto.dts line 87

Quoted 10 lines
arch/arm/dts/ast2400-palmetto.dts new file +10 -0
+                spi-rx-bus-width = <2>;
+        };
+};
+
+&spi1 {
+       status = "okay";
+       flash@0 {
+               pinctrl-names = "default";
+               pinctrl-0 = <&pinctrl_spi1_default>;
+               compatible = "spi-flash", "sst,w25q256";

They only have one flash on each controller iirc.

configs/ast2400-palmetto_defconfig

Quoted 20 lines
arch/arm/dts/ast2400-palmetto.dts new file +15 -0
+               status = "okay";
+               spi-max-frequency = <50000000>;
+               spi-tx-bus-width = <2>;
+               spi-rx-bus-width = <2>;
+       };
+       flash@1 {
+               pinctrl-names = "default";
+               pinctrl-0 = <&pinctrl_spi1_default &pinctrl_spi1cs1_default>;
+               compatible = "spi-flash", "sst,w25q256";
+               status = "okay";
+               spi-max-frequency = <50000000>;
+               spi-tx-bus-width = <2>;
+               spi-rx-bus-width = <2>;
+       };
+};
configs/ast2400-palmetto_defconfig new file +0 -0
new file mode 100644
index 000000000000..8802323b4db8

Do we need a separate defconfig from the one for the evb? If not, can we adjust the evb defconfig to suit?

Hopefully we can just build it with DEVICE_TREE=ast2400-palmetto and an existing defconfig.

Quoted 78 lines
configs/ast2400-palmetto_defconfig new file +74 -1
@@ -0,0 +1,74 @@
+CONFIG_ARM=y
+CONFIG_ARCH_ASPEED=y
+CONFIG_SYS_TEXT_BASE=0x0
+CONFIG_ASPEED_AST2400=y
+CONFIG_SYS_MALLOC_F_LEN=0x800
+CONFIG_ENV_SIZE=0x10000
+CONFIG_ENV_OFFSET=0xF0000
+CONFIG_NR_DRAM_BANKS=1
+CONFIG_FIT=y
+CONFIG_USE_BOOTARGS=y
+CONFIG_BOOTARGS="console=ttyS4,115200n8 root=/dev/ram rw"
+CONFIG_USE_BOOTCOMMAND=y
+CONFIG_BOOTCOMMAND="bootm 20080000"
+CONFIG_PRE_CONSOLE_BUFFER=y
+CONFIG_PRE_CON_BUF_ADDR=0x1e720000
+CONFIG_SYS_CONSOLE_ENV_OVERWRITE=y
+CONFIG_HUSH_PARSER=y
+# CONFIG_AUTO_COMPLETE is not set
+CONFIG_SYS_PROMPT="ast# "
+CONFIG_CMD_MEMTEST=y
+CONFIG_SYS_ALT_MEMTEST=y
+CONFIG_CMD_CLK=y
+CONFIG_CMD_GPIO=y
+CONFIG_CMD_I2C=y
+CONFIG_CMD_MMC=y
+CONFIG_CMD_SF=y
+CONFIG_CMD_DHCP=y
+CONFIG_CMD_MII=y
+CONFIG_CMD_PING=y
+CONFIG_DEFAULT_DEVICE_TREE="ast2400-palmetto"
+CONFIG_ENV_IS_IN_SPI_FLASH=y
+CONFIG_USE_ENV_SPI_BUS=y
+CONFIG_ENV_SPI_BUS=0
+CONFIG_USE_ENV_SPI_CS=y
+CONFIG_ENV_SPI_CS=0
+CONFIG_USE_ENV_SPI_MAX_HZ=y
+CONFIG_ENV_SPI_MAX_HZ=100000000
+CONFIG_NET_RANDOM_ETHADDR=y
+CONFIG_REGMAP=y
+CONFIG_CLK=y
+CONFIG_DM_GPIO=y
+CONFIG_ASPEED_GPIO=y
+CONFIG_DM_I2C=y
+CONFIG_SYS_I2C_ASPEED=y
+CONFIG_MISC=y
+CONFIG_DM_MMC=y
+# CONFIG_MMC_HW_PARTITIONING is not set
+CONFIG_MMC_SDHCI=y
+CONFIG_MMC_SDHCI_ASPEED=y
+CONFIG_DM_SPI_FLASH=y
+CONFIG_SPI_FLASH=y
+CONFIG_SPI_FLASH_GIGADEVICE=y
+CONFIG_SPI_FLASH_MACRONIX=y
+CONFIG_SPI_FLASH_SPANSION=y
+CONFIG_SPI_FLASH_STMICRO=y
+CONFIG_SPI_FLASH_WINBOND=y
+CONFIG_PHY_REALTEK=y
+CONFIG_PHY_NCSI=y
+CONFIG_DM_ETH=y
+CONFIG_PHY_GIGE=y
+CONFIG_FTGMAC100=y
+CONFIG_PHY=y
+CONFIG_PINCTRL=y
+CONFIG_RAM=y
+CONFIG_DM_SERIAL=y
+CONFIG_SYS_NS16550=y
+CONFIG_SPI=y
+CONFIG_DM_SPI=y
+CONFIG_SYSRESET=y
+CONFIG_TIMER=y
+CONFIG_WDT=y
+CONFIG_DM_RESET=y
+# CONFIG_CMD_BOOTEFI is not set
+# CONFIG_EFI_LOADER is not set
--

2.35.3

#2 lore raw
Quoted 55 lines · Joel Stanley
Quoted 4 lines · Cédric Le Goater

Palmettos were the first OpenPOWER systems built by Tyan with the product name: GN70-BP010. They contained an IBM POWER8 Turismo SCM processor and an Aspeed AST2400 SoC.

Good idea.

Quoted 47 lines
---
  arch/arm/dts/Makefile              |   1 +
  arch/arm/dts/ast2400-palmetto.dts  | 102 +++++++++++++++++++++++++++++
  configs/ast2400-palmetto_defconfig |  74 +++++++++++++++++++++
  3 files changed, 177 insertions(+)

create mode 100644 arch/arm/dts/ast2400-palmetto.dts create mode 100644 configs/ast2400-palmetto_defconfig

arch/arm/dts/Makefile +1 -0
index 3515100c65ce..4faf29d747bd 100755
@@ -676,6 +676,7 @@ dtb-$(CONFIG_ARCH_BCM6858) += \
 
  dtb-$(CONFIG_ARCH_ASPEED) += \
         ast2400-evb.dtb \
+       ast2400-palmetto.dtb \
         ast2400-ahe-50dc.dtb \
         ast2500-evb.dtb \
         ast2600a0-evb.dtb \
arch/arm/dts/ast2400-palmetto.dts new file +18 -0
new file mode 100644
index 000000000000..a512f602d2f1
@@ -0,0 +1,102 @@
+// SPDX-License-Identifier: GPL-2.0+
+/dts-v1/;
+
+#include "ast2400-u-boot.dtsi"
+
+/ {
+       model = "Palmetto BMC";
+       compatible = "tyan,palmetto-bmc", "aspeed,ast2400";
+
+       memory@40000000 {
+               device_type = "memory";
+               reg = <0x40000000 0x10000000>;
+       };
+
+       chosen {
+               stdout-path = &uart5;
+               bootargs = "console=ttyS4,115200 earlyprintk";
+       };
Quoted 8 lines

arch/arm/dts/ast2400-palmetto.dts line 24

Quoted 6 lines
arch/arm/dts/ast2400-palmetto.dts new file +6 -0
+
+       aliases {
+               spi0 = &fmc;
+               spi1 = &spi1;
+               ethernet0 = &mac0;
+               ethernet1 = &mac1;

They only had one ethernet connection.

ah yes.

Quoted 37 lines
Quoted 37 lines
arch/arm/dts/ast2400-palmetto.dts new file +36 -0
+       };
+};
+
+&uart5 {
+       u-boot,dm-pre-reloc;
+       status = "okay";
+};
+
+&sdrammc {
+       clock-frequency = <200000000>;
+};
+
+&wdt1 {
+       u-boot,dm-pre-reloc;
+       status = "okay";
+};
+
+&wdt2 {
+       u-boot,dm-pre-reloc;
+       status = "okay";
+};
+
+&mac0 {
+       status = "okay";
+       phy-mode = "rgmii";
+
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_mac1link_default &pinctrl_mdio1_default>;
+};
+
+&mac1 {
+       status = "okay";
+       phy-mode = "rgmii";
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_mac2link_default &pinctrl_mdio2_default>;
+};
Quoted 8 lines

arch/arm/dts/ast2400-palmetto.dts line 66

Quoted 6 lines
arch/arm/dts/ast2400-palmetto.dts new file +6 -0
+
+
+&fmc {
+       status = "okay";
+       flash@0 {
+               compatible = "spi-flash", "sst,w25q256";

You just removed all of these :)

oops. I might have included the palmetto in the previous patch I sent :) I shouldn't keep patches for so long.

Quoted 16 lines
Quoted 16 lines
arch/arm/dts/ast2400-palmetto.dts new file +15 -0
+               status = "okay";
+               spi-max-frequency = <50000000>;
+               spi-tx-bus-width = <2>;
+               spi-rx-bus-width = <2>;
+       };
+
+       flash@1 {
+                compatible = "spi-flash", "sst,w25q256";
+                status = "okay";
+                spi-max-frequency = <50000000>;
+                spi-tx-bus-width = <2>;
+                spi-rx-bus-width = <2>;
+        };
+};
+
Quoted 8 lines

arch/arm/dts/ast2400-palmetto.dts line 87

Quoted 6 lines
arch/arm/dts/ast2400-palmetto.dts new file +6 -0
+&spi1 {
+       status = "okay";
+       flash@0 {
+               pinctrl-names = "default";
+               pinctrl-0 = <&pinctrl_spi1_default>;
+               compatible = "spi-flash", "sst,w25q256";

They only have one flash on each controller iirc.

yes.

Quoted 26 lines

configs/ast2400-palmetto_defconfig

Quoted 22 lines
arch/arm/dts/ast2400-palmetto.dts new file +15 -0
+               status = "okay";
+               spi-max-frequency = <50000000>;
+               spi-tx-bus-width = <2>;
+               spi-rx-bus-width = <2>;
+       };
+       flash@1 {
+               pinctrl-names = "default";
+               pinctrl-0 = <&pinctrl_spi1_default &pinctrl_spi1cs1_default>;
+               compatible = "spi-flash", "sst,w25q256";
+               status = "okay";
+               spi-max-frequency = <50000000>;
+               spi-tx-bus-width = <2>;
+               spi-rx-bus-width = <2>;
+       };
+};
configs/ast2400-palmetto_defconfig new file +0 -0
new file mode 100644
index 000000000000..8802323b4db8

Do we need a separate defconfig from the one for the evb? If not, can we adjust the evb defconfig to suit?

Quoted 2 lines

Hopefully we can just build it with DEVICE_TREE=ast2400-palmetto and an existing defconfig.

ok. I will give it a try on QEMU.

Thanks,

C.

Quoted 79 lines
Quoted 79 lines
configs/ast2400-palmetto_defconfig new file +74 -1
@@ -0,0 +1,74 @@
+CONFIG_ARM=y
+CONFIG_ARCH_ASPEED=y
+CONFIG_SYS_TEXT_BASE=0x0
+CONFIG_ASPEED_AST2400=y
+CONFIG_SYS_MALLOC_F_LEN=0x800
+CONFIG_ENV_SIZE=0x10000
+CONFIG_ENV_OFFSET=0xF0000
+CONFIG_NR_DRAM_BANKS=1
+CONFIG_FIT=y
+CONFIG_USE_BOOTARGS=y
+CONFIG_BOOTARGS="console=ttyS4,115200n8 root=/dev/ram rw"
+CONFIG_USE_BOOTCOMMAND=y
+CONFIG_BOOTCOMMAND="bootm 20080000"
+CONFIG_PRE_CONSOLE_BUFFER=y
+CONFIG_PRE_CON_BUF_ADDR=0x1e720000
+CONFIG_SYS_CONSOLE_ENV_OVERWRITE=y
+CONFIG_HUSH_PARSER=y
+# CONFIG_AUTO_COMPLETE is not set
+CONFIG_SYS_PROMPT="ast# "
+CONFIG_CMD_MEMTEST=y
+CONFIG_SYS_ALT_MEMTEST=y
+CONFIG_CMD_CLK=y
+CONFIG_CMD_GPIO=y
+CONFIG_CMD_I2C=y
+CONFIG_CMD_MMC=y
+CONFIG_CMD_SF=y
+CONFIG_CMD_DHCP=y
+CONFIG_CMD_MII=y
+CONFIG_CMD_PING=y
+CONFIG_DEFAULT_DEVICE_TREE="ast2400-palmetto"
+CONFIG_ENV_IS_IN_SPI_FLASH=y
+CONFIG_USE_ENV_SPI_BUS=y
+CONFIG_ENV_SPI_BUS=0
+CONFIG_USE_ENV_SPI_CS=y
+CONFIG_ENV_SPI_CS=0
+CONFIG_USE_ENV_SPI_MAX_HZ=y
+CONFIG_ENV_SPI_MAX_HZ=100000000
+CONFIG_NET_RANDOM_ETHADDR=y
+CONFIG_REGMAP=y
+CONFIG_CLK=y
+CONFIG_DM_GPIO=y
+CONFIG_ASPEED_GPIO=y
+CONFIG_DM_I2C=y
+CONFIG_SYS_I2C_ASPEED=y
+CONFIG_MISC=y
+CONFIG_DM_MMC=y
+# CONFIG_MMC_HW_PARTITIONING is not set
+CONFIG_MMC_SDHCI=y
+CONFIG_MMC_SDHCI_ASPEED=y
+CONFIG_DM_SPI_FLASH=y
+CONFIG_SPI_FLASH=y
+CONFIG_SPI_FLASH_GIGADEVICE=y
+CONFIG_SPI_FLASH_MACRONIX=y
+CONFIG_SPI_FLASH_SPANSION=y
+CONFIG_SPI_FLASH_STMICRO=y
+CONFIG_SPI_FLASH_WINBOND=y
+CONFIG_PHY_REALTEK=y
+CONFIG_PHY_NCSI=y
+CONFIG_DM_ETH=y
+CONFIG_PHY_GIGE=y
+CONFIG_FTGMAC100=y
+CONFIG_PHY=y
+CONFIG_PINCTRL=y
+CONFIG_RAM=y
+CONFIG_DM_SERIAL=y
+CONFIG_SYS_NS16550=y
+CONFIG_SPI=y
+CONFIG_DM_SPI=y
+CONFIG_SYSRESET=y
+CONFIG_TIMER=y
+CONFIG_WDT=y
+CONFIG_DM_RESET=y
+# CONFIG_CMD_BOOTEFI is not set
+# CONFIG_EFI_LOADER is not set
--

2.35.3