Skip to contentSkip to conversation

drm/mgag200: Include <linux/vmalloc.h> for G200 BIOS code

PATCH In review Thomas Zimmermann 2 participants 2 messages Jun 8, 2022

Subsystems (3)
lore
Share & tools
lore

Thomas Zimmermann

author maintainer
#0 lore raw

PATCH 1/1 drm/mgag200: Include <linux/vmalloc.h> for G200 BIOS code

After moving the vmalloc() call to another file, the rsp include statement needs to be moved as well. Resolves a build warning on parisc.

drivers/gpu/drm/mgag200/mgag200_g200.c: In function

	'mgag200_g200_init_refclk':

drivers/gpu/drm/mgag200/mgag200_g200.c:120:16: error: implicit
declaration of function 'vmalloc'; did you mean 'kvmalloc'? [-Werror=implicit-function-declaration]

Fixes 85397f6bc4ff ("drm/mgag200: Initialize each model in separate function")
Cc Thomas Zimmermann <[email protected]>
Cc Jocelyn Falempe <[email protected]>
Cc Dave Airlie <[email protected]>
---
 drivers/gpu/drm/mgag200/mgag200_drv.c  | 1 -
 drivers/gpu/drm/mgag200/mgag200_g200.c | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/mgag200/mgag200_drv.c +0 -1
index 361eb7dffda1..73e8e4e9e54b 100644
@@ -8,7 +8,6 @@
 
 #include <linux/module.h>
 #include <linux/pci.h>
-#include <linux/vmalloc.h>
 
 #include <drm/drm_aperture.h>
 #include <drm/drm_drv.h>
drivers/gpu/drm/mgag200/mgag200_g200.c +1 -0
index 616e11391e02..674385921b7f 100644
@@ -1,6 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0-only
 
 #include <linux/pci.h>
+#include <linux/vmalloc.h>
 
 #include <drm/drm_drv.h>
 
Signature · 1 line
2.36.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Thomas Zimmermann

After moving the vmalloc() call to another file, the rsp include statement needs to be moved as well. Resolves a build warning on parisc.

drivers/gpu/drm/mgag200/mgag200_g200.c: In function

	'mgag200_g200_init_refclk':

drivers/gpu/drm/mgag200/mgag200_g200.c:120:16: error: implicit
declaration of function 'vmalloc'; did you mean 'kvmalloc'? [-Werror=implicit-function-declaration]

Quoted 8 lines
Fixes 85397f6bc4ff ("drm/mgag200: Initialize each model in separate function")
Cc Thomas Zimmermann <[email protected]>
Cc Jocelyn Falempe <[email protected]>
Cc Dave Airlie <[email protected]>
Quoted 32 lines
---
 drivers/gpu/drm/mgag200/mgag200_drv.c  | 1 -
 drivers/gpu/drm/mgag200/mgag200_g200.c | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/mgag200/mgag200_drv.c +0 -1
index 361eb7dffda1..73e8e4e9e54b 100644
@@ -8,7 +8,6 @@
 
 #include <linux/module.h>
 #include <linux/pci.h>
-#include <linux/vmalloc.h>
 
 #include <drm/drm_aperture.h>
 #include <drm/drm_drv.h>
drivers/gpu/drm/mgag200/mgag200_g200.c +1 -0
index 616e11391e02..674385921b7f 100644
@@ -1,6 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0-only
 
 #include <linux/pci.h>
+#include <linux/vmalloc.h>
 
 #include <drm/drm_drv.h>
 
Signature · 1 line
2.36.1
Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch