Skip to contentSkip to conversation

staging: greybus: audio: replace safe list iteration

PATCH New Johan Hovold 1 participant 1 message Jun 10, 2022

Subsystems (2)
Staging Greybus
lore
Share & tools
lore

Johan Hovold

author maintainer
#0 lore raw

PATCH 1/1 staging: greybus: audio: replace safe list iteration

No entry is being removed from the list when iterating the widget list in gbaudio_dapm_free_controls() so there's no need to use list_for_each_entry_safe().

Signed-off-by Johan Hovold <[email protected]>
---
 drivers/staging/greybus/audio_helper.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/staging/greybus/audio_helper.c +2 -3
index 07461a5d97c7..05e91e6bc2a0 100644
@@ -115,7 +115,7 @@ int gbaudio_dapm_free_controls(struct snd_soc_dapm_context *dapm,
 			       int num)
 {
 	int i;
-	struct snd_soc_dapm_widget *w, *next_w, *tmp_w;
+	struct snd_soc_dapm_widget *w, *tmp_w;
 #ifdef CONFIG_DEBUG_FS
 	struct dentry *parent = dapm->debugfs_dapm;
 	struct dentry *debugfs_w = NULL;

@@ -125,8 +125,7 @@ int gbaudio_dapm_free_controls(struct snd_soc_dapm_context *dapm,
 	for (i = 0; i < num; i++) {
 		/* below logic can be optimized to identify widget pointer */
 		w = NULL;
-		list_for_each_entry_safe(tmp_w, next_w, &dapm->card->widgets,
-					 list) {
+		list_for_each_entry(tmp_w, &dapm->card->widgets, list) {
 			if (tmp_w->dapm == dapm &&
 			    !strcmp(tmp_w->name, widget->name)) {
 				w = tmp_w;
Signature · 1 line
2.35.1