Skip to contentSkip to conversation

MAINTAINERS: add MEMORY HOT(UN)PLUG section and add myself as reviewer

PATCH In review David Hildenbrand 6 participants 12 messages Jun 10, 2022 – Jun 15, 2022 Memory management

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MAINTAINERS: add MEMORY HOT(UN)PLUG section and add myself as reviewer

There are certainly a lot more files that partially fall into the memory hot(un)plug category, including parts of mm/sparse.c, mm/page_isolation.c and mm/page_alloc.c. Let's only add what's almost completely memory hot(un)plug related.

Add myself as reviewer so it's easier for contributors to figure out whom to CC.

---
 MAINTAINERS | 12 ++++++++++++
 1 file changed, 12 insertions(+)
MAINTAINERS +12 -0
index a6d3bd9d2a8d..77aebce76288 100644
@@ -12848,6 +12848,18 @@ F:	include/linux/vmalloc.h
 F:	mm/
 F:	tools/testing/selftests/vm/
 
+MEMORY HOT(UN)PLUG
+M:	Andrew Morton <[email protected]>
+R:	David Hildenbrand <[email protected]>
+L:	[email protected]
+S:	Maintained
+F:	Documentation/admin-guide/mm/memory-hotplug.rst
+F:	Documentation/core-api/memory-hotplug.rst
+F:	drivers/base/memory.c
+F:	include/linux/memory_hotplug.h
+F:	mm/memory_hotplug.c
+F:	tools/testing/selftests/memory-hotplug/
+
 MEMORY TECHNOLOGY DEVICES (MTD)
 M:	Miquel Raynal <[email protected]>
 M:	Richard Weinberger <[email protected]>
Signature · 1 line
2.35.3
#1 lore raw
Quoted 7 lines · David Hildenbrand

There are certainly a lot more files that partially fall into the memory hot(un)plug category, including parts of mm/sparse.c, mm/page_isolation.c and mm/page_alloc.c. Let's only add what's almost completely memory hot(un)plug related.

Add myself as reviewer so it's easier for contributors to figure out whom to CC.

This really helps. Thanks! :)

Quoted 30 lines
---
 MAINTAINERS | 12 ++++++++++++
 1 file changed, 12 insertions(+)
MAINTAINERS +12 -0
index a6d3bd9d2a8d..77aebce76288 100644
@@ -12848,6 +12848,18 @@ F:	include/linux/vmalloc.h
 F:	mm/
 F:	tools/testing/selftests/vm/
 
+MEMORY HOT(UN)PLUG
+M:	Andrew Morton <[email protected]>
+R:	David Hildenbrand <[email protected]>
+L:	[email protected]
+S:	Maintained
+F:	Documentation/admin-guide/mm/memory-hotplug.rst
+F:	Documentation/core-api/memory-hotplug.rst
+F:	drivers/base/memory.c
+F:	include/linux/memory_hotplug.h
+F:	mm/memory_hotplug.c
+F:	tools/testing/selftests/memory-hotplug/
+
 MEMORY TECHNOLOGY DEVICES (MTD)
 M:	Miquel Raynal <[email protected]>
 M:	Richard Weinberger <[email protected]>
Acked-by on v1 1/1
#2 lore raw
In reply to David Hildenbrand
Quoted 9 lines · David Hildenbrand

There are certainly a lot more files that partially fall into the memory hot(un)plug category, including parts of mm/sparse.c, mm/page_isolation.c and mm/page_alloc.c. Let's only add what's almost completely memory hot(un)plug related.

Add myself as reviewer so it's easier for contributors to figure out whom to CC.

You are really awesome. Thank for your work on this.

#3 lore raw
In reply to David Hildenbrand
Quoted 22 lines · David Hildenbrand

There are certainly a lot more files that partially fall into the memory hot(un)plug category, including parts of mm/sparse.c, mm/page_isolation.c and mm/page_alloc.c. Let's only add what's almost completely memory hot(un)plug related.

Add myself as reviewer so it's easier for contributors to figure out whom to CC.

---
 MAINTAINERS | 12 ++++++++++++
 1 file changed, 12 insertions(+)
MAINTAINERS +1 -0
index a6d3bd9d2a8d..77aebce76288 100644
@@ -12848,6 +12848,18 @@ F:	include/linux/vmalloc.h
 F:	mm/
 F:	tools/testing/selftests/vm/
 
+MEMORY HOT(UN)PLUG

MAINTAINERS F: include/linux/vmalloc.h · line 12861

Quoted 10 lines
MAINTAINERS +10 -0
+M:	Andrew Morton <[email protected]>
+R:	David Hildenbrand <[email protected]>
+L:	[email protected]
+S:	Maintained
+F:	Documentation/admin-guide/mm/memory-hotplug.rst
+F:	Documentation/core-api/memory-hotplug.rst
+F:	drivers/base/memory.c
+F:	include/linux/memory_hotplug.h
+F:	mm/memory_hotplug.c
+F:	tools/testing/selftests/memory-hotplug/

(thanks for the kind words from reviewers :) )

Thinking about it (and remembering having a discussion about submaintainers for MM in general at LSF/MM):

@Andrew, do we want "official" submaintainers for that section? If so, we could turn my R into an M. Further, Oscar did a lot of work in the memory hot(un)plug world as well -- so if we want submaintainers, Oscar might be a very good fit as well.

... I guess, that would mostly reflect reality :)

Signature · 3 lines
Thanks,

David / dhildenb
#4 lore raw
Quoted 9 lines · David Hildenbrand

(thanks for the kind words from reviewers :) )

Thinking about it (and remembering having a discussion about submaintainers for MM in general at LSF/MM):

@Andrew, do we want "official" submaintainers for that section? If so, we could turn my R into an M. Further, Oscar did a lot of work in the memory hot(un)plug world as well -- so if we want submaintainers, Oscar might be a very good fit as well.

I would be glad to take on such role, officially, alongside David, and I think this can benefit this area.

Signature · 2 lines
Oscar Salvador
SUSE Labs
maintainer
#5 lore raw
In reply to David Hildenbrand
Quoted 39 lines · On Tue, 14 Jun 2022 08:58:55 +0200 David Hildenbrand <[email protected]> wrote:
Quoted 22 lines · David Hildenbrand

There are certainly a lot more files that partially fall into the memory hot(un)plug category, including parts of mm/sparse.c, mm/page_isolation.c and mm/page_alloc.c. Let's only add what's almost completely memory hot(un)plug related.

Add myself as reviewer so it's easier for contributors to figure out whom to CC.

---
 MAINTAINERS | 12 ++++++++++++
 1 file changed, 12 insertions(+)
MAINTAINERS +1 -0
index a6d3bd9d2a8d..77aebce76288 100644
@@ -12848,6 +12848,18 @@ F:	include/linux/vmalloc.h
 F:	mm/
 F:	tools/testing/selftests/vm/
 
+MEMORY HOT(UN)PLUG

MAINTAINERS F: include/linux/vmalloc.h · line 12861

Quoted 10 lines
MAINTAINERS +10 -0
+M:	Andrew Morton <[email protected]>
+R:	David Hildenbrand <[email protected]>
+L:	[email protected]
+S:	Maintained
+F:	Documentation/admin-guide/mm/memory-hotplug.rst
+F:	Documentation/core-api/memory-hotplug.rst
+F:	drivers/base/memory.c
+F:	include/linux/memory_hotplug.h
+F:	mm/memory_hotplug.c
+F:	tools/testing/selftests/memory-hotplug/

(thanks for the kind words from reviewers :) )

Thinking about it (and remembering having a discussion about submaintainers for MM in general at LSF/MM):

Quoted 6 lines

@Andrew, do we want "official" submaintainers for that section? If so, we could turn my R into an M. Further, Oscar did a lot of work in the memory hot(un)plug world as well -- so if we want submaintainers, Oscar might be a very good fit as well.

... I guess, that would mostly reflect reality :)

um, fine, no opinion really. I think the main thing is to make get_maintainer.pl spit out all the suitable email addresses.

#6 lore raw
Quoted 3 lines · Andrew Morton

On Tue, 14 Jun 2022 08:58:55 +0200 David Hildenbrand <[email protected]> wrote:
um, fine, no opinion really. I think the main thing is to make get_maintainer.pl spit out all the suitable email addresses.

As already pointed out, David and I have already kind of acted as maintainers of this aready already for quite some time, reviewing and contributing the most, so it might make sense to just spell that out, so, without willing to step on anyone's toes, what about this:

MAINTAINERS +11 -0
index 1fc9ead83d2a..f5a746624a9f 100644
@@ -12857,6 +12857,18 @@ F:     include/linux/vmalloc.h
 F:     mm/
 F:     tools/testing/selftests/vm/
 
+MEMORY HOT(UN)PLUG
+M:     David Hildenbrand <[email protected]>
+M:     Oscar Salvador <[email protected]>
+L:     [email protected]
+S:     Maintained
+F:     Documentation/admin-guide/mm/memory-hotplug.rst
+F:     Documentation/core-api/memory-hotplug.rst
+F:     drivers/base/memory.c
+F:     include/linux/memory_hotplug.h
+F:     mm/memory_hotplug.c
+F:     tools/testing/selftests/memory-hotplug/
 

Thanks

Signature · 2 lines
Oscar Salvador
SUSE Labs
author Acked-by
#7 lore raw
Quoted 19 lines · Oscar Salvador
Quoted 3 lines · Andrew Morton

On Tue, 14 Jun 2022 08:58:55 +0200 David Hildenbrand <[email protected]> wrote:
um, fine, no opinion really. I think the main thing is to make get_maintainer.pl spit out all the suitable email addresses.

As already pointed out, David and I have already kind of acted as maintainers of this aready already for quite some time, reviewing and contributing the most, so it might make sense to just spell that out, so, without willing to step on anyone's toes, what about this:

MAINTAINERS +1 -0
index 1fc9ead83d2a..f5a746624a9f 100644
@@ -12857,6 +12857,18 @@ F:     include/linux/vmalloc.h
 F:     mm/
 F:     tools/testing/selftests/vm/
 
+MEMORY HOT(UN)PLUG

MAINTAINERS F: include/linux/vmalloc.h · line 12870

Quoted 10 lines
MAINTAINERS +10 -0
+M:     David Hildenbrand <[email protected]>
+M:     Oscar Salvador <[email protected]>
+L:     [email protected]
+S:     Maintained
+F:     Documentation/admin-guide/mm/memory-hotplug.rst
+F:     Documentation/core-api/memory-hotplug.rst
+F:     drivers/base/memory.c
+F:     include/linux/memory_hotplug.h
+F:     mm/memory_hotplug.c
+F:     tools/testing/selftests/memory-hotplug/

Fine with me to remove Andrew from that list because he's implicitly covering most stuff via the "MEMORY MANAGEMENT" section.

@Andrew, whatever you prefer.

@Andrew, would it make sense to update the git tree in the "MEMORY MANAGEMENT" section now that mm-stable etc. resides on git.kernel.org ?

Signature · 3 lines
Thanks,

David / dhildenb
maintainer
#8 lore raw
Quoted 2 lines · On Wed, 15 Jun 2022 11:15:30 +0200 David Hildenbrand <[email protected]> wrote:

@Andrew, would it make sense to update the git tree in the "MEMORY MANAGEMENT" section now that mm-stable etc. resides on git.kernel.org ?

Thanks, didn't know we had a MAINTAINERS entry ;)

From: Andrew Morton <[email protected]>
Subject: MAINTAINERS: update tree references
Date: Wed Jun 15 02:22:44 PM PDT 2022

Describe the new kernel.org location of the MM trees.

Cc Muchun Song <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
Cc Miaohe Lin <[email protected]>

---

 MAINTAINERS |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
MAINTAINERS renamed from MAINTAINERS~maintainers-update-tree-references +2 -3
@@ -12846,9 +12846,8 @@ M:	Andrew Morton <akpm@linux-foundation.
 L:	[email protected]
 S:	Maintained
 W:	http://www.linux-mm.org
-T:	quilt https://ozlabs.org/~akpm/mmotm/
-T:	quilt https://ozlabs.org/~akpm/mmots/
-T:	git git://github.com/hnaz/linux-mm.git
+T:	git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
+T:	quilt git://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new
 F:	include/linux/gfp.h
 F:	include/linux/memory_hotplug.h
 F:	include/linux/mm.h

_

Acked-by on v1 1/1
#9 lore raw
In reply to David Hildenbrand
Quoted 22 lines · David Hildenbrand

There are certainly a lot more files that partially fall into the memory hot(un)plug category, including parts of mm/sparse.c, mm/page_isolation.c and mm/page_alloc.c. Let's only add what's almost completely memory hot(un)plug related.

Add myself as reviewer so it's easier for contributors to figure out whom to CC.

---
 MAINTAINERS | 12 ++++++++++++
 1 file changed, 12 insertions(+)
MAINTAINERS +1 -0
index a6d3bd9d2a8d..77aebce76288 100644
@@ -12848,6 +12848,18 @@ F:	include/linux/vmalloc.h
 F:	mm/
 F:	tools/testing/selftests/vm/
 
+MEMORY HOT(UN)PLUG

MAINTAINERS F: include/linux/vmalloc.h · line 12861

Quoted 10 lines
MAINTAINERS +10 -0
+M:	Andrew Morton <[email protected]>
+R:	David Hildenbrand <[email protected]>
+L:	[email protected]
+S:	Maintained
+F:	Documentation/admin-guide/mm/memory-hotplug.rst
+F:	Documentation/core-api/memory-hotplug.rst
+F:	drivers/base/memory.c
+F:	include/linux/memory_hotplug.h
+F:	mm/memory_hotplug.c
+F:	tools/testing/selftests/memory-hotplug/

One question, will patches from you go through my driver core tree, or the -mm tree? Either is fine for me, just curious.

thanks,

greg k-h

#10 lore raw
Quoted 36 lines · Greg Kroah-Hartman
Quoted 22 lines · David Hildenbrand

There are certainly a lot more files that partially fall into the memory hot(un)plug category, including parts of mm/sparse.c, mm/page_isolation.c and mm/page_alloc.c. Let's only add what's almost completely memory hot(un)plug related.

Add myself as reviewer so it's easier for contributors to figure out whom to CC.

---
 MAINTAINERS | 12 ++++++++++++
 1 file changed, 12 insertions(+)
MAINTAINERS +1 -0
index a6d3bd9d2a8d..77aebce76288 100644
@@ -12848,6 +12848,18 @@ F:	include/linux/vmalloc.h
 F:	mm/
 F:	tools/testing/selftests/vm/
 
+MEMORY HOT(UN)PLUG

MAINTAINERS F: include/linux/vmalloc.h · line 12861

Quoted 10 lines
MAINTAINERS +10 -0
+M:	Andrew Morton <[email protected]>
+R:	David Hildenbrand <[email protected]>
+L:	[email protected]
+S:	Maintained
+F:	Documentation/admin-guide/mm/memory-hotplug.rst
+F:	Documentation/core-api/memory-hotplug.rst
+F:	drivers/base/memory.c
+F:	include/linux/memory_hotplug.h
+F:	mm/memory_hotplug.c
+F:	tools/testing/selftests/memory-hotplug/
Quoted 2 lines

One question, will patches from you go through my driver core tree, or the -mm tree? Either is fine for me, just curious.

In the past, most stuff regarding drivers/base/memory.c went through -mm, so I'd say we keep it like that, unless it's really generic changes to the driver model etc.

Signature · 3 lines
Thanks,

David / dhildenb
#11 lore raw
Quoted 37 lines · David Hildenbrand
Quoted 36 lines · Greg Kroah-Hartman
Quoted 22 lines · David Hildenbrand

There are certainly a lot more files that partially fall into the memory hot(un)plug category, including parts of mm/sparse.c, mm/page_isolation.c and mm/page_alloc.c. Let's only add what's almost completely memory hot(un)plug related.

Add myself as reviewer so it's easier for contributors to figure out whom to CC.

---
 MAINTAINERS | 12 ++++++++++++
 1 file changed, 12 insertions(+)
MAINTAINERS +1 -0
index a6d3bd9d2a8d..77aebce76288 100644
@@ -12848,6 +12848,18 @@ F:	include/linux/vmalloc.h
 F:	mm/
 F:	tools/testing/selftests/vm/
 
+MEMORY HOT(UN)PLUG

MAINTAINERS F: include/linux/vmalloc.h · line 12861

Quoted 10 lines
MAINTAINERS +10 -0
+M:	Andrew Morton <[email protected]>
+R:	David Hildenbrand <[email protected]>
+L:	[email protected]
+S:	Maintained
+F:	Documentation/admin-guide/mm/memory-hotplug.rst
+F:	Documentation/core-api/memory-hotplug.rst
+F:	drivers/base/memory.c
+F:	include/linux/memory_hotplug.h
+F:	mm/memory_hotplug.c
+F:	tools/testing/selftests/memory-hotplug/
Quoted 6 lines
Quoted 2 lines

One question, will patches from you go through my driver core tree, or the -mm tree? Either is fine for me, just curious.

In the past, most stuff regarding drivers/base/memory.c went through -mm, so I'd say we keep it like that, unless it's really generic changes to the driver model etc.

Sounds great to me, thanks for taking this on, much appreciated!

greg k-h