PCI: qcom: Fix pipe clock imbalance
Subsystems (3)
PATCH 1/1 PCI: qcom: Fix pipe clock imbalance
commit fdf6a2f533115ec5d4d9629178f8196331f1ac50 upstream.
Fix a clock imbalance introduced by ed8cc3b1fc84 ("PCI: qcom: Add support for SDM845 PCIe controller"), which enables the pipe clock both in init() and in post_init() but only disables in post_deinit().
Note that the pipe clock was also never disabled in the init() error paths and that enabling the clock before powering up the PHY looks questionable.
Fixes ed8cc3b1fc84 ("PCI: qcom: Add support for SDM845 PCIe controller")
Signed-off-by Johan Hovold <[email protected]>
Signed-off-by Lorenzo Pieralisi <[email protected]>
Signed-off-by Bjorn Helgaas <[email protected]>
Reviewed-by Bjorn Andersson <[email protected]>
Cc [email protected] # 5.6
[ johan: adjust context for 5.17 ]
Signed-off-by Johan Hovold <[email protected]>
--- drivers/pci/controller/dwc/pcie-qcom.c | 6 ------ 1 file changed, 6 deletions(-)
drivers/pci/controller/dwc/pcie-qcom.c +0 -6
@@ -1230,12 +1230,6 @@ static int qcom_pcie_init_2_7_0(struct qcom_pcie *pcie) goto err_disable_clocks; } - ret =clk_prepare_enable (res->pipe_clk); -if (ret) { -dev_err (dev,"cannot prepare/enable pipe clock\n" ); - goto err_disable_clocks; - } -/* configure PCIe to RC mode */ writel (DEVICE_TYPE_RC , pcie->parf +PCIE20_PARF_DEVICE_TYPE );
Signature · 1 line
2.35.1