Skip to contentSkip to conversation

hwmon: (dell-smm) Add Dell XPS 13 7390 to fan control whitelist

PATCH Applied Armin Wolf 3 participants 3 messages Jun 12, 2022

Subsystems (2)
lore
Share & tools
lore

Armin Wolf

author
#0 lore raw

PATCH 1/1 hwmon: (dell-smm) Add Dell XPS 13 7390 to fan control whitelist

A user reported that the program dell-bios-fan-control worked on his Dell XPS 13 7390 to switch off automatic fan control.
Since it uses the same mechanism as the dell_smm_hwmon module, add this model to the fan control whitelist.

Compile-tested only.

---
 drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/hwmon/dell-smm-hwmon.c +8 -0
index 071aa6f4e109..16c10ac84a91 100644
@@ -1365,6 +1365,14 @@ static const struct dmi_system_id i8k_whitelist_fan_control[] __initconst = {
 		},
 		.driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
 	},
+	{
+		.ident = "Dell XPS 13 7390",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS 13 7390"),
+		},
+		.driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
+	},
 	{ }
 };
 

--
2.30.2

maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · On Sunday 12 June 2022 06:18:06 Armin Wolf wrote:

A user reported that the program dell-bios-fan-control worked on his Dell XPS 13 7390 to switch off automatic fan control.
Since it uses the same mechanism as the dell_smm_hwmon module, add this model to the fan control whitelist.

Compile-tested only.

Quoted 26 lines
---
 drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/hwmon/dell-smm-hwmon.c +8 -1
index 071aa6f4e109..16c10ac84a91 100644
@@ -1365,6 +1365,14 @@ static const struct dmi_system_id i8k_whitelist_fan_control[] __initconst = {
 		},
 		.driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
 	},
+	{
+		.ident = "Dell XPS 13 7390",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS 13 7390"),
+		},
+		.driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
+	},
 	{ }
 };
 
--

2.30.2

maintainer Applied
#2 lore raw
In reply to Armin Wolf
Quoted 10 lines · Armin Wolf

A user reported that the program dell-bios-fan-control worked on his Dell XPS 13 7390 to switch off automatic fan control.
Since it uses the same mechanism as the dell_smm_hwmon module, add this model to the fan control whitelist.

Compile-tested only.

Applied to hwmon-next.

Thanks,
Guenter

Quoted 25 lines
---
 drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
 1 file changed, 8 insertions(+)

--
2.30.2

drivers/hwmon/dell-smm-hwmon.c +8 -0
index 071aa6f4e109..16c10ac84a91 100644
@@ -1365,6 +1365,14 @@ static const struct dmi_system_id i8k_whitelist_fan_control[] __initconst = {
 		},
 		.driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
 	},
+	{
+		.ident = "Dell XPS 13 7390",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS 13 7390"),
+		},
+		.driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
+	},
 	{ }
 };