Skip to contentSkip to conversation

drm: logicvc: Add missing of_node_put() in logicvc_drm_config_parse()

PATCH New Peng Wu 1 participant 1 message Jun 14, 2022

Subsystems (3)
lore
Share & tools
lore

Peng Wu

author
#0 lore raw

PATCH 1/1 drm: logicvc: Add missing of_node_put() in logicvc_drm_config_parse()

of_get_child_by_name() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak.

---
 drivers/gpu/drm/logicvc/logicvc_drm.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/logicvc/logicvc_drm.c +2 -0
index df1805cf0f95..73d51a8b693e 100644
@@ -136,8 +136,10 @@ static int logicvc_drm_config_parse(struct logicvc_drm *logicvc)
 	if (!config->layers_count) {
 		drm_err(drm_dev,
 			"Missing a non-optional layers children node\n");
+		of_node_put(layers_node);
 		return -EINVAL;
 	}
+	of_node_put(layers_node);
 
 	return 0;
 }
Signature · 1 line
2.17.1