Skip to contentSkip to conversation

block: update comment for blkcg_init_queue

PATCH In review Guoqing Jiang 2 participants 3 messages Jun 14, 2022 – Jun 15, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 block: update comment for blkcg_init_queue

It was called from __alloc_disk_node since commit 1059699f87eb ("block:
move blkcg initialization/destroy into disk allocation/release handler). Let's change the comment accordingly.

---
 block/blk-cgroup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
block/blk-cgroup.c +1 -1
index 764e740b0c0f..48ea9919e3ce 100644
@@ -1256,7 +1256,7 @@ static int blkcg_css_online(struct cgroup_subsys_state *css)
  * blkcg_init_queue - initialize blkcg part of request queue
  * @q: request_queue to initialize
  *
- * Called from blk_alloc_queue(). Responsible for initializing blkcg
+ * Called from __alloc_disk_node(). Responsible for initializing blkcg
  * part of new request_queue @q.
  *
  * RETURNS:
Signature · 1 line
2.31.1
#1 lore raw
Quoted 3 lines · Guoqing Jiang

It was called from __alloc_disk_node since commit 1059699f87eb ("block:
move blkcg initialization/destroy into disk allocation/release handler). Let's change the comment accordingly.

Well, the right things is to simply drop this comment. I do have a large series toucing it and removing it, so maybe we can wait until that?

#2 lore raw
Quoted 7 lines · Christoph Hellwig
Quoted 3 lines · Guoqing Jiang

It was called from __alloc_disk_node since commit 1059699f87eb ("block:
move blkcg initialization/destroy into disk allocation/release handler). Let's change the comment accordingly.

Well, the right things is to simply drop this comment. I do have a large series toucing it and removing it, so maybe we can wait until that?

Sure, I am fine with it.

Thanks,
Guoqing