package/wolftpm: Add TPM 2.0 extra options and fix one bad typo
PATCH 1/1 package/wolftpm: Add TPM 2.0 extra options and fix one bad typo
From: Dimitar Tomov <[email protected]>
--- package/wolftpm/Config.in | 14 +++++++++++++- package/wolftpm/wolftpm.mk | 12 ++++++++++++ 2 files changed, 25 insertions(+), 1 deletion(-)
package/wolftpm/Config.in +13 -1
@@ -19,10 +19,22 @@ config BR2_PACKAGE_WOLFTPM_WOLFCRYPT # not mandatory, but needed to get all features select BR2_PACKAGE_WOLFSSL_ALL help - Enable wolfCrypt hooks for RNG, Auth Sessions and Parameter + Enable wolfCrypt hooks for Authorization Sessions and Parameter encryption. Disabling this option is not recommended as it could create a security breach in most environments. +config BR2_PACKAGE_WOLFTPM_ST33 + bool "st33" + default n + help + Enable support of TPM 2.0 extra functionality offered by the STMicroelectronics ST33 chip. + +config BR2_PACKAGE_WOLFTPM_NUVOTON + bool "npct750" + default n + help + Enable support of TPM 2.0 extra functionality offered by the Nuvoton NPCT750 chip. + comment "wolfCrypt hooks need a toolchain w/ threads, dynamic library" depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
package/wolftpm/wolftpm.mk +12 -0
@@ -35,4 +35,16 @@ else WOLFTPM_CONF_OPTS += --disable-wolfcrypt endif +ifeq ($(BR2_PACKAGE_WOLFTPM_ST33),y) +WOLFTPM_CONF_OPTS += --enable-st33 +else +WOLFTPM_CONF_OPTS += --disable-st33 +endif + +ifeq ($(BR2_PACKAGE_WOLFTPM_NPCT750),y) +WOLFTPM_CONF_OPTS += --enable-nuvoton +else +WOLFTPM_CONF_OPTS += --disable-nuvoton +endif + $(eval $(autotools-package))
Signature · 6 lines
2.27.0 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
PATCH v2 1/1 package/wolftpm: Add TPM 2.0 extra options and fix one bad typo
From: Dimitar Tomov <[email protected]>
--- package/wolftpm/Config.in | 12 ++++++++++++ package/wolftpm/wolftpm.mk | 12 ++++++++++++ 2 files changed, 24 insertions(+)
package/wolftpm/Config.in +12 -0
@@ -23,6 +23,18 @@ config BR2_PACKAGE_WOLFTPM_WOLFCRYPT encryption. Disabling this option is not recommended as it could create a security breach in most environments. +config BR2_PACKAGE_WOLFTPM_ST33 + bool "st33" + default n + help + Enable support of TPM 2.0 extra functionality offered by the STMicroelectronics ST33 chip. + +config BR2_PACKAGE_WOLFTPM_NUVOTON + bool "npct750" + default n + help + Enable support of TPM 2.0 extra functionality offered by the Nuvoton NPCT750 chip. + comment "wolfCrypt hooks need a toolchain w/ threads, dynamic library" depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
package/wolftpm/wolftpm.mk +12 -0
@@ -35,4 +35,16 @@ else WOLFTPM_CONF_OPTS += --disable-wolfcrypt endif +ifeq ($(BR2_PACKAGE_WOLFTPM_ST33),y) +WOLFTPM_CONF_OPTS += --enable-st33 +else +WOLFTPM_CONF_OPTS += --disable-st33 +endif + +ifeq ($(BR2_PACKAGE_WOLFTPM_NPCT750),y) +WOLFTPM_CONF_OPTS += --enable-nuvoton +else +WOLFTPM_CONF_OPTS += --disable-nuvoton +endif + $(eval $(autotools-package))
Signature · 6 lines
2.27.0 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
PATCH v3 1/1 package/wolftpm: Add config options for TPM 2.0 extra capabilities
From: Dimitar Tomov <[email protected]>
---
Changes v2 -> v3:
- Better commit message
Changes v1 -> v2:
- Remove a not needed package description change
--- package/wolftpm/Config.in | 12 ++++++++++++ package/wolftpm/wolftpm.mk | 12 ++++++++++++ 2 files changed, 24 insertions(+)
package/wolftpm/Config.in +12 -0
@@ -23,6 +23,18 @@ config BR2_PACKAGE_WOLFTPM_WOLFCRYPT encryption. Disabling this option is not recommended as it could create a security breach in most environments. +config BR2_PACKAGE_WOLFTPM_ST33 + bool "st33" + default n + help + Enable support of TPM 2.0 extra functionality offered by the STMicroelectronics ST33 chip. + +config BR2_PACKAGE_WOLFTPM_NUVOTON + bool "npct750" + default n + help + Enable support of TPM 2.0 extra functionality offered by the Nuvoton NPCT750 chip. + comment "wolfCrypt hooks need a toolchain w/ threads, dynamic library" depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
package/wolftpm/wolftpm.mk +12 -0
@@ -35,4 +35,16 @@ else WOLFTPM_CONF_OPTS += --disable-wolfcrypt endif +ifeq ($(BR2_PACKAGE_WOLFTPM_ST33),y) +WOLFTPM_CONF_OPTS += --enable-st33 +else +WOLFTPM_CONF_OPTS += --disable-st33 +endif + +ifeq ($(BR2_PACKAGE_WOLFTPM_NPCT750),y) +WOLFTPM_CONF_OPTS += --enable-nuvoton +else +WOLFTPM_CONF_OPTS += --disable-nuvoton +endif + $(eval $(autotools-package))
Signature · 6 lines
2.27.0 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
PATCH v4 1/1 package/wolftpm: Add config options for TPM 2.0 extra capabilities
From: Dimitar Tomov <[email protected]>
Some TPM 2.0 chips offer extra capabilities. This patch adds additional configuration options to the wolftpm package, so such capabilities can be available to the user. For example, the STMicroelectronics ST33 and Nuvoton NPCT750 both offer secure GPIO. Due to chip differences, wolfTPM requires explicit configuration options to enable the extra capabilities.
---
Changes v3 -> v4:
- Fix commit message. For some reason the update was not included in patch v3. Changes v2 -> v3:
- Better commit message
Changes v1 -> v2:
- Remove a not needed package description change
--- package/wolftpm/Config.in | 12 ++++++++++++ package/wolftpm/wolftpm.mk | 12 ++++++++++++ 2 files changed, 24 insertions(+)
package/wolftpm/Config.in +12 -0
@@ -23,6 +23,18 @@ config BR2_PACKAGE_WOLFTPM_WOLFCRYPT encryption. Disabling this option is not recommended as it could create a security breach in most environments. +config BR2_PACKAGE_WOLFTPM_ST33 + bool "st33" + default n + help + Enable support of TPM 2.0 extra functionality offered by the STMicroelectronics ST33 chip. + +config BR2_PACKAGE_WOLFTPM_NUVOTON + bool "npct750" + default n + help + Enable support of TPM 2.0 extra functionality offered by the Nuvoton NPCT750 chip. + comment "wolfCrypt hooks need a toolchain w/ threads, dynamic library" depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
package/wolftpm/wolftpm.mk +12 -0
@@ -35,4 +35,16 @@ else WOLFTPM_CONF_OPTS += --disable-wolfcrypt endif +ifeq ($(BR2_PACKAGE_WOLFTPM_ST33),y) +WOLFTPM_CONF_OPTS += --enable-st33 +else +WOLFTPM_CONF_OPTS += --disable-st33 +endif + +ifeq ($(BR2_PACKAGE_WOLFTPM_NPCT750),y) +WOLFTPM_CONF_OPTS += --enable-nuvoton +else +WOLFTPM_CONF_OPTS += --disable-nuvoton +endif + $(eval $(autotools-package))
Signature · 6 lines
2.27.0 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Re: [Buildroot] [PATCH v4 1/1] package/wolftpm: Add config options for TPM 2.0 extra capabilities
Hi Thomas,
This patch adds new package options that enable extra TPM 2.0 capabilities.
ps: Please excuse the extra versions, it seems I am still sleepy this morning.
Thanks,
Dimi
--
Founder of TPM.dev
Quoted 58 lines · Dimi Tomov
From: Dimitar Tomov <[email protected]>
Some TPM 2.0 chips offer extra capabilities. This patch adds additional configuration options to the wolftpm package, so such capabilities can be available to the user. For example, the STMicroelectronics ST33 and Nuvoton NPCT750 both offer secure GPIO. Due to chip differences, wolfTPM requires explicit configuration options to enable the extra capabilities.
Signed-off-by Dimitar Tomov <[email protected]>---
Changes v3 -> v4:
- Fix commit message. For some reason the update was not included in patch v3.
Changes v2 -> v3:
- Better commit message
Changes v1 -> v2:
- Remove a not needed package description change--- package/wolftpm/Config.in | 12 ++++++++++++ package/wolftpm/wolftpm.mk | 12 ++++++++++++ 2 files changed, 24 insertions(+)package/wolftpm/Config.in +5
-0@@ -23,6 +23,18 @@ config BR2_PACKAGE_WOLFTPM_WOLFCRYPT encryption. Disabling this option is not recommended as it could create a security breach in most environments. +config BR2_PACKAGE_WOLFTPM_ST33 + bool "st33" + default n + help + Enable support of TPM 2.0 extra functionality offered by theSTMicroelectronics ST33 chip.
package/wolftpm/Config.in +6
-0+ +config BR2_PACKAGE_WOLFTPM_NUVOTON + bool "npct750" + default n + help + Enable support of TPM 2.0 extra functionality offered by theNuvoton NPCT750 chip.
package/wolftpm/Config.in +1
-0+ comment "wolfCrypt hooks need a toolchain w/ threads, dynamic library" depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBSpackage/wolftpm/wolftpm.mk +3
-0@@ -35,4 +35,16 @@ else WOLFTPM_CONF_OPTS += --disable-wolfcrypt endif +ifeq ($(BR2_PACKAGE_WOLFTPM_ST33),y) +WOLFTPM_CONF_OPTS += --enable-st33 +else
package/wolftpm/wolftpm.mk else · line 50
Quoted 10 lines
package/wolftpm/wolftpm.mk +9
-0+WOLFTPM_CONF_OPTS += --disable-st33 +endif + +ifeq ($(BR2_PACKAGE_WOLFTPM_NPCT750),y) +WOLFTPM_CONF_OPTS += --enable-nuvoton +else +WOLFTPM_CONF_OPTS += --disable-nuvoton +endif + $(eval $(autotools-package))
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Re: [Buildroot] [PATCH v4 1/1] package/wolftpm: Add config options for TPM 2.0 extra capabilities
Hi Dimi,
Quoted 9 lines · Dimi Tomov
Hi Thomas,
This patch adds new package options that enable extra TPM 2.0 capabilities.
ps: Please excuse the extra versions, it seems I am still sleepy this morning.
Quoted 25 lines
Thanks,
Dimi
--
Founder of TPM.devQuoted 19 lines · Dimi Tomov
From: Dimitar Tomov <[email protected]>
Some TPM 2.0 chips offer extra capabilities. This patch adds additional configuration options to the wolftpm package, so such capabilities can be available to the user. For example, the STMicroelectronics ST33 and Nuvoton NPCT750 both offer secure GPIO. Due to chip differences, wolfTPM
requires explicit configuration options to enable the extra capabilities.Signed-off-by Dimitar Tomov <[email protected]>---
Changes v3 -> v4:
- Fix commit message. For some reason the update was not included in patch v3.
Changes v2 -> v3:
- Better commit message
Changes v1 -> v2:
- Remove a not needed package description change
You should set previous iterations as superseded in patchwork:
https://patchwork.ozlabs.org/project/buildroot/list/
Quoted 13 lines
Quoted 13 lines
--- package/wolftpm/Config.in | 12 ++++++++++++ package/wolftpm/wolftpm.mk | 12 ++++++++++++ 2 files changed, 24 insertions(+)package/wolftpm/Config.in +0
-0@@ -23,6 +23,18 @@ config BR2_PACKAGE_WOLFTPM_WOLFCRYPT encryption. Disabling this option is not recommended as it could create a security breach in most environments.
Quoted 6 lines
Quoted 6 lines
package/wolftpm/Config.in +5
-0+config BR2_PACKAGE_WOLFTPM_ST33 + bool "st33" + default n + help + Enable support of TPM 2.0 extra functionality offered by theSTMicroelectronics ST33 chip.
This line is too long (it should be wrapped to 72 characters). make check-package will warn you about it
Quoted 7 lines
Quoted 7 lines
package/wolftpm/Config.in +6
-0+ +config BR2_PACKAGE_WOLFTPM_NUVOTON + bool "npct750" + default n + help + Enable support of TPM 2.0 extra functionality offered by theNuvoton NPCT750 chip.
This line is also too long.
Quoted 12 lines
Quoted 12 lines
package/wolftpm/Config.in +1
-0+ comment "wolfCrypt hooks need a toolchain w/ threads, dynamic library" depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBSpackage/wolftpm/wolftpm.mk +0
-0@@ -35,4 +35,16 @@ else WOLFTPM_CONF_OPTS += --disable-wolfcrypt endif
Quoted 13 lines
package/wolftpm/wolftpm.mk else · line 50
Quoted 13 lines
package/wolftpm/wolftpm.mk +12
-0+ifeq ($(BR2_PACKAGE_WOLFTPM_ST33),y) +WOLFTPM_CONF_OPTS += --enable-st33 +else +WOLFTPM_CONF_OPTS += --disable-st33 +endif + +ifeq ($(BR2_PACKAGE_WOLFTPM_NPCT750),y) +WOLFTPM_CONF_OPTS += --enable-nuvoton +else +WOLFTPM_CONF_OPTS += --disable-nuvoton +endif + $(eval $(autotools-package))
Best Regards,
Fabrice
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Re: [Buildroot] [PATCH v4 1/1] package/wolftpm: Add config options for TPM 2.0 extra capabilities
Hi Fabrice,
Thank you for this input.
What do you mean by superseded? I am using --in-reply-to. How are you typically sending follow-up patch versions?
I thought we are using 80 chars per line limit, I will update the patch with 72 chars per line limit.
Regards,
Dimi
Quoted 103 lines · Fabrice Fontaine
Hi Dimi,
Quoted 9 lines · Dimi Tomov
Hi Thomas,
This patch adds new package options that enable extra TPM 2.0 capabilities.
ps: Please excuse the extra versions, it seems I am still sleepy this morning.
Quoted 25 lines
Thanks,
Dimi
--
Founder of TPM.devQuoted 19 lines · Dimi Tomov
From: Dimitar Tomov <[email protected]>
Some TPM 2.0 chips offer extra capabilities. This patch adds additional configuration options to the wolftpm package, so such capabilities can be available to the user. For example, the STMicroelectronics ST33 and Nuvoton NPCT750 both offer secure GPIO. Due to chip differences, wolfTPM
requires explicit configuration options to enable the extra capabilities.Signed-off-by Dimitar Tomov <[email protected]>---
Changes v3 -> v4:
- Fix commit message. For some reason the update was not included in patch v3.
Changes v2 -> v3:
- Better commit message
Changes v1 -> v2:
- Remove a not needed package description changeYou should set previous iterations as superseded in patchwork:
https://patchwork.ozlabs.org/project/buildroot/list/Quoted 13 lines
Quoted 13 lines
--- package/wolftpm/Config.in | 12 ++++++++++++ package/wolftpm/wolftpm.mk | 12 ++++++++++++ 2 files changed, 24 insertions(+)package/wolftpm/Config.in +0
-0@@ -23,6 +23,18 @@ config BR2_PACKAGE_WOLFTPM_WOLFCRYPT encryption. Disabling this option is not recommended as it could create a security breach in most environments.Quoted 6 lines
Quoted 6 lines
package/wolftpm/Config.in +5
-0+config BR2_PACKAGE_WOLFTPM_ST33 + bool "st33" + default n + help + Enable support of TPM 2.0 extra functionality offered by theSTMicroelectronics ST33 chip.
This line is too long (it should be wrapped to 72 characters). make check-package will warn you about it
Quoted 7 lines
Quoted 7 lines
package/wolftpm/Config.in +6
-0+ +config BR2_PACKAGE_WOLFTPM_NUVOTON + bool "npct750" + default n + help + Enable support of TPM 2.0 extra functionality offered by theNuvoton NPCT750 chip.
This line is also too long.
Quoted 12 lines
Quoted 12 lines
package/wolftpm/Config.in +1
-0+ comment "wolfCrypt hooks need a toolchain w/ threads, dynamic library" depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBSpackage/wolftpm/wolftpm.mk +0
-0@@ -35,4 +35,16 @@ else WOLFTPM_CONF_OPTS += --disable-wolfcrypt endifQuoted 13 lines
package/wolftpm/wolftpm.mk else · line 50
Quoted 13 lines
package/wolftpm/wolftpm.mk +12
-0+ifeq ($(BR2_PACKAGE_WOLFTPM_ST33),y) +WOLFTPM_CONF_OPTS += --enable-st33 +else +WOLFTPM_CONF_OPTS += --disable-st33 +endif + +ifeq ($(BR2_PACKAGE_WOLFTPM_NPCT750),y) +WOLFTPM_CONF_OPTS += --enable-nuvoton +else +WOLFTPM_CONF_OPTS += --disable-nuvoton +endif + $(eval $(autotools-package))Best Regards,
Fabrice
Signature · 5 lines
Founder of TPM.dev _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Re: [Buildroot] [PATCH v4 1/1] package/wolftpm: Add config options for TPM 2.0 extra capabilities
Quoted 7 lines · Dimi Tomov
Hi Fabrice,
Thank you for this input.
What do you mean by superseded? I am using --in-reply-to. How are you typically sending follow-up patch versions?
I'm not using --in-reply-to.
I'm manually changing the status in
https://patchwork.ozlabs.org/project/buildroot.
I assume that there is an issue with the ID that you provide to --in-reply-to as buildroot manual specifies that "You can also add the --in-reply-to <message-id> option when submitting a patch to the mailing list. The id of the mail to reply to can be found under the "Message Id" tag on patchwork. The advantage of in-reply-to is that patchwork will automatically mark the previous version of the patch as superseded."
but previous iterations of your patch are still set as New in patchwork:
https://patchwork.ozlabs.org/project/buildroot/patch/[email protected]/
Quoted 3 lines
I thought we are using 80 chars per line limit, I will update the patch with 72 chars per line limit.
help text must be lower than 72 chars in Config.in.
Quoted 108 lines
Regards,
Dimi
Quoted 102 lines · Fabrice Fontaine
Hi Dimi,
Quoted 9 lines · Dimi Tomov
Hi Thomas,
This patch adds new package options that enable extra TPM 2.0 capabilities.
ps: Please excuse the extra versions, it seems I am still sleepy this morning.
Quoted 25 lines
Thanks,
Dimi
--
Founder of TPM.devQuoted 19 lines · Dimi Tomov
From: Dimitar Tomov <[email protected]>
Some TPM 2.0 chips offer extra capabilities. This patch adds additional configuration options to the wolftpm package, so such capabilities can be available to the user. For example, the STMicroelectronics ST33 and Nuvoton NPCT750 both offer secure GPIO. Due to chip differences, wolfTPM
requires explicit configuration options to enable the extra capabilities.Signed-off-by Dimitar Tomov <[email protected]>---
Changes v3 -> v4:
- Fix commit message. For some reason the update was not included in patch v3.
Changes v2 -> v3:
- Better commit message
Changes v1 -> v2:
- Remove a not needed package description changeYou should set previous iterations as superseded in patchwork:
https://patchwork.ozlabs.org/project/buildroot/list/Quoted 13 lines
Quoted 13 lines
--- package/wolftpm/Config.in | 12 ++++++++++++ package/wolftpm/wolftpm.mk | 12 ++++++++++++ 2 files changed, 24 insertions(+)package/wolftpm/Config.in +0
-0@@ -23,6 +23,18 @@ config BR2_PACKAGE_WOLFTPM_WOLFCRYPT encryption. Disabling this option is not recommended as it could create a security breach in most environments.Quoted 6 lines
Quoted 6 lines
package/wolftpm/Config.in +5
-0+config BR2_PACKAGE_WOLFTPM_ST33 + bool "st33" + default n + help + Enable support of TPM 2.0 extra functionality offered by theSTMicroelectronics ST33 chip.
This line is too long (it should be wrapped to 72 characters). make check-package will warn you about it
Quoted 7 lines
Quoted 7 lines
package/wolftpm/Config.in +6
-0+ +config BR2_PACKAGE_WOLFTPM_NUVOTON + bool "npct750" + default n + help + Enable support of TPM 2.0 extra functionality offered by theNuvoton NPCT750 chip.
This line is also too long.
Quoted 12 lines
Quoted 12 lines
package/wolftpm/Config.in +1
-0+ comment "wolfCrypt hooks need a toolchain w/ threads, dynamic library" depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBSpackage/wolftpm/wolftpm.mk +0
-0@@ -35,4 +35,16 @@ else WOLFTPM_CONF_OPTS += --disable-wolfcrypt endifQuoted 13 lines
package/wolftpm/wolftpm.mk else · line 50
Quoted 13 lines
package/wolftpm/wolftpm.mk +12
-0+ifeq ($(BR2_PACKAGE_WOLFTPM_ST33),y) +WOLFTPM_CONF_OPTS += --enable-st33 +else +WOLFTPM_CONF_OPTS += --disable-st33 +endif + +ifeq ($(BR2_PACKAGE_WOLFTPM_NPCT750),y) +WOLFTPM_CONF_OPTS += --enable-nuvoton +else +WOLFTPM_CONF_OPTS += --disable-nuvoton +endif + $(eval $(autotools-package))Best Regards,
Quoted 4 lines
Quoted 1 line
Fabrice
--
Founder of TPM.dev
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
PATCH v5 1/1 package/wolftpm: Add config options for TPM 2.0 extra capabilities
In reply to Dimi TomovFrom: Dimitar Tomov <[email protected]>
Some TPM 2.0 chips offer extra capabilities. This patch adds additional configuration options to the wolftpm package, so such capabilities can be available to the user. For example, the STMicroelectronics ST33 and Nuvoton NPCT750 both offer secure GPIO. Due to chip differences, wolfTPM requires explicit configuration options to enable the extra capabilities.
---
Changes v4 -> v5:
- Style: Fix some lines in Config.in that were longer than 72 characters Changes v3 -> v4:
- Fix commit message. For some reason the update was not included in patch v3. Changes v2 -> v3:
- Better commit message
Changes v1 -> v2:
- Remove a not needed package description change
--- package/wolftpm/Config.in | 14 ++++++++++++++ package/wolftpm/wolftpm.mk | 12 ++++++++++++ 2 files changed, 26 insertions(+)
package/wolftpm/Config.in +14 -0
@@ -23,6 +23,20 @@ config BR2_PACKAGE_WOLFTPM_WOLFCRYPT encryption. Disabling this option is not recommended as it could create a security breach in most environments. +config BR2_PACKAGE_WOLFTPM_ST33 + bool "st33" + default n + help + Enable support of TPM 2.0 extra functionality offered by the + STMicroelectronics ST33 chip. + +config BR2_PACKAGE_WOLFTPM_NUVOTON + bool "npct750" + default n + help + Enable support of TPM 2.0 extra functionality offered by the + Nuvoton NPCT750 chip. + comment "wolfCrypt hooks need a toolchain w/ threads, dynamic library" depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
package/wolftpm/wolftpm.mk +12 -0
@@ -35,4 +35,16 @@ else WOLFTPM_CONF_OPTS += --disable-wolfcrypt endif +ifeq ($(BR2_PACKAGE_WOLFTPM_ST33),y) +WOLFTPM_CONF_OPTS += --enable-st33 +else +WOLFTPM_CONF_OPTS += --disable-st33 +endif + +ifeq ($(BR2_PACKAGE_WOLFTPM_NPCT750),y) +WOLFTPM_CONF_OPTS += --enable-nuvoton +else +WOLFTPM_CONF_OPTS += --disable-nuvoton +endif + $(eval $(autotools-package))
Signature · 6 lines
2.27.0 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Re: [Buildroot] [PATCH v5, 1/1] package/wolftpm: Add config options for TPM 2.0 extra capabilities
Hi Thomas,
This patch is ready for review. Thanks to Fabrice for the good feedback.
ps: I am unable to enter patchwork after password reset, so v4 still holds new status.
Regards,
Dimi
Signature · 1 line
Founder of TPM.dev
Quoted 61 lines · Dimi Tomov
From: Dimitar Tomov <[email protected]>
Some TPM 2.0 chips offer extra capabilities. This patch adds additional configuration options to the wolftpm package, so such capabilities can be available to the user. For example, the STMicroelectronics ST33 and Nuvoton NPCT750 both offer secure GPIO. Due to chip differences, wolfTPM requires explicit configuration options to enable the extra capabilities.
Signed-off-by Dimitar Tomov <[email protected]>---
Changes v4 -> v5:
- Style: Fix some lines in Config.in that were longer than 72 characters
Changes v3 -> v4:
- Fix commit message. For some reason the update was not included in patch v3.
Changes v2 -> v3:
- Better commit message
Changes v1 -> v2:
- Remove a not needed package description change--- package/wolftpm/Config.in | 14 ++++++++++++++ package/wolftpm/wolftpm.mk | 12 ++++++++++++ 2 files changed, 26 insertions(+)package/wolftpm/Config.in +14
-0@@ -23,6 +23,20 @@ config BR2_PACKAGE_WOLFTPM_WOLFCRYPT encryption. Disabling this option is not recommended as it could create a security breach in most environments. +config BR2_PACKAGE_WOLFTPM_ST33 + bool "st33" + default n + help + Enable support of TPM 2.0 extra functionality offered by the + STMicroelectronics ST33 chip. + +config BR2_PACKAGE_WOLFTPM_NUVOTON + bool "npct750" + default n + help + Enable support of TPM 2.0 extra functionality offered by the + Nuvoton NPCT750 chip. + comment "wolfCrypt hooks need a toolchain w/ threads, dynamic library" depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBSpackage/wolftpm/wolftpm.mk +3
-0@@ -35,4 +35,16 @@ else WOLFTPM_CONF_OPTS += --disable-wolfcrypt endif +ifeq ($(BR2_PACKAGE_WOLFTPM_ST33),y) +WOLFTPM_CONF_OPTS += --enable-st33 +else
package/wolftpm/wolftpm.mk else · line 50
Quoted 10 lines
package/wolftpm/wolftpm.mk +9
-0+WOLFTPM_CONF_OPTS += --disable-st33 +endif + +ifeq ($(BR2_PACKAGE_WOLFTPM_NPCT750),y) +WOLFTPM_CONF_OPTS += --enable-nuvoton +else +WOLFTPM_CONF_OPTS += --disable-nuvoton +endif + $(eval $(autotools-package))
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot