Skip to contentSkip to conversation

hwmon: (asus-ec-sensors) add missing comma in board name list.

PATCH Superseded Eugene Shalygin 2 participants 4 messages Jun 15, 2022

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Eugene Shalygin

author maintainer
#0 lore raw

PATCH 1/1 hwmon: (asus-ec-sensors) add missing comma in board name list.

From: Michael Carns <[email protected]>

This fixes a regression introduced by commit 5b4285c57b6f ("hwmon: (asus-ec-sensors) fix Formula VIII definition") where coma lead to concatenating board names and broke module loading for C8H.

---
 drivers/hwmon/asus-ec-sensors.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/asus-ec-sensors.c +1 -1
index 886a71b4c64e..19d3ca71b360 100644
@@ -268,7 +268,7 @@ static const struct ec_board_info board_info[] = {
 	},
 	{
 		.board_names = {
-			"ROG CROSSHAIR VIII FORMULA"
+			"ROG CROSSHAIR VIII FORMULA",
 			"ROG CROSSHAIR VIII HERO",
 			"ROG CROSSHAIR VIII HERO (WI-FI)",
 		},
Signature · 1 line
2.35.1
author maintainer
#1 lore raw

The error already made it into 5.19-rc1, unfortunately...

maintainer
#2 lore raw
In reply to Eugene Shalygin
Quoted 9 lines · Eugene Shalygin

From: Michael Carns <[email protected]>

This fixes a regression introduced by commit 5b4285c57b6f ("hwmon: (asus-ec-sensors) fix Formula VIII definition") where coma lead to concatenating board names and broke module loading for C8H.

We have a Fixes: tag for such purposes. Please use it.

Thanks,
Guenter

Quoted 17 lines
---
  drivers/hwmon/asus-ec-sensors.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/asus-ec-sensors.c +1 -1
index 886a71b4c64e..19d3ca71b360 100644
@@ -268,7 +268,7 @@ static const struct ec_board_info board_info[] = {
  	},
  	{
  		.board_names = {
-			"ROG CROSSHAIR VIII FORMULA"
+			"ROG CROSSHAIR VIII FORMULA",
  			"ROG CROSSHAIR VIII HERO",
  			"ROG CROSSHAIR VIII HERO (WI-FI)",
  		},
author maintainer
#3 lore raw
Quoted 1 line

We have a Fixes: tag for such purposes. Please use it.

Thanks, done in v2.

Eugene