Skip to contentSkip to conversation

iio: adc: intel_mrfld_adc: explicitly add proper header files

PATCH In review Andy Shevchenko 3 participants 4 messages Jun 15, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: adc: intel_mrfld_adc: explicitly add proper header files

Do not trust the fact that iio.h includes of.h which in turn includes all the headers we are relying on.

The ultimate goal is to actually drop of.h from iio.h.

---

Jonathan, this should be squeezed before we remove of.h in iio.h I think Nuno somehow missed this

 drivers/iio/adc/intel_mrfld_adc.c | 1 +
 1 file changed, 1 insertion(+)
drivers/iio/adc/intel_mrfld_adc.c +1 -0
index 616de0c3a049..7263ad76124d 100644
@@ -15,6 +15,7 @@
 #include <linux/interrupt.h>
 #include <linux/mfd/intel_soc_pmic.h>
 #include <linux/mfd/intel_soc_pmic_mrfld.h>
+#include <linux/mod_devicetable.h>
 #include <linux/module.h>
 #include <linux/mutex.h>
 #include <linux/platform_device.h>
Signature · 1 line
2.35.1
reviewer Reviewed-by on v1 1/1
#1 lore raw

Hi Andy,

Quoted 16 lines

-----Original Message-----
From: Andy Shevchenko <[email protected]>
Sent: Wednesday, June 15, 2022 2:08 PM
To: Andy Shevchenko <[email protected]>; Alexandru Ardelean <[email protected]>; linux- [email protected]; [email protected]
Cc: Jonathan Cameron <[email protected]>; Lars-Peter Clausen <[email protected]>
Subject: [PATCH v1 1/1] iio: adc: intel_mrfld_adc: explicitly add proper header files

[External]

Do not trust the fact that iio.h includes of.h which in turn includes all the headers we are relying on.

Quoted 8 lines

The ultimate goal is to actually drop of.h from iio.h.

Signed-off-by: Andy Shevchenko
<[email protected]>
---

Jonathan, this should be squeezed before we remove of.h in iio.h I think Nuno somehow missed this

Yes, I did (compile) tested this on arm and arm64 as I said in the cover. I guess this one won't be enabled on those archs :).

I was planning to send this on v2 (I did noticed the kernel test bot emails) but yeah, this should actually be included with the other patches before removing of.h from iio. Thanks!

maintainer
#2 lore raw
Quoted 27 lines · Nuno

Hi Andy,

Quoted 16 lines

-----Original Message-----
From: Andy Shevchenko <[email protected]>
Sent: Wednesday, June 15, 2022 2:08 PM
To: Andy Shevchenko <[email protected]>; Alexandru Ardelean <[email protected]>; linux- [email protected]; [email protected]
Cc: Jonathan Cameron <[email protected]>; Lars-Peter Clausen <[email protected]>
Subject: [PATCH v1 1/1] iio: adc: intel_mrfld_adc: explicitly add proper header files

[External]

Do not trust the fact that iio.h includes of.h which in turn includes all the headers we are relying on.

Quoted 8 lines

The ultimate goal is to actually drop of.h from iio.h.

Signed-off-by: Andy Shevchenko
<[email protected]>
---

Jonathan, this should be squeezed before we remove of.h in iio.h I think Nuno somehow missed this

Quoted 8 lines

Yes, I did (compile) tested this on arm and arm64 as I said in the cover. I guess this one won't be enabled on those archs :).

I was planning to send this on v2 (I did noticed the kernel test bot emails) but yeah, this should actually be included with the other patches before removing of.h from iio. Thanks!

Applied. Oddly didn't show up in my normal x86 build test.

As suggested, slotted in before the of.h removal patch.

Thanks,

Jonathan

Quoted 1 line
maintainer
#3 lore raw
Quoted 33 lines · On Wed, 15 Jun 2022 22:09:30 +0100 Jonathan Cameron <[email protected]> wrote:
Quoted 30 lines · Nuno

Hi Andy,

Quoted 16 lines

-----Original Message-----
From: Andy Shevchenko <[email protected]>
Sent: Wednesday, June 15, 2022 2:08 PM
To: Andy Shevchenko <[email protected]>; Alexandru Ardelean <[email protected]>; linux- [email protected]; [email protected]
Cc: Jonathan Cameron <[email protected]>; Lars-Peter Clausen <[email protected]>
Subject: [PATCH v1 1/1] iio: adc: intel_mrfld_adc: explicitly add proper header files

[External]

Do not trust the fact that iio.h includes of.h which in turn includes all the headers we are relying on.

Quoted 8 lines

The ultimate goal is to actually drop of.h from iio.h.

Signed-off-by: Andy Shevchenko
<[email protected]>
---

Jonathan, this should be squeezed before we remove of.h in iio.h I think Nuno somehow missed this

Yes, I did (compile) tested this on arm and arm64 as I said in the cover. I guess this one won't be enabled on those archs :).

Quoted 7 lines
Quoted 5 lines

I was planning to send this on v2 (I did noticed the kernel test bot emails) but yeah, this should actually be included with the other patches before removing of.h from iio. Thanks!

Applied. Oddly didn't show up in my normal x86 build test.

Figured out the chain of necessary dependencies so I'll catch anything effecting this in my smoke test build going forwards.

Thanks,

Jonathan

Quoted 9 lines

As suggested, slotted in before the of.h removal patch.

Thanks,

Jonathan

Quoted 1 line