Skip to contentSkip to conversation

drivers: soc: tegra: fuse: Add missing of_node_put() in tegra-apbmisc.c

PATCH Superseded Liang He 1 participant 1 message Jun 15, 2022 Tegra architecture support

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Liang He

author
#0 lore raw

PATCH 1/1 drivers: soc: tegra: fuse: Add missing of_node_put() in tegra-apbmisc.c

In tegra_init_apbmisc(), of_find_matching_node() will return a node pointer with refcount incremented. We should use of_node_put in each fail path or when it is not used anymore.

---
 drivers/soc/tegra/fuse/tegra-apbmisc.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/soc/tegra/fuse/tegra-apbmisc.c +5 -2
index 590c862538d0..24e54e766581 100644
@@ -182,12 +182,12 @@ void __init tegra_init_apbmisc(void)
 		 */
 		if (of_address_to_resource(np, 0, &apbmisc) < 0) {
 			pr_err("failed to get APBMISC registers\n");
-			return;
+			goto out_put;
 		}
 
 		if (of_address_to_resource(np, 1, &straps) < 0) {
 			pr_err("failed to get strapping options registers\n");
-			return;
+			goto out_put;
 		}
 	}
 
@@ -208,4 +208,7 @@ void __init tegra_init_apbmisc(void)
 	}
 
 	long_ram_code = of_property_read_bool(np, "nvidia,long-ram-code");
+
+out_put:
+	of_node_put(np);
 }
Signature · 1 line
2.25.1