Skip to contentSkip to conversation

auto-t: fix timing issue in testEncryptedProfiles

PATCH New James Prestwood 1 participant 1 message Jun 15, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 auto-t: fix timing issue in testEncryptedProfiles

test_decryption_failure is quite simple and only verifies that a known network exists after starting. This causes the test to end before IWD can fully start up leaving the DBus utilities in limbo having not fully initialized.

Then, on the next test, stale InterfaceAdded signals arrive (for Station and P2P) which throw exceptions when trying to get the bus (since IWD is long gone). In addition the next IWD instance has started so any paths included in the InterfaceAdded signals are bogus and cause additional exceptions.

At the end of this test we can call list_devices() which will wait for the InterfaceAdded signal, and cleanly exit afterwards.

---
 autotests/testEncryptedProfiles/connection_test.py | 6 ++++++
 1 file changed, 6 insertions(+)
autotests/testEncryptedProfiles/connection_test.py +6 -0
index dd4892ca..2b846596 100644
@@ -115,6 +115,12 @@ EncryptedSecurity=aabbccddeeff00112233445566778899
 
         self.assertEqual(wd.list_known_networks(), [])
 
+        # This test starts and stops IWD so quickly the DBus utilities don't
+        # even have a chance to set up the Device interface object which causes
+        # exceptions on the next test as the InterfaceAdded signals arrive. This
+        # allows the device interface to get set up before ending the test.
+        wd.list_devices(1)
+
     def test_runtime_profile(self):
         wd = IWD(True)
 
Signature · 1 line
2.34.1