tests/i915/gem_busy : Added subtests description

PATCH In review [email protected] 3 participants 6 messages Jun 16, 2022 – Jun 22, 2022

lore

Share & tools

lore

[email protected]

author

2022-06-16 03:59 UTC #0 lore raw

cover tests/i915/gem_busy : Added subtests description

From: Sinjan Kumar <[email protected]>

Added subtest description to following test:-

1. busy
2. close-race
3. extended
4. parallel
5. semaphore
6. hang
7. hang-extended

Sinjan Kumar (2):
[igt-dev] tests/i915/gem_busy : Added subtests description
HAX: don't do full run

 tests/i915/gem_busy.c                 |  19 +++
 tests/intel-ci/fast-feedback.testlist | 188 +-------------------------
 2 files changed, 20 insertions(+), 187 deletions(-)

Signature · 1 line

2.25.1

[email protected]

author

2022-06-16 03:59 UTC #1 lore raw

PATCH 1/2 tests/i915/gem_busy : Added subtests description

From: Sinjan Kumar <[email protected]>

added subtest description to gem_busy tests

Cc Kamil Konieczny <[email protected]>

Signed-off-by Sinjan Kumar <[email protected]>

---
 tests/i915/gem_busy.c | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

tests/i915/gem_busy.c +19 -0

index 603691f2..7a4c5c50 100644
@@ -447,6 +447,8 @@ igt_main
 			igt_fork_hang_detector(fd);
 		}
 
+		igt_describe("Basic test to check busyness of each engine "
+			     "context in parallel");
 		igt_subtest_with_dynamic("busy") {
 			igt_dynamic("all") {
 				gem_quiescent_gpu(fd);

@@ -461,6 +463,8 @@ igt_main
 			}
 		}
 
+		igt_describe("Test to check race condition by randomly closing "
+			     "the handle using gem_close");
 		igt_subtest("close-race")
 			close_race(fd, ctx);

@@ -482,12 +486,17 @@ igt_main
 				gem_require_mmap_device_coherent(fd);
 			}
 
+			igt_describe("Extended test to check busyness of engine "
+				     "classes [Read/Write]");
 			test_each_engine_store("extended", fd, ctx, e) {
 				gem_quiescent_gpu(fd);
 				one(fd, ctx, e, 0);
 				gem_quiescent_gpu(fd);
 			}
 
+			igt_describe("Extended test to check busyness of engine "
+				     "classes [Read/Write] while doing parallel "
+				     "execution");
 			test_each_engine_store("parallel", fd, ctx, e) {
 				gem_quiescent_gpu(fd);
 				one(fd, ctx, e, PARALLEL);

@@ -501,6 +510,9 @@ igt_main
 				igt_require(has_semaphores(fd));
 			}
 
+		igt_describe("Test to check wait signal mechanism by submitting "
+			     "a new batch when engine is busy in executing "
+			     "previous batch");
 			test_each_engine("semaphore", fd, ctx, e) {
 				gem_quiescent_gpu(fd);
 				semaphore(fd, ctx, e);

@@ -520,6 +532,9 @@ igt_main
 			hang = igt_allow_hang(fd, ctx->id, 0);
 		}
 
+		igt_describe("Basic test to check hang state beahaviour of "
+			     "engine by checking task completion with "
+			     "increased timeout");
 		test_each_engine("hang", fd, ctx, e) {
 			gem_quiescent_gpu(fd);
 			basic(fd, ctx, e, HANG);

@@ -532,6 +547,10 @@ igt_main
 				gem_require_mmap_device_coherent(fd);
 			}
 
+			igt_describe("Extended test to check hang state "
+				     "behaviour of engine class [Read/Write] "
+				     "by checking task completion with "
+				     "increased timeout");
 			test_each_engine_store("hang-extended", fd, ctx, e) {
 				gem_quiescent_gpu(fd);
 				one(fd, ctx, e, HANG);

Signature · 1 line

2.25.1

Kamil Konieczny

2022-06-22 14:08 UTC #2 lore raw

Hi Sinjan,

Quoted 3 lines · On 2022-06-16 at 09:28:20 +0530, [email protected] wrote:

From: Sinjan Kumar <[email protected]>
added subtest description to gem_busy tests

- ^

Start from capital letter, s/added/Added/ and add dot at the end of sentence.

Quoted 12 lines

Cc Kamil Konieczny <[email protected]>
Signed-off-by Sinjan Kumar <[email protected]>
---
 tests/i915/gem_busy.c | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
tests/i915/gem_busy.c +0 -0
index 603691f2..7a4c5c50 100644

tests/i915/gem_busy.c igt_main · line 450

Quoted 4 lines

tests/i915/gem_busy.c +1 -0

@@ -447,6 +447,8 @@ igt_main
 			igt_fork_hang_detector(fd);
 		}
 
+		igt_describe("Basic test to check busyness of each engine "

This part is ok.

tests/i915/gem_busy.c igt_main · line 451

Quoted 1 line

tests/i915/gem_busy.c +1 -0
+			     "context in parallel");

Drop this part, all tests use the same context.
Put also dot at the end of description (and also do this below).

Quoted 13 lines

tests/i915/gem_busy.c +2 -0

 		igt_subtest_with_dynamic("busy") {
 			igt_dynamic("all") {
 				gem_quiescent_gpu(fd);

@@ -461,6 +463,8 @@ igt_main
 			}
 		}
 
+		igt_describe("Test to check race condition by randomly closing "
+			     "the handle using gem_close");
 		igt_subtest("close-race")
 			close_race(fd, ctx);

tests/i915/gem_busy.c igt_main · line 490

Quoted 5 lines

tests/i915/gem_busy.c +2 -0

@@ -482,12 +486,17 @@ igt_main
 				gem_require_mmap_device_coherent(fd);
 			}
 
+			igt_describe("Extended test to check busyness of engine "
+				     "classes [Read/Write]");

Hmm, this [Read/Write] looks strange, maybe something like:

s/engine classes [Read/Write]/busyness of dwstore-capable engines./

Do this also below (where you are using this).

tests/i915/gem_busy.c igt_main · line 498

Quoted 8 lines

tests/i915/gem_busy.c +2 -0

 			test_each_engine_store("extended", fd, ctx, e) {
 				gem_quiescent_gpu(fd);
 				one(fd, ctx, e, 0);
 				gem_quiescent_gpu(fd);
 			}
 
+			igt_describe("Extended test to check busyness of engine "
+				     "classes [Read/Write] while doing parallel "

Same r/w here.

tests/i915/gem_busy.c igt_main · line 515

Quoted 11 lines

tests/i915/gem_busy.c +4 -0

+				     "execution");
 			test_each_engine_store("parallel", fd, ctx, e) {
 				gem_quiescent_gpu(fd);
 				one(fd, ctx, e, PARALLEL);

@@ -501,6 +510,9 @@ igt_main
 				igt_require(has_semaphores(fd));
 			}
 
+		igt_describe("Test to check wait signal mechanism by submitting "
+			     "a new batch when engine is busy in executing "
+			     "previous batch");

Please try to improve this, we test busy-ioctl here.

tests/i915/gem_busy.c igt_main · line 537

Quoted 10 lines

tests/i915/gem_busy.c +3 -0

 			test_each_engine("semaphore", fd, ctx, e) {
 				gem_quiescent_gpu(fd);
 				semaphore(fd, ctx, e);

@@ -520,6 +532,9 @@ igt_main
 			hang = igt_allow_hang(fd, ctx->id, 0);
 		}
 
+		igt_describe("Basic test to check hang state beahaviour of "
+			     "engine by checking task completion with "
+			     "increased timeout");

Drop words starting with "by checking ...".
Please read comments for igt_describe in lib/igt_core.h for general help how to describe sub/tests.

tests/i915/gem_busy.c igt_main · line 551

Quoted 9 lines

tests/i915/gem_busy.c +2 -0

 		test_each_engine("hang", fd, ctx, e) {
 			gem_quiescent_gpu(fd);
 			basic(fd, ctx, e, HANG);

@@ -532,6 +547,10 @@ igt_main
 				gem_require_mmap_device_coherent(fd);
 			}
 
+			igt_describe("Extended test to check hang state "
+				     "behaviour of engine class [Read/Write] "

Same r/w here.

tests/i915/gem_busy.c igt_main · line 552

Quoted 1 line

tests/i915/gem_busy.c +1 -0

+				     "by checking task completion with "

Same here - drop this.

Regards,
Kamil

Quoted 7 lines

tests/i915/gem_busy.c +1 -0

+				     "increased timeout");
 			test_each_engine_store("hang-extended", fd, ctx, e) {
 				gem_quiescent_gpu(fd);
 				one(fd, ctx, e, HANG);

Signature · 1 line

2.25.1

[email protected]

author

2022-06-16 03:59 UTC #3 lore raw

PATCH 2/2 HAX: don't do full run

In reply to [email protected]

From: Sinjan Kumar <[email protected]>

Just for test description, no full run is necessary

Cc Kamil Konieczny <[email protected]>

Signed-off-by Sinjan Kumar <[email protected]>

---
 tests/intel-ci/fast-feedback.testlist | 188 +-------------------------
 1 file changed, 1 insertion(+), 187 deletions(-)

tests/intel-ci/fast-feedback.testlist +1 ~~-187~~

index 9c5dee44..9f8e18ce 100644
@@ -1,187 +1 @@
-# Try to load the driver if it's not available yet.
-igt@i915_module_load@load
-
-# Keep alphabetically sorted by default
-igt@core_auth@basic-auth
-igt@debugfs_test@read_all_entries
-igt@fbdev@eof
-igt@fbdev@info
-igt@fbdev@nullptr
-igt@fbdev@read
-igt@fbdev@write
-igt@gem_basic@bad-close
-igt@gem_basic@create-close
-igt@gem_basic@create-fd-close
-igt@gem_busy@busy@all
-igt@gem_close_race@basic-process
-igt@gem_close_race@basic-threads
-igt@gem_ctx_create@basic
-igt@gem_ctx_create@basic-files
-igt@gem_ctx_exec@basic
-igt@gem_exec_basic@basic
-igt@gem_exec_create@basic
-igt@gem_exec_fence@basic-busy
-igt@gem_exec_fence@basic-wait
-igt@gem_exec_fence@basic-await
-igt@gem_exec_fence@nb-await
-igt@gem_exec_gttfill@basic
-igt@gem_exec_parallel@engines
-igt@gem_exec_store@basic
-igt@gem_flink_basic@bad-flink
-igt@gem_flink_basic@bad-open
-igt@gem_flink_basic@basic
-igt@gem_flink_basic@double-flink
-igt@gem_flink_basic@flink-lifetime
-igt@gem_huc_copy@huc-copy
-igt@gem_linear_blits@basic
-igt@gem_mmap@basic
-igt@gem_mmap_gtt@basic
-igt@gem_render_linear_blits@basic
-igt@gem_render_tiled_blits@basic
-igt@gem_ringfill@basic-all
-igt@gem_softpin@allocator-basic
-igt@gem_softpin@allocator-basic-reserve
-igt@gem_softpin@safe-alignment
-igt@gem_sync@basic-all
-igt@gem_sync@basic-each
-igt@gem_tiled_blits@basic
-igt@gem_tiled_fence_blits@basic
-igt@gem_tiled_pread_basic
-igt@gem_wait@busy@all
-igt@gem_wait@wait@all
-igt@i915_getparams_basic@basic-eu-total
-igt@i915_getparams_basic@basic-subslice-total
-igt@i915_hangman@error-state-basic
-igt@i915_pciid
-igt@kms_addfb_basic@addfb25-bad-modifier
-igt@kms_addfb_basic@addfb25-framebuffer-vs-set-tiling
-igt@kms_addfb_basic@addfb25-modifier-no-flag
-igt@kms_addfb_basic@addfb25-x-tiled-legacy
-igt@kms_addfb_basic@addfb25-x-tiled-mismatch-legacy
-igt@kms_addfb_basic@addfb25-yf-tiled-legacy
-igt@kms_addfb_basic@addfb25-y-tiled-legacy
-igt@kms_addfb_basic@addfb25-y-tiled-small-legacy
-igt@kms_addfb_basic@bad-pitch-0
-igt@kms_addfb_basic@bad-pitch-1024
-igt@kms_addfb_basic@bad-pitch-128
-igt@kms_addfb_basic@bad-pitch-256
-igt@kms_addfb_basic@bad-pitch-32
-igt@kms_addfb_basic@bad-pitch-63
-igt@kms_addfb_basic@bad-pitch-65536
-igt@kms_addfb_basic@bad-pitch-999
-igt@kms_addfb_basic@basic
-igt@kms_addfb_basic@basic-x-tiled-legacy
-igt@kms_addfb_basic@basic-y-tiled-legacy
-igt@kms_addfb_basic@bo-too-small
-igt@kms_addfb_basic@bo-too-small-due-to-tiling
-igt@kms_addfb_basic@clobberred-modifier
-igt@kms_addfb_basic@framebuffer-vs-set-tiling
-igt@kms_addfb_basic@invalid-get-prop
-igt@kms_addfb_basic@invalid-get-prop-any
-igt@kms_addfb_basic@invalid-set-prop
-igt@kms_addfb_basic@invalid-set-prop-any
-igt@kms_addfb_basic@no-handle
-igt@kms_addfb_basic@size-max
-igt@kms_addfb_basic@small-bo
-igt@kms_addfb_basic@tile-pitch-mismatch
-igt@kms_addfb_basic@too-high
-igt@kms_addfb_basic@too-wide
-igt@kms_addfb_basic@unused-handle
-igt@kms_addfb_basic@unused-modifier
-igt@kms_addfb_basic@unused-offsets
-igt@kms_addfb_basic@unused-pitches
-igt@kms_busy@basic
-igt@kms_chamelium@dp-hpd-fast
-igt@kms_chamelium@dp-edid-read
-igt@kms_chamelium@dp-crc-fast
-igt@kms_chamelium@hdmi-hpd-fast
-igt@kms_chamelium@hdmi-edid-read
-igt@kms_chamelium@hdmi-crc-fast
-igt@kms_chamelium@vga-hpd-fast
-igt@kms_chamelium@vga-edid-read
-igt@kms_prop_blob@basic
-igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic
-igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy
-igt@kms_cursor_legacy@basic-flip-after-cursor-atomic
-igt@kms_cursor_legacy@basic-flip-after-cursor-legacy
-igt@kms_cursor_legacy@basic-flip-after-cursor-varying-size
-igt@kms_cursor_legacy@basic-flip-before-cursor-atomic
-igt@kms_cursor_legacy@basic-flip-before-cursor-legacy
-igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size
-igt@kms_flip@basic-flip-vs-dpms
-igt@kms_flip@basic-flip-vs-modeset
-igt@kms_flip@basic-flip-vs-wf_vblank
-igt@kms_flip@basic-plain-flip
-igt@kms_force_connector_basic@force-connector-state
-igt@kms_force_connector_basic@force-edid
-igt@kms_force_connector_basic@force-load-detect
-igt@kms_force_connector_basic@prune-stale-modes
-igt@kms_frontbuffer_tracking@basic
-igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-a
-igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b
-igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c
-igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d
-igt@kms_pipe_crc_basic@hang-read-crc-pipe-a
-igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a
-igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence
-igt@kms_pipe_crc_basic@read-crc-pipe-a
-igt@kms_pipe_crc_basic@read-crc-pipe-b
-igt@kms_pipe_crc_basic@read-crc-pipe-c
-igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence
-igt@kms_psr@primary_page_flip
-igt@kms_psr@cursor_plane_move
-igt@kms_psr@sprite_plane_onoff
-igt@kms_psr@primary_mmap_gtt
-igt@kms_setmode@basic-clone-single-crtc
-igt@i915_pm_backlight@basic-brightness
-igt@i915_pm_rpm@basic-pci-d3-state
-igt@i915_pm_rpm@basic-rte
-igt@i915_pm_rps@basic-api
-igt@prime_self_import@basic-llseek-bad
-igt@prime_self_import@basic-llseek-size
-igt@prime_self_import@basic-with_fd_dup
-igt@prime_self_import@basic-with_one_bo
-igt@prime_self_import@basic-with_one_bo_two_files
-igt@prime_self_import@basic-with_two_bos
-igt@prime_vgem@basic-fence-flip
-igt@prime_vgem@basic-fence-mmap
-igt@prime_vgem@basic-fence-read
-igt@prime_vgem@basic-gtt
-igt@prime_vgem@basic-read
-igt@prime_vgem@basic-write
-igt@prime_vgem@basic-userptr
-igt@vgem_basic@setversion
-igt@vgem_basic@create
-igt@vgem_basic@debugfs
-igt@vgem_basic@dmabuf-export
-igt@vgem_basic@dmabuf-fence
-igt@vgem_basic@dmabuf-fence-before
-igt@vgem_basic@dmabuf-mmap
-igt@vgem_basic@mmap
-igt@vgem_basic@second-client
-igt@vgem_basic@sysfs
-
-# All tests that do module unloading and reloading are executed last.
-# They will sometimes reveal issues of earlier tests leaving the
-# driver in a broken state that is not otherwise noticed in that test.
-
-igt@core_hotunplug@unbind-rebind
-igt@vgem_basic@unload
-igt@i915_module_load@reload
-igt@gem_lmem_swapping@basic
-igt@gem_lmem_swapping@parallel-random-engines
-igt@gem_lmem_swapping@random-engines
-igt@gem_lmem_swapping@verify-random
-igt@i915_pm_rpm@module-reload
-
-# Kernel selftests
-igt@i915_selftest@live
-igt@dmabuf@all
-
-# System wide suspend tests
-igt@i915_suspend@basic-s2idle-without-i915
-igt@i915_suspend@basic-s3-without-i915
-igt@gem_exec_suspend@basic-s0
-igt@gem_exec_suspend@basic-s3
-igt@kms_chamelium@common-hpd-after-suspend
-igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a
+igt@meta_test@fail-result

Signature · 1 line

2.25.1

Patchwork

2022-06-16 05:16 UTC #4 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for tests/i915/gem_busy : Added subtests description

In reply to [email protected]

== Series Details ==

Series: tests/i915/gem_busy : Added subtests description
URL : https://patchwork.freedesktop.org/series/105199/
State : failure

== Summary ==

CI Bug Log - changes from IGT_6531 -> IGTPW_7320
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_7320 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_7320, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7320/index.html

Participating hosts (41 -> 44)
------------------------------

Additional (4): bat-adlm-1 bat-atsm-1 fi-apl-guc fi-tgl-u2
Missing (1): fi-bdw-samus

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_7320:

### IGT changes ###

#### Possible regressions ####

* igt@runner@aborted:
- fi-hsw-g3258: NOTRUN -> [FAIL][42]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7320/fi-hsw-g3258/igt@[email protected]

New tests
---------

New tests have been introduced between IGT_6531 and IGTPW_7320:

### New IGT tests (1) ###

* igt@meta_test@fail-result:
- Statuses : 41 fail(s)
- Exec time: [0.00, 0.32] s

Known issues
------------

Here are the changes found in IGTPW_7320 that come from known issues:

### IGT changes ###

#### Warnings ####

* igt@runner@aborted:
- fi-hsw-4770: [FAIL][43] ([i915#4312] / [i915#5594]) -> [FAIL][44] ([i915#5594])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6531/fi-hsw-4770/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7320/fi-hsw-4770/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#5594]: https://gitlab.freedesktop.org/drm/intel/issues/5594
[i915#6244]: https://gitlab.freedesktop.org/drm/intel/issues/6244

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6531 -> IGTPW_7320

CI-20190529: 20190529
CI_DRM_11763: 28dae5c6593607d377d2a2b1473b041a300e7e78 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_7320: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7320/index.html
IGT_6531: 6a784f0136ea53e044f6ec866bc9837d839869d5 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7320/index.html

Patchwork

2022-06-21 13:26 UTC #5 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for tests/i915/gem_busy : Added subtests description (rev2)

In reply to [email protected]

== Series Details ==

Series: tests/i915/gem_busy : Added subtests description (rev2)
URL : https://patchwork.freedesktop.org/series/105199/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_11788 -> IGTPW_7353
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_7353 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_7353, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7353/index.html

Participating hosts (41 -> 41)
------------------------------

Additional (3): bat-dg2-8 bat-dg2-9 bat-adls-5
Missing (3): fi-icl-u2 fi-bdw-samus fi-pnv-d510

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_7353:

### IGT changes ###

#### Possible regressions ####

New tests
---------

New tests have been introduced between CI_DRM_11788 and IGTPW_7353:

### New IGT tests (1) ###

* igt@meta_test@fail-result:
- Statuses : 41 fail(s)
- Exec time: [0.00, 0.22] s

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6537 -> IGTPW_7353

CI-20190529: 20190529
CI_DRM_11788: ec6f2ba27fe4ed0f5f6aca3977f62793b65bb1b6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_7353: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7353/index.html
IGT_6537: 331658a8475c8b0c0f7ffe5268a7318ef83da34e @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7353/index.html