iio: dac: stm32-dac: Replace open coded str_enable_disable()
PATCH 1/1 iio: dac: stm32-dac: Replace open coded str_enable_disable()
Replace open coded str_enable_disable() in error message in stm32_dac_set_enable_state().
Signed-off-by Andy Shevchenko <[email protected]>
--- drivers/iio/dac/stm32-dac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/iio/dac/stm32-dac.c +2 -2
@@ -14,6 +14,7 @@#include <linux/module.h> #include <linux/platform_device.h> #include <linux/pm_runtime.h> +#include <linux/string_helpers.h> #include "stm32-dac-core.h"
@@ -79,8 +80,7 @@ static int stm32_dac_set_enable_state(struct iio_dev *indio_dev, int ch, ret =regmap_update_bits (dac->common->regmap,STM32_DAC_CR , msk, en);mutex_unlock (&dac->lock);if (ret <0 ) { -dev_err (&indio_dev->dev,"%s failed\n" , en ? -"Enable" :"Disable" ); +dev_err (&indio_dev->dev,"%s failed\n" ,str_enable_disable (en)); goto err_put_pm; }
Signature · 1 line
2.35.1
Quoted 4 lines · On Fri, 17 Jun 2022 01:00:23 +0300 Andy Shevchenko…
Replace open coded
str_enable_disable()in error message instm32_dac_set_enable_state().Signed-off-by Andy Shevchenko <[email protected]>
+CC Fabrice.
Looks good + harmless to me, so I'll pick it up now, but still time for any additional feedback as I'll only push it out for 0-day to poke at initially.
Applied to the togreg branch of iio.git.
Thanks,
Jonathan
Quoted 26 lines
--- drivers/iio/dac/stm32-dac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/iio/dac/stm32-dac.c +2
-2@@ -14,6 +14,7 @@#include <linux/module.h> #include <linux/platform_device.h> #include <linux/pm_runtime.h> +#include <linux/string_helpers.h> #include "stm32-dac-core.h" @@ -79,8 +80,7 @@ static int stm32_dac_set_enable_state(struct iio_dev *indio_dev, int ch, ret =regmap_update_bits (dac->common->regmap,STM32_DAC_CR , msk, en);mutex_unlock (&dac->lock);if (ret <0 ) { -dev_err (&indio_dev->dev,"%s failed\n" , en ? -"Enable" :"Disable" ); +dev_err (&indio_dev->dev,"%s failed\n" ,str_enable_disable (en)); goto err_put_pm; }