checkpatch-fix-incorrect-camelcase-detection-on-numeric-constant.patch removed from -mm tree
The quilt patch titled
Subject: checkpatch: fix incorrect camelcase detection on numeric constant
has been removed from the -mm tree. Its filename was
checkpatch-fix-incorrect-camelcase-detection-on-numeric-constant.patch
This patch was dropped because it was merged into the mm-nonmm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: Antonio Borneo <[email protected]>
Subject: checkpatch: fix incorrect camelcase detection on numeric constant
Date: Mon, 13 Jun 2022 12:00:55 +0200
The code fragment below
int foo(int *array, int index)
{
return array[index & 0xFF];
}triggers an incorrect camelcase detection by checking a substring of the hex constant:
CHECK: Avoid CamelCase: <xFF> #3: FILE: test.c:3: + return array[index & 0xFF];
This is caused by passing the whole string "array[index & 0xFF]" to the inner loop that iterates over a "$Ident" match. The numeric constant is not a $Ident as it doesn't start with [A-Za-z_] and should be excluded from the match.
Similar issue can be detected with other constants like "1uL", "0xffffU".
Force the match to start at word boundary so the $Ident will be properly checked starting from its first char and the constants will be filtered-out.
---
scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/checkpatch.pl renamed from scripts/checkpatch.pl~checkpatch-fix-incorrect-camelcase-detection-on-numeric-constant +1 -1
@@ -5721,7 +5721,7 @@ sub process { $var !~ /^(?:[a-z0-9_]*|[A-Z0-9_]*)?_?[a-z][A-Z](?:_[a-z0-9_]+|_[A-Z0-9_]+)?$/ && #Ignore some three character SI units explicitly, like MiB and KHz $var !~ /^(?:[a-z_]*?)_?(?:[KMGT]iB|[KMGT]?Hz)(?:_[a-z_]+)?$/) { - while ($var =~ m{($Ident)}g) { + while ($var =~ m{\b($Ident)}g) { my $word = $1; next if ($word !~ /[A-Z][a-z]|[a-z][A-Z]/); if ($check) {
_
Patches currently in -mm which might be from [email protected] are