Skip to contentSkip to conversation

Documentation: kbuild: fix typo in kconfig-language.rst

PATCH In review SangYuhiter 3 participants 3 messages Jun 19, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Documentation: kbuild: fix typo in kconfig-language.rst

change "default y/m" to "default y/n"
add " should be "default y" " in default section d)

---
 Documentation/kbuild/kconfig-language.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/kbuild/kconfig-language.rst +2 -2
index a7173843a294..ae3add11d5e7 100644
@@ -92,7 +92,7 @@ applicable everywhere (see syntax).
  release to release.
 
  Note:
-	Things that merit "default y/m" include:
+	Things that merit "default y/n" include:
 
 	a) A new Kconfig option for something that used to always be built
 	   should be "default y".
@@ -105,7 +105,7 @@ applicable everywhere (see syntax).
 	   "default n". This allows you to provide sane defaults.
 
 	d) Hardware or infrastructure that everybody expects, such as CONFIG_NET
-	   or CONFIG_BLOCK. These are rare exceptions.
+	   or CONFIG_BLOCK, should be "default y". These are rare exceptions.
 
 - type definition + default value::
 
Signature · 1 line
2.17.1
reviewer
#1 lore raw
Quoted 13 lines · SangYuhiter

change "default y/m" to "default y/n"
add " should be "default y" " in default section d)

---
 Documentation/kbuild/kconfig-language.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/kbuild/kconfig-language.rst +0 -0
index a7173843a294..ae3add11d5e7 100644

Documentation/kbuild/kconfig-language.rst applicable everywhere (see syntax). · line 95

Quoted 5 lines
Documentation/kbuild/kconfig-language.rst +1 -1
@@ -92,7 +92,7 @@ applicable everywhere (see syntax).
  release to release.
 
  Note:
-	Things that merit "default y/m" include:
+	Things that merit "default y/n" include:

"y/m" is correct here, so NAK.

Quoted 12 lines
Documentation/kbuild/kconfig-language.rst +1 -1
 	a) A new Kconfig option for something that used to always be built
 	   should be "default y".
@@ -105,7 +105,7 @@ applicable everywhere (see syntax).
 	   "default n". This allows you to provide sane defaults.
 
 	d) Hardware or infrastructure that everybody expects, such as CONFIG_NET
-	   or CONFIG_BLOCK. These are rare exceptions.
+	   or CONFIG_BLOCK, should be "default y". These are rare exceptions.
 
 - type definition + default value::
 
Signature · 1 line
~Randy
#2 lore raw
In reply to SangYuhiter

Documentation/kbuild/kconfig-language.rst applicable everywhere (see syntax). · line 95

Quoted 3 lines · SangYuhiter

Note:

Documentation/kbuild/kconfig-language.rst +1 -1
-	Things that merit "default y/m" include:
+	Things that merit "default y/n" include:

This is incorrect. it's Y(es) or M(odule).